forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix content-encoding handling with buggy servers.
Some servers will serve compressed filetypes with "content-encoding: gzip" because the file's contents were gzipped, even though the server is not re-encoding the contents at all. The code in Filter::FixupEncodingTypes() attempts to work around this by inferring whether the file is a gzip file with bogus encoding based on the file extension in the URL, but this doesn't work when the file being downloaded comes from a page whose extension doesn't reveal the downloaded file type. This change adds code to FixupEncodingTypes to also consider the download filename, supplied by the "content-disposition" header, if any. This means that we now behave correctly in the case where: -> GET /foo.php?download <- HTTP/1.1 200 OK <- ... <- Content-Disposition: attachment;filename="foo.tar.gz" <- ... <- Content-Encoding: gzip BUG=83292 TEST=unit,trybot Review URL: https://codereview.chromium.org/206503006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258729 0039d316-1c4b-4281-b951-d872f2087c98
- Loading branch information
ellyjones@chromium.org
committed
Mar 22, 2014
1 parent
03cc885
commit 2621917
Showing
6 changed files
with
52 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters