Skip to content

Commit

Permalink
Re-enable potential victim tests of orientation reset issue
Browse files Browse the repository at this point in the history
Some of the tests disabled by https://crrev.com/c/1951894 are due to
unexpected device orientation change possibly caused by previously
runned tests changing orientation but never resetting back. Now that
we have reset orientation in http://crrev.com/c/1972942, re-enable
these tests to see if the problem is resolved.

Bug: 1033970, 1030561, 1030562
Change-Id: I41c7bfba8d3a8962423d571196190475e821bc20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1976014
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#726401}
  • Loading branch information
Yue Zhang authored and Commit Bot committed Dec 19, 2019
1 parent fc391b3 commit 28067db
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
import org.chromium.base.test.util.CallbackHelper;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisableIf;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.FlakyTest;
import org.chromium.base.test.util.Restriction;
Expand Down Expand Up @@ -451,7 +450,6 @@ public void testSearchBookmarks_Delete() throws Exception {
@MediumTest
@Feature({"RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "Flaky. crbug.com/1030561")
public void testBookmarkFolderIcon(boolean nightModeEnabled) throws Exception {
BookmarkPromoHeader.forcePromoStateForTests(BookmarkPromoHeader.PromoState.PROMO_NONE);
BookmarkId testId = addFolder(TEST_FOLDER_TITLE);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import org.chromium.base.test.params.ParameterAnnotations;
import org.chromium.base.test.params.ParameterizedRunner;
import org.chromium.base.test.util.CommandLineFlags;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.base.test.util.UrlUtils;
import org.chromium.chrome.R;
Expand Down Expand Up @@ -181,7 +180,6 @@ public static void tearDownAfterActivityDestroyed() {
@MediumTest
@Feature({"ArticleSnippets", "RenderTest"})
@ParameterAnnotations.UseMethodParameter(NightModeTestUtils.NightModeParams.class)
@DisabledTest(message = "Flaky. crbug.com/1030562")
public void testSnippetAppearance(boolean nightModeEnabled) throws IOException {
SuggestionsCategoryInfo fullCategoryInfo = new SuggestionsCategoryInfo(FULL_CATEGORY,
"Section Title", ContentSuggestionsCardLayout.FULL_CARD,
Expand Down

0 comments on commit 28067db

Please sign in to comment.