Skip to content

Commit

Permalink
WebKit LayoutTests needs more resources.
Browse files Browse the repository at this point in the history
It needs the PerformanceTests directory. This should fix the following
failures;
 * fast/harness/perftests/perf-runner-compute-statistics.html
 * fast/harness/perftests/runs-per-second-iterations.html
 * fast/harness/perftests/runs-per-second-log.html
 * fast/harness/perftests/measure-frame-time.html
 * fast/harness/perftests/measure-time.html
Which are failing with;
 CONSOLE ERROR: line 66: Uncaught ReferenceError: PerfTestRunner is not
 defined

It needs the extracted devtools resources (bug https://crbug.com/693723
created for this). This should fix the following failures;
 * inspector-protocol/heap-profiler/heap-samples-in-snapshot.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree.html
 * inspector-protocol/heap-profiler/heap-snapshot-with-event-listener.html
Which are failing with;
 TypeError: HeapSnapshotWorker.HeapSnapshotLoader is not a constructor

BUG=52475,693723
NOTRY=true

Review-Url: https://codereview.chromium.org/2705653002
Cr-Commit-Position: refs/heads/master@{#451412}
  • Loading branch information
mithro authored and Commit bot committed Feb 18, 2017
1 parent bb3232b commit 2bf83ac
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -931,6 +931,7 @@ if (!is_ios) {
testonly = true
data_deps = [
"//content/shell:content_shell",
"//third_party/WebKit/public:blink_devtools_frontend_resources_files",
"//third_party/mesa:osmesa",
"//tools/imagediff",
]
Expand Down Expand Up @@ -968,6 +969,7 @@ if (!is_ios) {
"//testing/xvfb.py",
"//testing/scripts/run_isolated_script_test.py",
"//third_party/WebKit/LayoutTests/",
"//third_party/WebKit/PerformanceTests/",
"//third_party/WebKit/Tools/Scripts/",
"$root_build_dir/resources/inspector/",
]
Expand Down
4 changes: 4 additions & 0 deletions third_party/WebKit/Source/devtools/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,10 @@ devtools_applications = [

visibility = [ "//third_party/WebKit/*" ]

group("devtools_all_files") {
data = all_devtools_files
}

group("devtools_frontend_resources") {
public_deps = [
":build_release_devtools",
Expand Down
6 changes: 6 additions & 0 deletions third_party/WebKit/public/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,12 @@ group("blink_devtools_frontend_resources") {
]
}

group("blink_devtools_frontend_resources_files") {
data_deps = [
"//third_party/WebKit/Source/devtools:devtools_all_files",
]
}

group("blink_generate_devtools_grd") {
public_deps = [
"//third_party/WebKit/Source/devtools:generate_devtools_grd",
Expand Down

0 comments on commit 2bf83ac

Please sign in to comment.