Skip to content

Commit

Permalink
Revert of Turn on Kasko hang reports (patchset chromium#4 id:60001 of h…
Browse files Browse the repository at this point in the history
…ttps://codereview.chromium.org/1683343002/ )

Reason for revert:
This feature was meant to only be activated for a day on canary. The revert was planned.

Original issue's description:
> Turn on Kasko hang reports
>
> The goal is to activate it on the canary channel for only one day. This Cl will get reverted the day after being committed.
>
> BUG=585953
>
> Committed: https://crrev.com/238e1922ec9f18d4a4db3371a85fa4221dabecf6
> Cr-Commit-Position: refs/heads/master@{#375647}

TBR=thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=585953

Review URL: https://codereview.chromium.org/1710513002

Cr-Commit-Position: refs/heads/master@{#375988}
  • Loading branch information
plmonette-zz authored and Commit bot committed Feb 17, 2016
1 parent 550e1c0 commit 2e8036e
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions build/common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,12 @@
# See https://github.com/google/syzygy/wiki/SyzyASanHowTo
'syzyasan%': 0,

# Enable crash reporting via Kasko.
'kasko%': 0,

# Enable hang reports in Kasko. Requires Kasko to be enabled.
'kasko_hang_reports%': 0,

# Enable building with LSan (Clang's -fsanitize=leak option).
# -fsanitize=leak only works with clang, but lsan=1 implies clang=1
# See https://sites.google.com/a/chromium.org/dev/developers/testing/leaksanitizer
Expand Down Expand Up @@ -1054,18 +1060,8 @@
# http://crbug.com/574476
'fastbuild%': 2,
}],

# Enable crash reporting via Kasko.
['OS=="win" and target_arch=="ia32" and branding=="Chrome"', {
'kasko%': 1,
}, {
'kasko%': 0,
}]
],

# Enable hang reports in Kasko. Requires Kasko to be enabled.
'kasko_hang_reports%': 1,

# Setting this to '0' will cause V8's startup snapshot to be
# embedded in the binary instead of being a external files.
'v8_use_external_startup_data%': 1,
Expand Down

0 comments on commit 2e8036e

Please sign in to comment.