Skip to content

Commit

Permalink
vr: Make an undefined method pure virtual.
Browse files Browse the repository at this point in the history
GvrDelegateProvider::OnListeningForActivateChanged() is not defined, yet
isn't marked as pure virtual. This is suspected to be the cause of the
orderfile bot failing (see the linked bug), as the error message says:
"the vtable symbol may be undefined because the class is missing its key
function", and a key function is "the first non-pure, non-inline,
virtual method".

TBR=kbr

Bug: 747342
Change-Id: I32f70a0aaac9130692f36b1976b18f0df874df2f
Reviewed-on: https://chromium-review.googlesource.com/586722
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#489665}
  • Loading branch information
Benoit Lize authored and Commit Bot committed Jul 26, 2017
1 parent dac3661 commit 355bf78
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion device/vr/android/gvr/gvr_delegate_provider.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class DEVICE_VR_EXPORT GvrDelegateProvider {
virtual GvrDelegate* GetDelegate() = 0;
virtual void OnDisplayAdded(VRDisplayImpl* display) = 0;
virtual void OnDisplayRemoved(VRDisplayImpl* display) = 0;
virtual void OnListeningForActivateChanged(VRDisplayImpl* display);
virtual void OnListeningForActivateChanged(VRDisplayImpl* display) = 0;
virtual void CreateVRDisplayInfo(
const base::Callback<void(mojom::VRDisplayInfoPtr)>& callback,
uint32_t device_id) = 0;
Expand Down

0 comments on commit 355bf78

Please sign in to comment.