Skip to content

Commit

Permalink
libstdc++: std::vector cannot have const members in AccountSelectionB…
Browse files Browse the repository at this point in the history
…ubbleView.

Implementation of std::vector in libstdc++ does not allow const
members.

Fixes the compilation error:
    /usr/include/c++/11/bits/stl_vector.h: In instantiation of ‘class std::vector<const content::IdentityRequestAccount>’:
    ../../chrome/browser/ui/views/webid/account_selection_bubble_view.h:131:60:   required from here
    /usr/include/c++/11/bits/stl_vector.h:401:66: error: static assertion failed: std::vector must have a non-const, non-volatile value_type
      401 |       static_assert(is_same<typename remove_cv<_Tp>::type, _Tp>::value,
          |                                                                  ^~~~~

Bug: 957519
Change-Id: I5bd822243c77526a31db8f152de0326365705522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3729260
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1018688}
  • Loading branch information
jdapena authored and Chromium LUCI CQ committed Jun 28, 2022
1 parent b8bdedd commit 35723ee
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ class AccountSelectionBubbleView : public views::BubbleDialogDelegateView {

// The list of accounts to select from. Not updated when the user selects an
// account and navigates to the privacy policy / terms of service page.
const std::vector<const content::IdentityRequestAccount> account_list_;
const std::vector<content::IdentityRequestAccount> account_list_;

// The TabStripModel of the current browser. We need this in order to show the
// privacy policy and terms of service urls when the user clicks on the links.
Expand Down

0 comments on commit 35723ee

Please sign in to comment.