Replace HashMap with SparseArray in UsbMidiDeviceAndroid.java.

Android lint suggests replacing HashMap<Integer, Xyz> with SparseArray<Xyz> for better memory efficiency. BUG=347356 NOTRY=true Review URL: https://codereview.chromium.org/181593009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254583 0039d316-1c4b-4281-b951-d872f2087c98
Denger-Network · Mar 3, 2014 · 37d973f · 37d973f
1 parent 8acc1d9
commit 37d973f
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/media/base/android/java/src/org/chromium/media/UsbMidiDeviceAndroid.java b/media/base/android/java/src/org/chromium/media/UsbMidiDeviceAndroid.java
@@ -11,6 +11,7 @@
 import android.hardware.usb.UsbInterface;
 import android.hardware.usb.UsbManager;
 import android.hardware.usb.UsbRequest;
+import android.util.SparseArray;
 
 import org.chromium.base.CalledByNative;
 import org.chromium.base.JNINamespace;
@@ -33,7 +34,7 @@ class UsbMidiDeviceAndroid {
     /**
      * A map from endpoint number to UsbEndpoint.
      */
-    private final Map<Integer, UsbEndpoint> mEndpointMap;
+    private final SparseArray<UsbEndpoint> mEndpointMap;
 
     /**
      * A map from UsbEndpoint to UsbRequest associated to it.
@@ -52,7 +53,7 @@ class UsbMidiDeviceAndroid {
      */
     UsbMidiDeviceAndroid(UsbManager manager, UsbDevice device) {
         mConnection = manager.openDevice(device);
-        mEndpointMap = new HashMap<Integer, UsbEndpoint>();
+        mEndpointMap = new SparseArray<UsbEndpoint>();
         mRequestMap = new HashMap<UsbEndpoint, UsbRequest>();
 
         for (int i = 0; i < device.getInterfaceCount(); ++i) {
@@ -81,14 +82,12 @@ void send(int endpointNumber, byte[] bs) {
         if (mConnection == null) {
             return;
         }
-        if (!mEndpointMap.containsKey(endpointNumber)) {
+        UsbEndpoint endpoint = mEndpointMap.get(endpointNumber);
+        if (endpoint == null) {
             return;
         }
-        UsbEndpoint endpoint = mEndpointMap.get(endpointNumber);
-        UsbRequest request;
-        if (mRequestMap.containsKey(endpoint)) {
-            request = mRequestMap.get(endpoint);
-        } else {
+        UsbRequest request = mRequestMap.get(endpoint);
+        if (request == null) {
             request = new UsbRequest();
             request.initialize(mConnection, endpoint);
             mRequestMap.put(endpoint, request);