Skip to content

Commit

Permalink
--no-sandbox is added for Windows ASAN.
Browse files Browse the repository at this point in the history
As sandbox is not yet supported by ASAN in Windows, it's better to add
--no-sandbox there.

Change-Id: I38430c95b4a0f5cfeee3ab389ddcb3e78721c027
Reviewed-on: https://chromium-review.googlesource.com/968421
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544765}
  • Loading branch information
Alexander Dunaev authored and Commit Bot committed Mar 21, 2018
1 parent 76a76b6 commit 384ba48
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tools/mb/mb.py
Original file line number Diff line number Diff line change
Expand Up @@ -1022,6 +1022,11 @@ def GetIsolateCommand(self, target, vals):
self.WriteFailureAndRaise('No command line for %s found (test type %s).'
% (target, test_type), output_path=None)

if is_win and asan:
# Sandbox is not yet supported by ASAN for Windows.
# Perhaps this is only needed for tests that use the sandbox?
cmdline.append('--no-sandbox')

cmdline += isolate_map[target].get('args', [])

return cmdline, extra_files
Expand Down

0 comments on commit 384ba48

Please sign in to comment.