Implement NameInHeapSnapshot for all TraceWrapperBase objects.

Currently some DOM objects in DevTools heap snapshot show up as
"UnknownNode" because the corresponding TraceWrapperBase objects do
not implement the NameInHeapSnapshot method. This patch fixes it.

The patch also makes NameInHeapSnapshot pure.

Bug: 811925
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I495a75c5ee0c9f765a6d94daed62cf34c345d124
Reviewed-on: https://chromium-review.googlesource.com/966423
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543717}

third_party/WebKit/Source/bindings/core/v8/ScriptWrappableMarkingVisitorTest.cpp

@@ -250,6 +250,7 @@ class HandleContainer
   void TraceWrappers(const ScriptWrappableVisitor* visitor) const {
     visitor->TraceWrappers(handle_.Cast<v8::Value>());
   }
+  const char* NameInHeapSnapshot() const override { return "HandleContainer"; }
 
   void SetValue(v8::Isolate* isolate, v8::Local<v8::String> string) {
     handle_.Set(isolate, string);
@@ -472,11 +473,13 @@ class Base : public blink::GarbageCollected<Base>,
     return new Base(wrapper_in_base, wrapper_in_mixin);
   }
 
-  virtual void TraceWrappers(const ScriptWrappableVisitor* visitor) const {
+  void TraceWrappers(const ScriptWrappableVisitor* visitor) const override {
     visitor->TraceWrappers(wrapper_in_base_);
     Mixin::TraceWrappers(visitor);
   }
 
+  const char* NameInHeapSnapshot() const override { return "HandleContainer"; }
+
  protected:
   Base(DeathAwareScriptWrappable* wrapper_in_base,
        DeathAwareScriptWrappable* wrapper_in_mixin)

third_party/WebKit/Source/bindings/core/v8/V8NodeFilterCondition.h

@@ -59,7 +59,10 @@ class V8NodeFilterCondition final
 
   ~V8NodeFilterCondition();
   virtual void Trace(blink::Visitor* visitor) {}
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "V8NodeFilterCondition";
+  }
 
   unsigned acceptNode(Node*, ExceptionState&);
   v8::Local<v8::Value> Callback(v8::Isolate* isolate) const {

third_party/WebKit/Source/core/css/StyleEngine.h

@@ -310,7 +310,8 @@ class CORE_EXPORT StyleEngine final
       const AtomicString& animation_name);
 
   virtual void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override { return "StyleEngine"; }
 
  private:
   // FontSelectorClient implementation.

third_party/WebKit/Source/core/css/StyleSheetCollection.h

@@ -67,7 +67,10 @@ class CORE_EXPORT StyleSheetCollection
   void MarkSheetListDirty() { sheet_list_dirty_ = true; }
 
   virtual void Trace(blink::Visitor*);
-  virtual void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "StyleSheetCollection";
+  }
 
   void Dispose();
 

third_party/WebKit/Source/core/dom/DocumentParser.h

@@ -44,6 +44,7 @@ class CORE_EXPORT DocumentParser
   virtual ~DocumentParser();
   virtual void Trace(blink::Visitor*);
   void TraceWrappers(const ScriptWrappableVisitor*) const override {}
+  const char* NameInHeapSnapshot() const override { return "DocumentParser"; }
 
   virtual ScriptableDocumentParser* AsScriptableDocumentParser() {
     return nullptr;

third_party/WebKit/Source/core/dom/ElementShadow.h

@@ -74,7 +74,8 @@ class CORE_EXPORT ElementShadow final : public GarbageCollected<ElementShadow>,
   }
 
   void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override { return "ElementShadow"; }
 
  private:
   ElementShadow();

third_party/WebKit/Source/core/dom/ElementShadowV0.h

@@ -55,7 +55,8 @@ class CORE_EXPORT ElementShadowV0 final
   void ClearDistribution();
 
   void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override { return "ElementShadowV0"; }
 
  private:
   explicit ElementShadowV0(ElementShadow&);

third_party/WebKit/Source/core/dom/FrameRequestCallbackCollection.h

@@ -31,7 +31,8 @@ class CORE_EXPORT FrameRequestCallbackCollection final
         public TraceWrapperBase {
    public:
     virtual void Trace(blink::Visitor* visitor) {}
-    virtual void TraceWrappers(const ScriptWrappableVisitor* visitor) const {}
+    void TraceWrappers(const ScriptWrappableVisitor* visitor) const override {}
+    const char* NameInHeapSnapshot() const override { return "FrameCallback"; }
     virtual ~FrameCallback() = default;
     virtual void Invoke(double) = 0;
 
@@ -61,7 +62,10 @@ class CORE_EXPORT FrameRequestCallbackCollection final
       return new V8FrameCallback(callback);
     }
     void Trace(blink::Visitor*);
-    void TraceWrappers(const ScriptWrappableVisitor*) const;
+    void TraceWrappers(const ScriptWrappableVisitor*) const override;
+    const char* NameInHeapSnapshot() const override {
+      return "V8FrameCallback";
+    }
     ~V8FrameCallback() override = default;
     void Invoke(double) override;
 
@@ -77,7 +81,10 @@ class CORE_EXPORT FrameRequestCallbackCollection final
   bool IsEmpty() const { return !callbacks_.size(); }
 
   void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "FrameRequestCallbackCollection";
+  }
 
  private:
   using CallbackList = HeapVector<TraceWrapperMember<FrameCallback>>;

third_party/WebKit/Source/core/dom/MutationObserver.h

@@ -95,7 +95,10 @@ class CORE_EXPORT MutationObserver final
     virtual void Deliver(const MutationRecordVector& records,
                          MutationObserver&) = 0;
     virtual void Trace(blink::Visitor* visitor) {}
-    virtual void TraceWrappers(const ScriptWrappableVisitor* visitor) const {}
+    void TraceWrappers(const ScriptWrappableVisitor* visitor) const override {}
+    const char* NameInHeapSnapshot() const override {
+      return "MutationObserver::Delegate";
+    }
   };
 
   class CORE_EXPORT V8DelegateImpl;

third_party/WebKit/Source/core/dom/MutationObserverRegistration.h

@@ -84,7 +84,10 @@ class CORE_EXPORT MutationObserverRegistration final
   void Dispose();
 
   void Trace(blink::Visitor*);
-  virtual void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "MutationObserverRegistration";
+  }
 
  private:
   MutationObserverRegistration(MutationObserver&,

third_party/WebKit/Source/core/dom/ScriptedAnimationController.h

@@ -51,7 +51,10 @@ class CORE_EXPORT ScriptedAnimationController
   virtual ~ScriptedAnimationController() = default;
 
   void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "ScriptedAnimationController";
+  }
   void ClearDocumentPointer() { document_ = nullptr; }
 
   // Animation frame callbacks are used for requestAnimationFrame().

third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h

@@ -34,7 +34,10 @@ class CORE_EXPORT ScriptedIdleTaskController
   ~ScriptedIdleTaskController();
 
   void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "ScriptedIdleTaskController";
+  }
 
   using CallbackId = int;
 
@@ -45,6 +48,7 @@ class CORE_EXPORT ScriptedIdleTaskController
    public:
     virtual void Trace(blink::Visitor* visitor) {}
     virtual void TraceWrappers(const ScriptWrappableVisitor* visitor) const {}
+    const char* NameInHeapSnapshot() const override { return "IdleTask"; }
     virtual ~IdleTask() = default;
     virtual void invoke(IdleDeadline*) = 0;
   };

third_party/WebKit/Source/core/html/custom/CustomElementDefinition.h

@@ -38,7 +38,10 @@ class CORE_EXPORT CustomElementDefinition
   virtual ~CustomElementDefinition();
 
   virtual void Trace(blink::Visitor*);
-  virtual void TraceWrappers(const ScriptWrappableVisitor* visitor) const {}
+  void TraceWrappers(const ScriptWrappableVisitor* visitor) const override {}
+  const char* NameInHeapSnapshot() const override {
+    return "CustomElementDefinition";
+  }
 
   const CustomElementDescriptor& Descriptor() { return descriptor_; }
 

third_party/WebKit/Source/core/html/custom/CustomElementReactionStack.h

@@ -24,7 +24,10 @@ class CORE_EXPORT CustomElementReactionStack final
   CustomElementReactionStack();
 
   void Trace(blink::Visitor*);
-  virtual void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "CustomElementReactionStack";
+  }
 
   void Push();
   void PopInvokingReactions();

third_party/WebKit/Source/core/html/imports/HTMLImportTreeRoot.h

@@ -35,7 +35,10 @@ class HTMLImportTreeRoot final : public HTMLImport, public TraceWrapperBase {
   HTMLImportChild* Find(const KURL&) const;
 
   virtual void Trace(blink::Visitor*);
-  virtual void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "HTMLImportTreeRoot";
+  }
 
  private:
   explicit HTMLImportTreeRoot(Document*);

third_party/WebKit/Source/core/html/imports/HTMLImportsController.h

@@ -73,6 +73,9 @@ class HTMLImportsController final
   void Dispose();
 
   void TraceWrappers(const ScriptWrappableVisitor*) const;
+  const char* NameInHeapSnapshot() const override {
+    return "HTMLImportsController";
+  }
 
  private:
   explicit HTMLImportsController(Document&);

third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h

@@ -95,6 +95,9 @@ class ImageBitmapFactories final
 
   void Trace(blink::Visitor*);
   void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "ImageBitmapLoader";
+  }
 
  private:
   class ImageBitmapLoader final

third_party/WebKit/Source/core/intersection_observer/ElementIntersectionObserverData.h

@@ -30,7 +30,10 @@ class ElementIntersectionObserverData
   void DeactivateAllIntersectionObservers(Node&);
 
   void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "ElementIntersectionObserverData";
+  }
 
  private:
   // IntersectionObservers for which the Node owning this data is root.

third_party/WebKit/Source/core/intersection_observer/IntersectionObserverController.h

@@ -38,6 +38,9 @@ class IntersectionObserverController
 
   void Trace(blink::Visitor*);
   void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "IntersectionObserverController";
+  }
 
  private:
   explicit IntersectionObserverController(Document*);

third_party/WebKit/Source/core/intersection_observer/IntersectionObserverDelegate.h

@@ -23,7 +23,10 @@ class IntersectionObserverDelegate
                        IntersectionObserver&) = 0;
   virtual ExecutionContext* GetExecutionContext() const = 0;
   virtual void Trace(blink::Visitor* visitor) {}
-  virtual void TraceWrappers(const ScriptWrappableVisitor* visitor) const {}
+  void TraceWrappers(const ScriptWrappableVisitor* visitor) const override {}
+  const char* NameInHeapSnapshot() const override {
+    return "IntersectionObserverDelegate";
+  }
 };
 
 }  // namespace blink

third_party/WebKit/Source/core/layout/custom/CSSLayoutDefinition.h

@@ -50,6 +50,9 @@ class CSSLayoutDefinition final
 
     void Trace(blink::Visitor*);
     void TraceWrappers(const ScriptWrappableVisitor*) const override;
+    const char* NameInHeapSnapshot() const override {
+      return "CSSLayoutDefinition::Instance";
+    }
 
    private:
     Member<CSSLayoutDefinition> definition_;
@@ -81,6 +84,9 @@ class CSSLayoutDefinition final
 
   void Trace(blink::Visitor* visitor) {}
   void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "CSSLayoutDefinition";
+  }
 
  private:
   scoped_refptr<ScriptState> script_state_;

third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerRegistry.h

@@ -28,6 +28,9 @@ class CORE_EXPORT ModuleTreeLinkerRegistry
   }
   void Trace(blink::Visitor*);
   void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "ModuleTreeLinkerRegistry";
+  }
 
   ModuleTreeLinker* Fetch(const ModuleScriptFetchRequest&,
                           Modulator*,

third_party/WebKit/Source/core/script/HTMLParserScriptRunner.h

@@ -99,6 +99,9 @@ class HTMLParserScriptRunner final
 
   void Trace(blink::Visitor*) override;
   void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override {
+    return "HTMLParserScriptRunner";
+  }
 
  private:
   HTMLParserScriptRunner(HTMLParserReentryPermit*,

third_party/WebKit/Source/core/script/Modulator.h

@@ -43,6 +43,9 @@ class CORE_EXPORT SingleModuleClient
   virtual ~SingleModuleClient() = default;
   virtual void Trace(blink::Visitor* visitor) {}
   void TraceWrappers(const ScriptWrappableVisitor*) const override {}
+  const char* NameInHeapSnapshot() const override {
+    return "SingleModuleClient";
+  }
 
   virtual void NotifyModuleLoadFinished(ModuleScript*) = 0;
 };
@@ -56,6 +59,7 @@ class CORE_EXPORT ModuleTreeClient
   virtual ~ModuleTreeClient() = default;
   virtual void Trace(blink::Visitor* visitor) {}
   void TraceWrappers(const ScriptWrappableVisitor*) const override {}
+  const char* NameInHeapSnapshot() const override { return "ModuleTreeClient"; }
 
   virtual void NotifyModuleTreeLoadFinished(ModuleScript*) = 0;
 };
@@ -83,6 +87,7 @@ class CORE_EXPORT Modulator : public GarbageCollectedFinalized<Modulator>,
 
   virtual void Trace(blink::Visitor* visitor) {}
   void TraceWrappers(const ScriptWrappableVisitor*) const override {}
+  const char* NameInHeapSnapshot() const override { return "Modulator"; }
 
   virtual ScriptModuleResolver* GetScriptModuleResolver() = 0;
   virtual base::SingleThreadTaskRunner* TaskRunner() = 0;

third_party/WebKit/Source/core/script/ModuleMap.cpp

@@ -23,7 +23,8 @@ class ModuleMap::Entry final : public GarbageCollectedFinalized<Entry>,
   ~Entry() override {}
 
   void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override { return "ModuleMap::Entry"; }
 
   // Notify fetched |m_moduleScript| to the client asynchronously.
   void AddClient(SingleModuleClient*);

third_party/WebKit/Source/core/script/ModuleMap.h

@@ -33,7 +33,8 @@ class CORE_EXPORT ModuleMap final : public GarbageCollected<ModuleMap>,
     return new ModuleMap(modulator);
   }
   void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override { return "ModuleMap"; }
 
   // https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-single-module-script
   void FetchSingleModuleScript(const ModuleScriptFetchRequest&,

third_party/WebKit/Source/core/script/ModuleScript.h

@@ -62,7 +62,8 @@ class CORE_EXPORT ModuleScript final : public Script, public TraceWrapperBase {
                               String* failure_reason = nullptr);
 
   void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override { return "ModuleScript"; }
 
  private:
   ModuleScript(Modulator* settings_object,

third_party/WebKit/Source/core/script/PendingScript.h

@@ -83,6 +83,7 @@ class CORE_EXPORT PendingScript
 
   virtual void Trace(blink::Visitor*);
   void TraceWrappers(const ScriptWrappableVisitor*) const override {}
+  const char* NameInHeapSnapshot() const override { return "PendingScript"; }
 
   // Returns false if the script should not be run due to MIME type check.
   // Should be called just before GetSource().

third_party/WebKit/Source/core/script/ScriptLoader.h

@@ -62,7 +62,8 @@ class CORE_EXPORT ScriptLoader : public GarbageCollectedFinalized<ScriptLoader>,
 
   ~ScriptLoader() override;
   virtual void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override { return "ScriptLoader"; }
 
   enum LegacyTypeSupport {
     kDisallowLegacyTypeInTypeAttribute,

third_party/WebKit/Source/core/script/ScriptRunner.h

@@ -67,7 +67,8 @@ class CORE_EXPORT ScriptRunner final
   static void MovePendingScript(Document&, Document&, ScriptLoader*);
 
   void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override { return "ScriptRunner"; }
 
  private:
   class Task;

third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h

@@ -167,7 +167,8 @@ class XMLHttpRequest final : public XMLHttpRequestEventTarget,
   DEFINE_ATTRIBUTE_EVENT_LISTENER(readystatechange);
 
   virtual void Trace(blink::Visitor*);
-  void TraceWrappers(const ScriptWrappableVisitor*) const;
+  void TraceWrappers(const ScriptWrappableVisitor*) const override;
+  const char* NameInHeapSnapshot() const override { return "XMLHttpRequest"; }
 
  private:
   class BlobLoader;