Skip to content

Commit

Permalink
Cleaning up remoting test directory
Browse files Browse the repository at this point in the history
This CL removes the ChromotingTestDriver and associated classes.  These
were used as a sort of native C++ Webapp stand-in but our backend has
changed so much that none of this code will run w/o being rewritten.
The FTL Playground is a better, working utility so we should just use
that for now.

Change-Id: Ic3dda75516a5a3486f2daf9a273b4a9fd588557a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946733
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721042}
  • Loading branch information
joedow-42 authored and Commit Bot committed Dec 3, 2019
1 parent 9f51fb7 commit 4956683
Show file tree
Hide file tree
Showing 36 changed files with 0 additions and 5,303 deletions.
2 changes: 0 additions & 2 deletions remoting/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ group("remoting_all") {

deps = [
":remoting_unittests",
"//remoting/test:chromoting_test_driver",
]

if (is_win) {
Expand Down Expand Up @@ -151,7 +150,6 @@ test("remoting_unittests") {
"//remoting/client/ui:unit_tests",
"//remoting/protocol:unit_tests",
"//remoting/signaling:unit_tests",
"//remoting/test:unit_tests",
"//testing/gmock",
"//testing/gtest",
]
Expand Down
66 changes: 0 additions & 66 deletions remoting/test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,10 @@ static_library("test_support") {
testonly = true

sources = [
"access_token_fetcher.cc",
"access_token_fetcher.h",
"chromoting_test_driver_environment.cc",
"chromoting_test_driver_environment.h",
"cli_util.cc",
"cli_util.h",
"connection_setup_info.cc",
"connection_setup_info.h",
"connection_time_observer.cc",
"connection_time_observer.h",
"cyclic_frame_generator.cc",
"cyclic_frame_generator.h",
"fake_access_token_fetcher.cc",
"fake_access_token_fetcher.h",
"fake_host_list_fetcher.cc",
"fake_host_list_fetcher.h",
"fake_ice_connection.cc",
"fake_ice_connection.h",
"fake_network_dispatcher.cc",
Expand All @@ -40,29 +28,17 @@ static_library("test_support") {
"fake_webrtc_connection.h",
"frame_generator_util.cc",
"frame_generator_util.h",
"host_info.cc",
"host_info.h",
"host_list_fetcher.cc",
"host_list_fetcher.h",
"mock_access_token_fetcher.cc",
"mock_access_token_fetcher.h",
"remote_connection_observer.h",
"remote_host_info.cc",
"remote_host_info.h",
"rgb_value.cc",
"rgb_value.h",
"scroll_frame_generator.cc",
"scroll_frame_generator.h",
"test_chromoting_client.cc",
"test_chromoting_client.h",
"test_device_id_provider.cc",
"test_device_id_provider.h",
"test_oauth_token_getter.cc",
"test_oauth_token_getter.h",
"test_token_storage.cc",
"test_token_storage.h",
"test_video_renderer.cc",
"test_video_renderer.h",
"video_frame_writer.cc",
"video_frame_writer.h",
]
Expand Down Expand Up @@ -96,24 +72,6 @@ static_library("test_support") {
]
}

executable("chromoting_test_driver") {
testonly = true

sources = [
"chromoting_test_driver.cc",
"chromoting_test_driver_tests.cc",
"chromoting_test_fixture.cc",
"chromoting_test_fixture.h",
]

deps = [
":test_support",
"//base/test:test_support",
"//build/win:default_exe_manifest",
"//testing/gtest",
]
}

if (enable_remoting_host && !is_android && !is_chromeos) {
static_library("fake_connection_event_logger") {
testonly = true
Expand Down Expand Up @@ -241,27 +199,3 @@ executable("ftl_signaling_playground") {
"//remoting/signaling",
]
}

source_set("unit_tests") {
testonly = true

sources = [
"access_token_fetcher_unittest.cc",
"chromoting_test_driver_environment_unittest.cc",
"connection_time_observer_unittest.cc",
"host_list_fetcher_unittest.cc",
"test_chromoting_client_unittest.cc",
"test_video_renderer_unittest.cc",
]

deps = [
":test_support",
"//base",
"//net:test_support",
"//services/network:test_support",
"//testing/gmock",
"//testing/gtest",
"//third_party/libyuv",
"//third_party/webrtc_overrides:webrtc_component",
]
}
199 changes: 0 additions & 199 deletions remoting/test/access_token_fetcher.cc

This file was deleted.

Loading

0 comments on commit 4956683

Please sign in to comment.