Skip to content

Commit

Permalink
Add synchronous method to NewOptimizationGuideDecider
Browse files Browse the repository at this point in the history
Some features need a synchronous method to call into the Optimization
Guide. This adds one as an option.

Bug: 1313570,1252448
Change-Id: I30bb611e513d5b9d814dbb101ef1782980601551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3578813
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#991279}
  • Loading branch information
Sophie Chang authored and Chromium LUCI CQ committed Apr 11, 2022
1 parent ad44ba4 commit 4be1b99
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ class NewOptimizationGuideDecider {
proto::OptimizationType optimization_type,
OptimizationGuideDecisionCallback callback) = 0;

// Returns whether |optimization_type| can be applied for |url|. This should
// only be called for main frame navigations or future main frame navigations.
virtual OptimizationGuideDecision CanApplyOptimization(
const GURL& url,
proto::OptimizationType optimization_type,
OptimizationMetadata* optimization_metadata) = 0;

protected:
NewOptimizationGuideDecider() = default;
virtual ~NewOptimizationGuideDecider() = default;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class OptimizationGuideService
optimization_guide::OptimizationGuideDecision CanApplyOptimization(
const GURL& url,
optimization_guide::proto::OptimizationType optimization_type,
optimization_guide::OptimizationMetadata* optimization_metadata);
optimization_guide::OptimizationMetadata* optimization_metadata) override;

// Invokes |callback| with the decision for the URL contained in
// |navigation_context| and |optimization_type|, when sufficient information
Expand Down

0 comments on commit 4be1b99

Please sign in to comment.