Skip to content

Commit

Permalink
DevTools: Correct Source Panel Show/Hide Toolbar buttons
Browse files Browse the repository at this point in the history
Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is seen in devtools.

Flipped mask positions and removed—now unnecessary—rotation transforms around show/hide panel icon containers.

BUG=671930
R=lushnikov@chromium.org
TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
are correctly aligned. crbug.com/671930

Review-Url: https://codereview.chromium.org/2600493002
Cr-Commit-Position: refs/heads/master@{#445339}
  • Loading branch information
JakeHendy authored and Commit bot committed Jan 23, 2017
1 parent aef7434 commit 4d2364e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,7 @@ Jaeseok Yoon <yjaeseok@gmail.com>
Jaideep Bajwa <bjaideep@ca.ibm.com>
Jaime Soriano Pastor <jsorianopastor@gmail.com>
Jake Helfert <jake@helfert.us>
Jake Hendy <me@jakehendy.com>
Jakob Weigert <jakob.j.w@googlemail.com>
Jakub Machacek <xtreit@gmail.com>
James Choi <jchoi42@pha.jhu.edu>
Expand Down
6 changes: 2 additions & 4 deletions third_party/WebKit/Source/devtools/front_end/ui/Icon.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,10 +169,8 @@ UI.Icon.Descriptors = {

'largeicon-show-left-sidebar': {x: -160, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true},
'largeicon-hide-left-sidebar': {x: -192, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true},
'largeicon-show-right-sidebar':
{x: -160, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true, transform: 'rotate(180deg)'},
'largeicon-hide-right-sidebar':
{x: -192, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true, transform: 'rotate(180deg)'},
'largeicon-show-right-sidebar': {x: -192, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true},
'largeicon-hide-right-sidebar': {x: -160, y: -72, width: 28, height: 24, spritesheet: 'largeicons', isMask: true},
'largeicon-show-top-sidebar': {
x: -160,
y: -72,
Expand Down

0 comments on commit 4d2364e

Please sign in to comment.