From 4d335debdd584a96cf47e68be230b19a8139f054 Mon Sep 17 00:00:00 2001 From: Brian Sheedy Date: Wed, 1 Apr 2020 20:47:32 +0000 Subject: [PATCH] Switch Skia Gold tests to use mixin Switches all tests that use Skia Gold to use a mixin instead of individually specifying arguments in each test definition. As a prerequisite, also ensures that all test types that use Skia Gold use the same naming for Gold-related arguments. This is requisite work for adding a universal Gold kill switch in the unlikely event of an outage that can't be fixed quickly, as the switch can just be added to the mixin. Bug: 1057848 Change-Id: Ib57480f374eab088ac3a389637bfbff1ee41e8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121419 Commit-Queue: Brian Sheedy Reviewed-by: Sven Zheng Reviewed-by: Sadrul Chowdhury Reviewed-by: Kenneth Russell Auto-Submit: Brian Sheedy Cr-Commit-Position: refs/heads/master@{#755521} --- .../browser_skia_gold_pixel_diff_unittest.cc | 2 +- .../skia_gold_integration_test_base.py | 47 +- docs/gpu/gpu_testing.md | 4 +- testing/buildbot/chromium.android.json | 18 +- testing/buildbot/chromium.ci.json | 1222 +++++++++-------- testing/buildbot/chromium.fyi.json | 14 +- testing/buildbot/chromium.gpu.fyi.json | 888 ++++++------ testing/buildbot/chromium.gpu.json | 288 ++-- testing/buildbot/chromium.win.json | 14 +- testing/buildbot/client.v8.fyi.json | 120 +- testing/buildbot/mixins.pyl | 12 + testing/buildbot/test_suite_exceptions.pyl | 20 +- testing/buildbot/test_suites.pyl | 174 +-- testing/buildbot/v8.ci.json | 120 +- ui/base/test/skia_gold_pixel_diff.cc | 8 +- ui/base/test/skia_gold_pixel_diff_unittest.cc | 2 +- 16 files changed, 1442 insertions(+), 1511 deletions(-) diff --git a/chrome/test/pixel/browser_skia_gold_pixel_diff_unittest.cc b/chrome/test/pixel/browser_skia_gold_pixel_diff_unittest.cc index fb647cdcdb5699..4e9458eeb303ab 100644 --- a/chrome/test/pixel/browser_skia_gold_pixel_diff_unittest.cc +++ b/chrome/test/pixel/browser_skia_gold_pixel_diff_unittest.cc @@ -42,7 +42,7 @@ class BrowserSkiaGoldPixelDiffTest : public views::test::WidgetTest { public: BrowserSkiaGoldPixelDiffTest() { auto* cmd_line = base::CommandLine::ForCurrentProcess(); - cmd_line->AppendSwitchASCII("build-revision", "test"); + cmd_line->AppendSwitchASCII("git-revision", "test"); } private: diff --git a/content/test/gpu/gpu_tests/skia_gold_integration_test_base.py b/content/test/gpu/gpu_tests/skia_gold_integration_test_base.py index 6f7d48c2f3cb49..efd733f44366f0 100644 --- a/content/test/gpu/gpu_tests/skia_gold_integration_test_base.py +++ b/content/test/gpu/gpu_tests/skia_gold_integration_test_base.py @@ -77,7 +77,7 @@ class SkiaGoldIntegrationTestBase(gpu_integration_test.GpuIntegrationTest): _skia_gold_temp_dir = None _local_run = None - _build_revision = None + _git_revision = None @classmethod def SetParsedCommandLineOptions(cls, options): @@ -123,7 +123,7 @@ def TearDownProcess(cls): def AddCommandlineArgs(cls, parser): super(SkiaGoldIntegrationTestBase, cls).AddCommandlineArgs(parser) parser.add_option( - '--build-revision', + '--git-revision', help='Chrome revision being tested.', default=None) parser.add_option( @@ -140,15 +140,15 @@ def AddCommandlineArgs(cls, parser): 'profile after the test completes; leave the system using the sRGB color ' 'profile. See http://crbug.com/784456.') parser.add_option( - '--review-patch-issue', + '--gerrit-issue', help='For Skia Gold integration. Gerrit issue ID.', default='') parser.add_option( - '--review-patch-set', + '--gerrit-patchset', help='For Skia Gold integration. Gerrit patch set number.', default='') parser.add_option( - '--buildbucket-build-id', + '--buildbucket-id', help='For Skia Gold integration. Buildbucket build ID.', default='') parser.add_option( @@ -335,16 +335,15 @@ def _GetBuildIdArgs(self): '--commit', self._GetBuildRevision(), ] - # If --review-patch-issue is passed, then we assume we're running on a - # trybot. - if parsed_options.review_patch_issue: + # If --gerrit-issue is passed, then we assume we're running on a trybot. + if parsed_options.gerrit_issue: build_id_args += [ '--issue', - parsed_options.review_patch_issue, + parsed_options.gerrit_issue, '--patchset', - parsed_options.review_patch_set, + parsed_options.gerrit_patchset, '--jobid', - parsed_options.buildbucket_build_id, + parsed_options.buildbucket_id, '--crs', 'gerrit', '--cis', @@ -439,10 +438,10 @@ def _UploadTestResultToSkiaGold(self, image_name, screenshot, # If we're running on a trybot, instead generate a link to all results # for the CL so that the user can visit a single page instead of # clicking on multiple links on potentially multiple bots. - elif parsed_options.review_patch_issue: + elif parsed_options.gerrit_issue: cl_images = ('https://%s-gold.skia.org/search?' 'issue=%s&new_clstore=true' % ( - SKIA_GOLD_INSTANCE, parsed_options.review_patch_issue)) + SKIA_GOLD_INSTANCE, parsed_options.gerrit_issue)) self.artifacts.CreateLink('triage_link_for_entire_cl', cl_images) else: try: @@ -503,7 +502,7 @@ def _ShouldReportGoldFailure(self, page): # grace period. However, fail if we're on a trybot so that as many images # can be triaged as possible before a new test is committed. if (page.grace_period_end and date.today() <= page.grace_period_end and - not parsed_options.review_patch_issue): + not parsed_options.gerrit_issue): return False return True @@ -570,25 +569,25 @@ def _IsLocalRun(cls): @classmethod def _GetBuildRevision(cls): """Returns the current git master revision being tested.""" - # Do nothing if we've already determined the build revision. - if cls._build_revision is not None: + # Do nothing if we've already determined the git revision. + if cls._git_revision is not None: pass - # use the --build-revision value if it's been set. - elif cls.GetParsedCommandLineOptions().build_revision: - cls._build_revision = cls.GetParsedCommandLineOptions().build_revision + # use the --git-revision value if it's been set. + elif cls.GetParsedCommandLineOptions().git_revision: + cls._git_revision = cls.GetParsedCommandLineOptions().git_revision # Try to determine what revision we're on using git. else: try: - cls._build_revision = subprocess.check_output( + cls._git_revision = subprocess.check_output( ['git', 'rev-parse', 'origin/master'], shell=IsWin(), cwd=path_util.GetChromiumSrcDir()).strip() - logging.warning('Automatically determined build revision to be %s', - cls._build_revision) + logging.warning('Automatically determined git revision to be %s', + cls._git_revision) except subprocess.CalledProcessError: - raise Exception('--build-revision not passed, and unable to ' + raise Exception('--git-revision not passed, and unable to ' 'determine revision using git') - return cls._build_revision + return cls._git_revision @classmethod def GenerateGpuTests(cls, options): diff --git a/docs/gpu/gpu_testing.md b/docs/gpu/gpu_testing.md index f662463474a420..807b42f61b3671 100644 --- a/docs/gpu/gpu_testing.md +++ b/docs/gpu/gpu_testing.md @@ -296,12 +296,12 @@ Example usage: --passthrough` If, for some reason, the local run code is unable to determine what the git -revision is, simply pass '--build-revision aabbccdd'. Note that `aabbccdd` must +revision is, simply pass `--git-revision aabbccdd`. Note that `aabbccdd` must be replaced with an actual Chromium src revision (typically whatever revision origin/master is currently synced to) in order for the tests to work. This can be done automatically using: ``run_gpu_integration_test.py pixel --no-skia-gold-failure --local-run ---passthrough --build-revision `git rev-parse origin/master` `` +--passthrough --git-revision `git rev-parse origin/master` `` ## Running Binaries from the Bots Locally diff --git a/testing/buildbot/chromium.android.json b/testing/buildbot/chromium.android.json index 82fe96e55f50b8..c953c2d64af9e1 100644 --- a/testing/buildbot/chromium.android.json +++ b/testing/buildbot/chromium.android.json @@ -21229,10 +21229,10 @@ "--shared-prefs-file=//chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json", "--replace-system-package=com.google.vr.vrcore,//third_party/gvr-android-sdk/test-apks/vr_services/vr_services_current.apk", "--additional-apk=//third_party/gvr-android-sdk/test-apks/vr_keyboard/vr_keyboard_current.apk", - "--git-revision", - "${got_revision}", "--gs-results-bucket=chromium-result-details", - "--recover-devices" + "--recover-devices", + "--git-revision", + "${got_revision}" ], "merge": { "args": [ @@ -21621,10 +21621,10 @@ "--shared-prefs-file=//chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json", "--replace-system-package=com.google.vr.vrcore,//third_party/gvr-android-sdk/test-apks/vr_services/vr_services_current.apk", "--additional-apk=//third_party/gvr-android-sdk/test-apks/vr_keyboard/vr_keyboard_current.apk", - "--git-revision", - "${got_revision}", "--gs-results-bucket=chromium-result-details", - "--recover-devices" + "--recover-devices", + "--git-revision", + "${got_revision}" ], "merge": { "args": [ @@ -37207,10 +37207,10 @@ "--shared-prefs-file=//chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json", "--replace-system-package=com.google.vr.vrcore,//third_party/gvr-android-sdk/test-apks/vr_services/vr_services_current.apk", "--additional-apk=//third_party/gvr-android-sdk/test-apks/vr_keyboard/vr_keyboard_current.apk", - "--git-revision", - "${got_revision}", "--gs-results-bucket=chromium-result-details", - "--recover-devices" + "--recover-devices", + "--git-revision", + "${got_revision}" ], "merge": { "args": [ diff --git a/testing/buildbot/chromium.ci.json b/testing/buildbot/chromium.ci.json index 61f93ee7514de6..e7b24275d448aa 100644 --- a/testing/buildbot/chromium.ci.json +++ b/testing/buildbot/chromium.ci.json @@ -6950,10 +6950,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -6962,11 +6962,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -6995,10 +6995,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -7007,11 +7007,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -7482,10 +7482,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -7494,11 +7494,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -7527,10 +7527,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -7539,11 +7539,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -7765,10 +7765,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -7777,11 +7777,11 @@ }, "name": "android_webview_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -7998,10 +7998,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -8010,11 +8010,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -8042,10 +8042,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -8054,11 +8054,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -8585,10 +8585,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -8597,11 +8597,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -8630,10 +8630,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -8642,11 +8642,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -9195,10 +9195,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -9207,11 +9207,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -9240,10 +9240,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -9252,11 +9252,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -9758,10 +9758,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -9770,11 +9770,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -9803,10 +9803,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -9815,11 +9815,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -9951,10 +9951,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -9963,11 +9963,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -10103,10 +10103,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=UseSkiaRenderer --use-gl=egl --enable-gpu-rasterization --force-gpu-rasterization --enable-oop-rasterization --disable-software-compositing-fallback --disable-headless-mode", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -10115,11 +10115,11 @@ }, "name": "egl_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -10202,10 +10202,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --use-vulkan=native --disable-vulkan-fallback-to-gl-for-testing --enable-features=UseSkiaRenderer,Vulkan --use-cmd-decoder=validating", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -10214,11 +10214,11 @@ }, "name": "vulkan_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -10558,10 +10558,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -10570,11 +10570,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -10602,10 +10602,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -10614,11 +10614,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -37763,10 +37763,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -37775,11 +37775,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -37806,10 +37806,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -37818,11 +37818,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -38243,10 +38243,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -38255,11 +38255,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -38286,10 +38286,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -38298,11 +38298,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -39018,10 +39018,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -39030,11 +39030,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -39062,10 +39062,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -39074,11 +39074,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -39597,10 +39597,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -39609,11 +39609,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -39640,10 +39640,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -39652,11 +39652,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -40214,10 +40214,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -40226,11 +40226,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -40258,10 +40258,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -40270,11 +40270,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -40855,10 +40855,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -40867,11 +40867,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -40898,10 +40898,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -40910,11 +40910,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -41372,10 +41372,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -41384,11 +41384,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -41487,10 +41487,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -41499,11 +41499,11 @@ }, "name": "skia_renderer_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -41574,10 +41574,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --use-vulkan=native --disable-vulkan-fallback-to-gl-for-testing --enable-features=UseSkiaRenderer,Vulkan --use-cmd-decoder=validating", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -41586,11 +41586,11 @@ }, "name": "vulkan_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -41807,10 +41807,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -41819,11 +41819,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -41922,10 +41922,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -41934,11 +41934,11 @@ }, "name": "skia_renderer_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -42009,10 +42009,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --use-vulkan=native --disable-vulkan-fallback-to-gl-for-testing --enable-features=UseSkiaRenderer,Vulkan --use-cmd-decoder=validating", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -42021,11 +42021,11 @@ }, "name": "vulkan_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -44847,10 +44847,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -44859,11 +44859,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -44890,10 +44890,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -44902,11 +44902,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -58694,10 +58694,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -58706,11 +58706,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -58736,10 +58736,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -58748,11 +58748,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -59200,10 +59200,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -59212,11 +59212,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -59242,10 +59242,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -59254,11 +59254,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -59884,10 +59884,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -59896,11 +59896,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -59932,10 +59932,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -59944,11 +59944,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -60560,10 +60560,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -60572,11 +60572,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -60602,10 +60602,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -60614,11 +60614,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -61210,10 +61210,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -61222,11 +61222,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -61254,10 +61254,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -61266,11 +61266,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -61752,10 +61752,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -61764,11 +61764,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -61796,10 +61796,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -61808,11 +61808,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -62289,10 +62289,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -62301,11 +62301,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -62333,10 +62333,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -62345,11 +62345,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -62985,10 +62985,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -62997,11 +62997,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -63029,10 +63029,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -63041,11 +63041,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -63745,10 +63745,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -63757,11 +63757,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -63789,10 +63789,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -63801,11 +63801,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -64244,10 +64244,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -64256,11 +64256,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -64286,10 +64286,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -64298,11 +64298,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -64700,10 +64700,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -64713,11 +64713,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -64743,10 +64743,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -64756,11 +64756,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -65143,10 +65143,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -65155,11 +65155,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -65187,10 +65187,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -65199,11 +65199,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -65594,10 +65594,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -65606,11 +65606,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -65638,10 +65638,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -65650,11 +65650,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -66080,10 +66080,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -66093,11 +66093,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -66125,10 +66125,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -66138,11 +66138,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -87279,10 +87279,10 @@ "--shared-prefs-file=//chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json", "--replace-system-package=com.google.vr.vrcore,//third_party/gvr-android-sdk/test-apks/vr_services/vr_services_current.apk", "--additional-apk=//third_party/gvr-android-sdk/test-apks/vr_keyboard/vr_keyboard_current.apk", - "--git-revision", - "${got_revision}", "--gs-results-bucket=chromium-result-details", - "--recover-devices" + "--recover-devices", + "--git-revision", + "${got_revision}" ], "merge": { "args": [ @@ -90027,10 +90027,10 @@ "--shared-prefs-file=//chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json", "--replace-system-package=com.google.vr.vrcore,//third_party/gvr-android-sdk/test-apks/vr_services/vr_services_current.apk", "--additional-apk=//third_party/gvr-android-sdk/test-apks/vr_keyboard/vr_keyboard_current.apk", - "--git-revision", - "${got_revision}", "--gs-results-bucket=chromium-result-details", - "--recover-devices" + "--recover-devices", + "--git-revision", + "${got_revision}" ], "merge": { "args": [ @@ -130992,10 +130992,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -131004,11 +131004,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -131035,10 +131035,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -131047,11 +131047,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -131805,10 +131805,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -131817,11 +131817,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -131849,10 +131849,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -131861,11 +131861,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -132680,10 +132680,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -132692,11 +132692,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -132724,10 +132724,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -132736,11 +132736,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -133483,10 +133483,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -133495,11 +133495,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -133526,10 +133526,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -133538,11 +133538,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -134418,10 +134418,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -134430,11 +134430,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -134462,10 +134462,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -134474,11 +134474,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -135336,10 +135336,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -135348,11 +135348,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -135380,10 +135380,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -135392,11 +135392,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -136385,10 +136385,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -136397,11 +136397,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -136477,10 +136477,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -136489,11 +136489,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -137118,10 +137118,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --disable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -137130,11 +137130,11 @@ }, "name": "gl_renderer_maps_pixel_tests", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -137161,10 +137161,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --disable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -137173,11 +137173,11 @@ }, "name": "gl_renderer_pixel_skia_gold_tests", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -138553,10 +138553,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -138565,11 +138565,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -138645,10 +138645,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -138657,11 +138657,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -139327,11 +139327,12 @@ }, { "args": [ - "--build-revision=${got_revision}", "--test-launcher-filter-file=../../testing/buildbot/filters/pixel_browser_tests.filter", "--browser-ui-tests-verify-pixels", "--test-launcher-retry-limit=0", - "--enable-pixel-output-in-tests" + "--enable-pixel-output-in-tests", + "--git-revision", + "${got_revision}" ], "experiment_percentage": 100, "merge": { @@ -139340,9 +139341,12 @@ }, "name": "pixel_browser_tests", "precommit_args": [ - "--issue=${patch_issue}", - "--patchset=${patch_set}", - "--jobid=${buildbucket_build_id}" + "--gerrit-issue", + "${patch_issue}", + "--gerrit-patchset", + "${patch_set}", + "--buildbucket-id", + "${buildbucket_build_id}" ], "swarming": { "can_use_on_swarming_builders": true, @@ -147825,10 +147829,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -147837,11 +147841,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -147868,10 +147872,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -147880,11 +147884,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -148416,10 +148420,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -148428,11 +148432,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -148468,10 +148472,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -148480,11 +148484,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -149099,10 +149103,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -149112,11 +149116,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -149152,10 +149156,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -149165,11 +149169,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -150041,10 +150045,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -150053,11 +150057,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -150085,10 +150089,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -150097,11 +150101,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -150720,10 +150724,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -150732,11 +150736,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -150764,10 +150768,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -150776,11 +150780,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -151618,10 +151622,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -151630,11 +151634,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -151671,10 +151675,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -151683,11 +151687,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -152689,10 +152693,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -152701,11 +152705,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -152742,10 +152746,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -152754,11 +152758,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -185191,10 +185195,10 @@ "--shared-prefs-file=//chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json", "--replace-system-package=com.google.vr.vrcore,//third_party/gvr-android-sdk/test-apks/vr_services/vr_services_current.apk", "--additional-apk=//third_party/gvr-android-sdk/test-apks/vr_keyboard/vr_keyboard_current.apk", - "--git-revision", - "${got_revision}", "--gs-results-bucket=chromium-result-details", - "--recover-devices" + "--recover-devices", + "--git-revision", + "${got_revision}" ], "merge": { "args": [ @@ -234165,11 +234169,12 @@ "gtest_tests": [ { "args": [ - "--build-revision=${got_revision}", "--test-launcher-filter-file=../../testing/buildbot/filters/pixel_browser_tests.filter", "--browser-ui-tests-verify-pixels", "--test-launcher-retry-limit=0", - "--enable-pixel-output-in-tests" + "--enable-pixel-output-in-tests", + "--git-revision", + "${got_revision}" ], "experiment_percentage": 100, "merge": { @@ -234178,9 +234183,12 @@ }, "name": "pixel_browser_tests", "precommit_args": [ - "--issue=${patch_issue}", - "--patchset=${patch_set}", - "--jobid=${buildbucket_build_id}" + "--gerrit-issue", + "${patch_issue}", + "--gerrit-patchset", + "${patch_set}", + "--buildbucket-id", + "${buildbucket_build_id}" ], "swarming": { "can_use_on_swarming_builders": true, diff --git a/testing/buildbot/chromium.fyi.json b/testing/buildbot/chromium.fyi.json index a340ecb1d4c99e..8e80d130160143 100644 --- a/testing/buildbot/chromium.fyi.json +++ b/testing/buildbot/chromium.fyi.json @@ -42163,11 +42163,12 @@ "gtest_tests": [ { "args": [ - "--build-revision=${got_revision}", "--test-launcher-filter-file=../../testing/buildbot/filters/pixel_browser_tests.filter", "--browser-ui-tests-verify-pixels", "--test-launcher-retry-limit=0", - "--enable-pixel-output-in-tests" + "--enable-pixel-output-in-tests", + "--git-revision", + "${got_revision}" ], "experiment_percentage": 100, "merge": { @@ -42176,9 +42177,12 @@ }, "name": "pixel_browser_tests", "precommit_args": [ - "--issue=${patch_issue}", - "--patchset=${patch_set}", - "--jobid=${buildbucket_build_id}" + "--gerrit-issue", + "${patch_issue}", + "--gerrit-patchset", + "${patch_set}", + "--buildbucket-id", + "${buildbucket_build_id}" ], "swarming": { "can_use_on_swarming_builders": true, diff --git a/testing/buildbot/chromium.gpu.fyi.json b/testing/buildbot/chromium.gpu.fyi.json index 0b9a954ff15600..a555b8928205a8 100644 --- a/testing/buildbot/chromium.gpu.fyi.json +++ b/testing/buildbot/chromium.gpu.fyi.json @@ -3804,10 +3804,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -3816,11 +3816,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -3849,10 +3849,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -3861,11 +3861,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -4336,10 +4336,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -4348,11 +4348,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -4381,10 +4381,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -4393,11 +4393,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -4619,10 +4619,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -4631,11 +4631,11 @@ }, "name": "android_webview_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -4852,10 +4852,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -4864,11 +4864,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -4896,10 +4896,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -4908,11 +4908,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -5439,10 +5439,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -5451,11 +5451,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -5484,10 +5484,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -5496,11 +5496,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -6049,10 +6049,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -6061,11 +6061,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -6094,10 +6094,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -6106,11 +6106,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -6612,10 +6612,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -6624,11 +6624,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -6657,10 +6657,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -6669,11 +6669,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -6805,10 +6805,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -6817,11 +6817,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -6957,10 +6957,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=UseSkiaRenderer --use-gl=egl --enable-gpu-rasterization --force-gpu-rasterization --enable-oop-rasterization --disable-software-compositing-fallback --disable-headless-mode", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -6969,11 +6969,11 @@ }, "name": "egl_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -7056,10 +7056,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --use-vulkan=native --disable-vulkan-fallback-to-gl-for-testing --enable-features=UseSkiaRenderer,Vulkan --use-cmd-decoder=validating", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -7068,11 +7068,11 @@ }, "name": "vulkan_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -7571,10 +7571,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -7583,11 +7583,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -7614,10 +7614,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -7626,11 +7626,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -8346,10 +8346,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -8358,11 +8358,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -8390,10 +8390,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -8402,11 +8402,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -8925,10 +8925,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -8937,11 +8937,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -8968,10 +8968,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -8980,11 +8980,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -9542,10 +9542,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -9554,11 +9554,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -9586,10 +9586,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -9598,11 +9598,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -10183,10 +10183,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -10195,11 +10195,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -10226,10 +10226,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -10238,11 +10238,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -10700,10 +10700,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -10712,11 +10712,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -10815,10 +10815,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -10827,11 +10827,11 @@ }, "name": "skia_renderer_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -10902,10 +10902,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --use-vulkan=native --disable-vulkan-fallback-to-gl-for-testing --enable-features=UseSkiaRenderer,Vulkan --use-cmd-decoder=validating", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -10914,11 +10914,11 @@ }, "name": "vulkan_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -11135,10 +11135,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -11147,11 +11147,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -11250,10 +11250,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --enable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -11262,11 +11262,11 @@ }, "name": "skia_renderer_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -11337,10 +11337,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --use-vulkan=native --disable-vulkan-fallback-to-gl-for-testing --enable-features=UseSkiaRenderer,Vulkan --use-cmd-decoder=validating", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -11349,11 +11349,11 @@ }, "name": "vulkan_pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -12055,10 +12055,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -12067,11 +12067,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -12097,10 +12097,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -12109,11 +12109,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -12739,10 +12739,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -12751,11 +12751,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -12787,10 +12787,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -12799,11 +12799,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -13415,10 +13415,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -13427,11 +13427,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -13457,10 +13457,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -13469,11 +13469,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -14065,10 +14065,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -14077,11 +14077,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -14109,10 +14109,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -14121,11 +14121,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -14607,10 +14607,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -14619,11 +14619,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -14651,10 +14651,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -14663,11 +14663,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -15144,10 +15144,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -15156,11 +15156,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -15188,10 +15188,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -15200,11 +15200,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -15840,10 +15840,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -15852,11 +15852,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -15884,10 +15884,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -15896,11 +15896,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -16600,10 +16600,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -16612,11 +16612,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -16644,10 +16644,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -16656,11 +16656,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -19740,10 +19740,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -19752,11 +19752,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -19783,10 +19783,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -19795,11 +19795,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -20553,10 +20553,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -20565,11 +20565,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -20597,10 +20597,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -20609,11 +20609,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -21428,10 +21428,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -21440,11 +21440,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -21472,10 +21472,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -21484,11 +21484,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -22231,10 +22231,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -22243,11 +22243,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -22274,10 +22274,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -22286,11 +22286,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -23166,10 +23166,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -23178,11 +23178,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -23210,10 +23210,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -23222,11 +23222,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -24084,10 +24084,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -24096,11 +24096,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -24128,10 +24128,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -24140,11 +24140,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -25133,10 +25133,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -25145,11 +25145,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -25225,10 +25225,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -25237,11 +25237,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -25866,10 +25866,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --disable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -25878,11 +25878,11 @@ }, "name": "gl_renderer_maps_pixel_tests", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -25909,10 +25909,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc --disable-features=UseSkiaRenderer", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -25921,11 +25921,11 @@ }, "name": "gl_renderer_pixel_skia_gold_tests", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -27301,10 +27301,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -27313,11 +27313,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -27393,10 +27393,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -27405,11 +27405,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -28420,10 +28420,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -28432,11 +28432,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -28464,10 +28464,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -28476,11 +28476,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -29099,10 +29099,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -29111,11 +29111,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -29143,10 +29143,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -29155,11 +29155,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -29997,10 +29997,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -30009,11 +30009,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -30050,10 +30050,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -30062,11 +30062,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -31068,10 +31068,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -31080,11 +31080,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -31121,10 +31121,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -31133,11 +31133,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, diff --git a/testing/buildbot/chromium.gpu.json b/testing/buildbot/chromium.gpu.json index 474c2ee482b061..b75c47460c3239 100644 --- a/testing/buildbot/chromium.gpu.json +++ b/testing/buildbot/chromium.gpu.json @@ -171,10 +171,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -183,11 +183,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -215,10 +215,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -227,11 +227,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -652,10 +652,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -664,11 +664,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -695,10 +695,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -707,11 +707,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1095,10 +1095,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1107,11 +1107,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1138,10 +1138,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1150,11 +1150,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1497,10 +1497,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1509,11 +1509,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1539,10 +1539,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1551,11 +1551,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1920,10 +1920,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1932,11 +1932,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1962,10 +1962,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1974,11 +1974,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -2376,10 +2376,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -2389,11 +2389,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -2419,10 +2419,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -2432,11 +2432,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -2819,10 +2819,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -2831,11 +2831,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -2863,10 +2863,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -2875,11 +2875,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -3270,10 +3270,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -3282,11 +3282,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -3314,10 +3314,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -3326,11 +3326,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -3756,10 +3756,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -3769,11 +3769,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -3801,10 +3801,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -3814,11 +3814,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -4285,10 +4285,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -4297,11 +4297,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -4328,10 +4328,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -4340,11 +4340,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -4876,10 +4876,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -4888,11 +4888,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -4928,10 +4928,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -4940,11 +4940,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -5559,10 +5559,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -5572,11 +5572,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -5612,10 +5612,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_revision}" ], "isolate_coverage_data": true, "isolate_name": "telemetry_gpu_integration_test", @@ -5625,11 +5625,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, diff --git a/testing/buildbot/chromium.win.json b/testing/buildbot/chromium.win.json index cb4e2aca415706..ff42b268406dc0 100644 --- a/testing/buildbot/chromium.win.json +++ b/testing/buildbot/chromium.win.json @@ -1739,11 +1739,12 @@ }, { "args": [ - "--build-revision=${got_revision}", "--test-launcher-filter-file=../../testing/buildbot/filters/pixel_browser_tests.filter", "--browser-ui-tests-verify-pixels", "--test-launcher-retry-limit=0", - "--enable-pixel-output-in-tests" + "--enable-pixel-output-in-tests", + "--git-revision", + "${got_revision}" ], "experiment_percentage": 100, "merge": { @@ -1752,9 +1753,12 @@ }, "name": "pixel_browser_tests", "precommit_args": [ - "--issue=${patch_issue}", - "--patchset=${patch_set}", - "--jobid=${buildbucket_build_id}" + "--gerrit-issue", + "${patch_issue}", + "--gerrit-patchset", + "${patch_set}", + "--buildbucket-id", + "${buildbucket_build_id}" ], "swarming": { "can_use_on_swarming_builders": true, diff --git a/testing/buildbot/client.v8.fyi.json b/testing/buildbot/client.v8.fyi.json index 440ce56dabfccb..1eb9c9529f97f0 100644 --- a/testing/buildbot/client.v8.fyi.json +++ b/testing/buildbot/client.v8.fyi.json @@ -132,10 +132,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -144,11 +144,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -175,10 +175,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -187,11 +187,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -463,10 +463,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -475,11 +475,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -505,10 +505,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -517,11 +517,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -789,10 +789,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -801,11 +801,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -831,10 +831,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -843,11 +843,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1111,10 +1111,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1123,11 +1123,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1152,10 +1152,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1164,11 +1164,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1779,10 +1779,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1791,11 +1791,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1821,10 +1821,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1833,11 +1833,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, diff --git a/testing/buildbot/mixins.pyl b/testing/buildbot/mixins.pyl index ff5db41316a13e..c8475edbe282f5 100644 --- a/testing/buildbot/mixins.pyl +++ b/testing/buildbot/mixins.pyl @@ -630,6 +630,18 @@ }, }, }, + 'skia_gold_test': { + '$mixin_append': { + 'args': [ + '--git-revision', '${got_revision}', + ], + 'precommit_args': [ + '--gerrit-issue', '${patch_issue}', + '--gerrit-patchset', '${patch_set}', + '--buildbucket-id', '${buildbucket_build_id}', + ], + } + }, 'swarming_containment_auto': { 'swarming': { 'containment_type': 'AUTO', diff --git a/testing/buildbot/test_suite_exceptions.pyl b/testing/buildbot/test_suite_exceptions.pyl index 5b654b03f91c54..aad9f20783348c 100644 --- a/testing/buildbot/test_suite_exceptions.pyl +++ b/testing/buildbot/test_suite_exceptions.pyl @@ -1280,27 +1280,27 @@ # use ${got_cr_revision}, which is only set on the V8 bots. 'Android V8 FYI Release (Nexus 5X)': { 'args': { - '--build-revision': '${got_cr_revision}', + '--git-revision': '${got_cr_revision}', }, }, 'Linux V8 FYI Release (NVIDIA)': { 'args': { - '--build-revision': '${got_cr_revision}', + '--git-revision': '${got_cr_revision}', }, }, 'Linux V8 FYI Release - pointer compression (NVIDIA)': { 'args': { - '--build-revision': '${got_cr_revision}', + '--git-revision': '${got_cr_revision}', }, }, 'Mac V8 FYI Release (Intel)': { 'args': { - '--build-revision': '${got_cr_revision}', + '--git-revision': '${got_cr_revision}', }, }, 'Win V8 FYI Release (NVIDIA)': { 'args': { - '--build-revision': '${got_cr_revision}', + '--git-revision': '${got_cr_revision}', }, }, }, @@ -1876,27 +1876,27 @@ # use ${got_cr_revision}, which is only set on the V8 bots. 'Android V8 FYI Release (Nexus 5X)': { 'args': { - '--build-revision': '${got_cr_revision}', + '--git-revision': '${got_cr_revision}', }, }, 'Linux V8 FYI Release (NVIDIA)': { 'args': { - '--build-revision': '${got_cr_revision}', + '--git-revision': '${got_cr_revision}', }, }, 'Linux V8 FYI Release - pointer compression (NVIDIA)': { 'args': { - '--build-revision': '${got_cr_revision}', + '--git-revision': '${got_cr_revision}', }, }, 'Mac V8 FYI Release (Intel)': { 'args': { - '--build-revision': '${got_cr_revision}', + '--git-revision': '${got_cr_revision}', }, }, 'Win V8 FYI Release (NVIDIA)': { 'args': { - '--build-revision': '${got_cr_revision}', + '--git-revision': '${got_cr_revision}', }, }, }, diff --git a/testing/buildbot/test_suites.pyl b/testing/buildbot/test_suites.pyl index 2e424658f86f33..2e6f0d8553c33a 100644 --- a/testing/buildbot/test_suites.pyl +++ b/testing/buildbot/test_suites.pyl @@ -40,14 +40,11 @@ '--shared-prefs-file=//chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json', '--replace-system-package=com.google.vr.vrcore,//third_party/gvr-android-sdk/test-apks/vr_services/vr_services_current.apk', '--additional-apk=//third_party/gvr-android-sdk/test-apks/vr_keyboard/vr_keyboard_current.apk', - '--git-revision', '${got_revision}', ], - 'precommit_args': [ - '--gerrit-issue', '${patch_issue}', - '--gerrit-patchset', '${patch_set}', - '--buildbucket-id', '${buildbucket_build_id}', + 'mixins': [ + 'chrome-gold-service-account', + 'skia_gold_test', ], - 'mixins': ['chrome-gold-service-account'], 'swarming': { 'shards': 4, }, @@ -193,23 +190,13 @@ 'name': 'android_webview_pixel_skia_gold_test', 'args': [ '--dont-restore-color-profile-after-test', - '--build-revision', - '${got_revision}', '--test-machine-name', '${buildername}', ], - 'precommit_args': [ - # Gerrit issue ID - '--review-patch-issue', - '${patch_issue}', - # Patch set number - '--review-patch-set', - '${patch_set}', - # Buildbucket ID - '--buildbucket-build-id', - '${buildbucket_build_id}', - ], - 'mixins': ['chrome-gpu-gold-service-account'], + 'mixins': [ + 'chrome-gpu-gold-service-account', + 'skia_gold_test', + ], 'telemetry_test_name': 'pixel', }, }, @@ -2193,47 +2180,27 @@ 'name': 'gl_renderer_maps_pixel_tests', 'args': [ '--dont-restore-color-profile-after-test', - '--build-revision', - '${got_revision}', '--test-machine-name', '${buildername}', '--extra-browser-args=--disable-features=UseSkiaRenderer', ], - 'precommit_args': [ - # Gerrit issue ID - '--review-patch-issue', - '${patch_issue}', - # Patch set number - '--review-patch-set', - '${patch_set}', - # Buildbucket ID - '--buildbucket-build-id', - '${buildbucket_build_id}', + 'mixins': [ + 'chrome-gpu-gold-service-account', + 'skia_gold_test', ], - 'mixins': ['chrome-gpu-gold-service-account'], }, 'pixel': { 'name': 'gl_renderer_pixel_skia_gold_tests', 'args': [ '--dont-restore-color-profile-after-test', - '--build-revision', - '${got_revision}', '--test-machine-name', '${buildername}', '--extra-browser-args=--disable-features=UseSkiaRenderer', ], - 'precommit_args': [ - # Gerrit issue ID - '--review-patch-issue', - '${patch_issue}', - # Patch set number - '--review-patch-set', - '${patch_set}', - # Buildbucket ID - '--buildbucket-build-id', - '${buildbucket_build_id}', + 'mixins': [ + 'chrome-gpu-gold-service-account', + 'skia_gold_test', ], - 'mixins': ['chrome-gpu-gold-service-account'], }, 'screenshot_sync': { 'name': 'gl_renderer_screenshot_sync_tests', @@ -2316,24 +2283,14 @@ 'name': 'egl_pixel_skia_gold_test', 'args': [ '--dont-restore-color-profile-after-test', - '--build-revision', - '${got_revision}', '--test-machine-name', '${buildername}', '--extra-browser-args=--enable-features=UseSkiaRenderer --use-gl=egl --enable-gpu-rasterization --force-gpu-rasterization --enable-oop-rasterization --disable-software-compositing-fallback --disable-headless-mode', ], - 'precommit_args': [ - # Gerrit issue ID - '--review-patch-issue', - '${patch_issue}', - # Patch set number - '--review-patch-set', - '${patch_set}', - # Buildbucket ID - '--buildbucket-build-id', - '${buildbucket_build_id}', - ], - 'mixins': ['chrome-gpu-gold-service-account'], + 'mixins': [ + 'chrome-gpu-gold-service-account', + 'skia_gold_test', + ], 'telemetry_test_name': 'pixel', }, }, @@ -2364,24 +2321,14 @@ 'name': 'maps_pixel_test', 'args': [ '--dont-restore-color-profile-after-test', - '--build-revision', - '${got_revision}', '--test-machine-name', '${buildername}', '--extra-browser-args=--enable-features=UseSkiaRenderer', ], - 'precommit_args': [ - # Gerrit issue ID - '--review-patch-issue', - '${patch_issue}', - # Patch set number - '--review-patch-set', - '${patch_set}', - # Buildbucket ID - '--buildbucket-build-id', - '${buildbucket_build_id}', + 'mixins': [ + 'chrome-gpu-gold-service-account', + 'skia_gold_test', ], - 'mixins': ['chrome-gpu-gold-service-account'], }, 'screenshot_sync': { 'args': [ @@ -2393,24 +2340,14 @@ 'name': 'skia_renderer_pixel_skia_gold_test', 'args': [ '--dont-restore-color-profile-after-test', - '--build-revision', - '${got_revision}', '--test-machine-name', '${buildername}', '--extra-browser-args=--enable-features=UseSkiaRenderer', ], - 'precommit_args': [ - # Gerrit issue ID - '--review-patch-issue', - '${patch_issue}', - # Patch set number - '--review-patch-set', - '${patch_set}', - # Buildbucket ID - '--buildbucket-build-id', - '${buildbucket_build_id}', - ], - 'mixins': ['chrome-gpu-gold-service-account'], + 'mixins': [ + 'chrome-gpu-gold-service-account', + 'skia_gold_test', + ], 'telemetry_test_name': 'pixel', }, }, @@ -2438,24 +2375,14 @@ 'name': 'vulkan_pixel_skia_gold_test', 'args': [ '--dont-restore-color-profile-after-test', - '--build-revision', - '${got_revision}', '--test-machine-name', '${buildername}', '--extra-browser-args=--use-vulkan=native --disable-vulkan-fallback-to-gl-for-testing --enable-features=UseSkiaRenderer,Vulkan --use-cmd-decoder=validating', ], - 'precommit_args': [ - # Gerrit issue ID - '--review-patch-issue', - '${patch_issue}', - # Patch set number - '--review-patch-set', - '${patch_set}', - # Buildbucket ID - '--buildbucket-build-id', - '${buildbucket_build_id}', - ], - 'mixins': ['chrome-gpu-gold-service-account'], + 'mixins': [ + 'chrome-gpu-gold-service-account', + 'skia_gold_test', + ], 'telemetry_test_name': 'pixel', }, }, @@ -2476,45 +2403,25 @@ 'name': 'maps_pixel_test', 'args': [ '--dont-restore-color-profile-after-test', - '--build-revision', - '${got_revision}', '--test-machine-name', '${buildername}', ], - 'precommit_args': [ - # Gerrit issue ID - '--review-patch-issue', - '${patch_issue}', - # Patch set number - '--review-patch-set', - '${patch_set}', - # Buildbucket ID - '--buildbucket-build-id', - '${buildbucket_build_id}', + 'mixins': [ + 'chrome-gpu-gold-service-account', + 'skia_gold_test', ], - 'mixins': ['chrome-gpu-gold-service-account'], }, 'pixel_skia': { 'name': 'pixel_skia_gold_test', 'args': [ '--dont-restore-color-profile-after-test', - '--build-revision', - '${got_revision}', '--test-machine-name', '${buildername}', ], - 'precommit_args': [ - # Gerrit issue ID - '--review-patch-issue', - '${patch_issue}', - # Patch set number - '--review-patch-set', - '${patch_set}', - # Buildbucket ID - '--buildbucket-build-id', - '${buildbucket_build_id}', - ], - 'mixins': ['chrome-gpu-gold-service-account'], + 'mixins': [ + 'chrome-gpu-gold-service-account', + 'skia_gold_test', + ], 'telemetry_test_name': 'pixel', }, 'screenshot_sync': { @@ -3259,7 +3166,6 @@ 'pixel_browser_tests': { 'name': 'pixel_browser_tests', 'args': [ - '--build-revision=${got_revision}', '--test-launcher-filter-file=../../testing/buildbot/filters/pixel_browser_tests.filter', '--browser-ui-tests-verify-pixels', # Do not allow retry or it will break the bulk approval process. @@ -3269,14 +3175,12 @@ '--test-launcher-retry-limit=0', '--enable-pixel-output-in-tests', ], - 'precommit_args': [ - '--issue=${patch_issue}', - '--patchset=${patch_set}', - '--jobid=${buildbucket_build_id}', - ], 'experiment_percentage': 100, 'test': 'browser_tests', - 'mixins': ['chrome-gold-service-account'], + 'mixins': [ + 'chrome-gold-service-account', + 'skia_gold_test', + ], }, }, diff --git a/testing/buildbot/v8.ci.json b/testing/buildbot/v8.ci.json index 03c1b98b620a7b..dfaae979b92fea 100644 --- a/testing/buildbot/v8.ci.json +++ b/testing/buildbot/v8.ci.json @@ -132,10 +132,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -144,11 +144,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -175,10 +175,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -187,11 +187,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1609,10 +1609,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1621,11 +1621,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1651,10 +1651,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1663,11 +1663,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1935,10 +1935,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1947,11 +1947,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -1977,10 +1977,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -1989,11 +1989,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -2257,10 +2257,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -2269,11 +2269,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -2298,10 +2298,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -2310,11 +2310,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -2925,10 +2925,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -2937,11 +2937,11 @@ }, "name": "maps_pixel_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, @@ -2967,10 +2967,10 @@ "-v", "--extra-browser-args=--enable-logging=stderr --js-flags=--expose-gc", "--dont-restore-color-profile-after-test", - "--build-revision", - "${got_cr_revision}", "--test-machine-name", - "${buildername}" + "${buildername}", + "--git-revision", + "${got_cr_revision}" ], "isolate_name": "telemetry_gpu_integration_test", "merge": { @@ -2979,11 +2979,11 @@ }, "name": "pixel_skia_gold_test", "precommit_args": [ - "--review-patch-issue", + "--gerrit-issue", "${patch_issue}", - "--review-patch-set", + "--gerrit-patchset", "${patch_set}", - "--buildbucket-build-id", + "--buildbucket-id", "${buildbucket_build_id}" ], "should_retry_with_patch": false, diff --git a/ui/base/test/skia_gold_pixel_diff.cc b/ui/base/test/skia_gold_pixel_diff.cc index 16ced3682ea528..cbd8bd2e833e38 100644 --- a/ui/base/test/skia_gold_pixel_diff.cc +++ b/ui/base/test/skia_gold_pixel_diff.cc @@ -37,12 +37,12 @@ const char* kSkiaGoldCtl = "tools/skia_goldctl/mac/goldctl"; const char* kSkiaGoldCtl = "tools/skia_goldctl/linux/goldctl"; #endif -const char* kBuildRevisionKey = "build-revision"; +const char* kBuildRevisionKey = "git-revision"; // The switch keys for tryjob. -const char* kIssueKey = "issue"; -const char* kPatchSetKey = "patchset"; -const char* kJobIdKey = "jobid"; +const char* kIssueKey = "gerrit-issue"; +const char* kPatchSetKey = "gerrit-patchset"; +const char* kJobIdKey = "buildbucket-id"; const char* kNoLuciAuth = "no-luci-auth"; const char* kBypassSkiaGoldFunctionality = "bypass-skia-gold-functionality"; diff --git a/ui/base/test/skia_gold_pixel_diff_unittest.cc b/ui/base/test/skia_gold_pixel_diff_unittest.cc index 105c9eae475b06..a8abdf09c24950 100644 --- a/ui/base/test/skia_gold_pixel_diff_unittest.cc +++ b/ui/base/test/skia_gold_pixel_diff_unittest.cc @@ -29,7 +29,7 @@ class SkiaGoldPixelDiffTest : public ::testing::Test { public: SkiaGoldPixelDiffTest() { auto* cmd_line = base::CommandLine::ForCurrentProcess(); - cmd_line->AppendSwitchASCII("build-revision", "test"); + cmd_line->AppendSwitchASCII("git-revision", "test"); } ~SkiaGoldPixelDiffTest() override {}