From 53115e1a30cd91ab29fa55220d3e9a4bea6ed05f Mon Sep 17 00:00:00 2001 From: "Rakib M. Hasan" Date: Tue, 30 Jun 2020 18:22:29 +0000 Subject: [PATCH] weblayer: Disable ExternalNavigationTests subtests for M83 skew testing Disable the following for M83 client skew tests org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentWithNoRedirectBlocked Disable the following for M83 implementtion skew tests org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentWithNoRedirectLaunched TBR=jam@chromium.org Bug: 1096570 Change-Id: I23fa50f5ac46da88315468e904893ad3fc99329f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274465 Commit-Queue: Rakib Hasan Reviewed-by: Erik Staab Cr-Commit-Position: refs/heads/master@{#784054} --- .../android/javatests/skew/expectations.txt | 29 ++++++++++--------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/weblayer/browser/android/javatests/skew/expectations.txt b/weblayer/browser/android/javatests/skew/expectations.txt index 365f067e95eff6..fed8bbdf35fab0 100644 --- a/weblayer/browser/android/javatests/skew/expectations.txt +++ b/weblayer/browser/android/javatests/skew/expectations.txt @@ -22,25 +22,28 @@ [ impl_lte_83 ] org.chromium.weblayer.test.TabTest#testBeforeUnloadNoHandler [ Skip ] [ impl_lte_83 ] org.chromium.weblayer.test.TabTest#testBeforeUnloadNoInteraction [ Skip ] -# Replace was removed in https://crrev.com/c/2150968, see https://crbug.com/1070851. -[ impl_lte_83 ] org.chromium.weblayer.test.NavigationTest#testReplace [ Skip ] +# Replace was removed in https://crrev.com/c/2150968. +crbug.com/1070851 [ impl_lte_83 ] org.chromium.weblayer.test.NavigationTest#testReplace [ Skip ] -# Fixed in https://crrev.com/c/2180022, see https://crbug.com/1077243. -[ impl_lte_83 ] org.chromium.weblayer.test.FullscreenCallbackTest#testExitFullscreenWhenTabDestroyed [ Skip ] +# Fixed in https://crrev.com/c/2180022. +crbug.com/1077243 [ impl_lte_83 ] org.chromium.weblayer.test.FullscreenCallbackTest#testExitFullscreenWhenTabDestroyed [ Skip ] -# https://crbug.com/1079491. -[ impl_lte_83 ] org.chromium.weblayer.test.NavigationTest#testSetUserAgentString [ Skip ] +crbug.com/1079491 [ impl_lte_83 ] org.chromium.weblayer.test.NavigationTest#testSetUserAgentString [ Skip ] + +crbug.com/1096570 [ impl_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentWithNoRedirectLaunched [ Skip ] # ------------------------------------- # Tests against older WebLayer clients. # ------------------------------------- -# Intentionally changed in M84, https://crrev.com/c/2130790. See https://crbug.com/1078973. -[ client_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentLaunchedViaOnLoad [ Skip ] -[ client_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testNonHandledExternalIntentWithFallbackUrlThatLaunchesIntentAfterRedirectLaunchesFallbackIntent [ Skip ] +# Intentionally changed in M84, https://crrev.com/c/2130790. +crbug.com/1078973 [ client_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentLaunchedViaOnLoad [ Skip ] +crbug.com/1078973 [ client_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testNonHandledExternalIntentWithFallbackUrlThatLaunchesIntentAfterRedirectLaunchesFallbackIntent [ Skip ] + +# Replace was removed in https://crrev.com/c/2150968. +crbug.com/1070851 [ client_lte_83 ] org.chromium.weblayer.test.NavigationTest#testReplace [ Skip ] -# Replace was removed in https://crrev.com/c/2150968, see https://crbug.com/1070851. -[ client_lte_83 ] org.chromium.weblayer.test.NavigationTest#testReplace [ Skip ] +# Test was made private. +crbug.com/1087451 [ client_lte_84 ] org.chromium.weblayer.test.TopControlsTest#testBasic [ Skip ] -# Test was made private, https://crbug.com/1087451. -[ client_lte_84 ] org.chromium.weblayer.test.TopControlsTest#testBasic [ Skip ] +crbug.com/1096570 [ client_lte_83 ] org.chromium.weblayer.test.ExternalNavigationTest#testExternalIntentWithNoRedirectBlocked [ Skip ]