Skip to content

Commit

Permalink
Don't check blink DEPS files for target LGTM
Browse files Browse the repository at this point in the history
They're a mix of third_party/WebKit and src relative path names. Skipping them
is still better than everybody using NOPRESUBMIT.

BUG=545323
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1646873002

Cr-Commit-Position: refs/heads/master@{#372289}
  • Loading branch information
jeisinger authored and Commit bot committed Jan 29, 2016
1 parent 173daa3 commit 53efcdd
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion PRESUBMIT.py
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,11 @@ def _CheckAddedDepsHaveTargetApprovals(input_api, output_api):
introduced. This check verifies that this happens.
"""
changed_lines = set()
for f in input_api.AffectedFiles():

file_filter = lambda f: not input_api.re.match(
r"^third_party[\\\/]WebKit[\\\/].*", f.LocalPath())
for f in input_api.AffectedFiles(include_deletes=False,
file_filter=file_filter):
filename = input_api.os_path.basename(f.LocalPath())
if filename == 'DEPS':
changed_lines |= set(line.strip()
Expand Down

0 comments on commit 53efcdd

Please sign in to comment.