Skip to content

Commit

Permalink
Revert of Run compositing/ and paint/ for disable-spinvalidation (pat…
Browse files Browse the repository at this point in the history
…chset chromium#3 id:40001 of https://codereview.chromium.org/2750943002/ )

Reason for revert:
Caused failure on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/9279

20:01:44.340 2964 [657/51934] virtual/disable-spinvalidation/compositing/perpendicular-layer-sorting.html failed unexpectedly (image diff)
20:01:44.334 1652 worker/3 virtual/disable-spinvalidation/compositing/perpendicular-layer-sorting.html failed:
20:01:44.334 1652 worker/3  image diff

Original issue's description:
> Run compositing/ and paint/ for disable-spinvalidation
>
> This is to increase test coverage for disable-spinvalidation to reduce
> risk of breaking it.
>
> Total number of virtual/disable-spinvalidation tests is 1676
> (was 913 previously).
>
> Review-Url: https://codereview.chromium.org/2750943002
> Cr-Commit-Position: refs/heads/master@{#456939}
> Committed: https://chromium.googlesource.com/chromium/src/+/becaabeceb9fbb249e4c7a72b85f4f20cd826f95

TBR=chrishtr@chromium.org,pdr@chromium.org,wangxianzhu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2756433002
Cr-Commit-Position: refs/heads/master@{#457052}
  • Loading branch information
grunell authored and Commit bot committed Mar 15, 2017
1 parent 3bd2d6c commit 571b633
Show file tree
Hide file tree
Showing 24 changed files with 4 additions and 461 deletions.
1 change: 0 additions & 1 deletion third_party/WebKit/LayoutTests/LeakExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ crbug.com/364398 virtual/mojo-loading/http/tests/security/xssAuditor/viewsource-

# FIXME: The below tests fails when the leak detector is disabled.
crbug.com/366029 compositing/fixed-body-background-positioned.html [ Failure Pass ]
crbug.com/366029 virtual/disable-spinvalidation/compositing/fixed-body-background-positioned.html [ Failure Pass ]

# FIXME: The below tests crashes when the leak detector is run on debug builds
crbug.com/366043 [ Debug ] fast/history/history-traversal-is-asynchronous.html [ Crash ]
Expand Down
6 changes: 0 additions & 6 deletions third_party/WebKit/LayoutTests/SlowTests
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ crbug.com/24182 editing/selection/modify_move/move-by-word-visually-mac.html [ S
crbug.com/24182 editing/selection/modify_move/move-by-word-visually-multi-line.html [ Slow ]
crbug.com/24182 compositing/culling/filter-occlusion-blur-large.html [ Slow ]
crbug.com/24182 compositing/video-frame-size-change.html [ Slow ]
crbug.com/24182 virtual/disable-spinvalidation/compositing/culling/filter-occlusion-blur-large.html [ Slow ]
crbug.com/24182 virtual/disable-spinvalidation/compositing/video-frame-size-change.html [ Slow ]
crbug.com/24182 css3/filters/effect-reference-hidpi-hw.html [ Slow ]
crbug.com/24182 css3/filters/filter-change-repaint-composited.html [ Slow ]
crbug.com/24182 editing/selection/caret-at-bidi-boundary.html [ Slow ]
Expand Down Expand Up @@ -304,7 +302,6 @@ crbug.com/528419 [ Linux ] inspector/elements/shadow/shadow-host-display-modes.h
crbug.com/528419 inspector/elements/styles-2/pseudo-elements.html [ Slow ]

crbug.com/529345 [ Win10 ] paint/masks/fieldset-mask.html [ Slow ]
crbug.com/529345 [ Win10 ] virtual/disable-spinvalidation/paint/masks/fieldset-mask.html [ Slow ]
crbug.com/552556 [ Win Linux ] virtual/threaded/fast/scroll-behavior/overflow-scroll-root-frame-animates.html [ Slow ]
crbug.com/552556 [ Win Linux ] virtual/threaded/fast/scroll-behavior/overflow-scroll-animates.html [ Slow ]
crbug.com/570656 [ Mac ] fast/writing-mode/Kusa-Makura-background-canvas.html [ Slow ]
Expand Down Expand Up @@ -357,7 +354,6 @@ crbug.com/614910 virtual/gpu-rasterization/images/pixel-crack-image-background-w
crbug.com/614910 virtual/gpu-rasterization/images/color-profile-filter.html [ Slow ]

crbug.com/623798 paint/images/animated-gif-last-frame-crash.html [ Slow ]
crbug.com/623798 virtual/disable-spinvalidation/paint/images/animated-gif-last-frame-crash.html [ Slow ]

crbug.com/606649 fast/dom/gc-dom-tree-lifetime.html [ Slow ]

Expand All @@ -371,8 +367,6 @@ crbug.com/647192 [ Win Debug ] webexposed/global-interface-listing.html [ Slow ]
# bots running tests on real hardware or maybe when using SwiftShader.
crbug.com/646528 compositing/lots-of-img-layers.html [ Slow ]
crbug.com/646528 compositing/lots-of-img-layers-with-opacity.html [ Slow ]
crbug.com/646528 virtual/disable-spinvalidation/compositing/lots-of-img-layers.html [ Slow ]
crbug.com/646528 virtual/disable-spinvalidation/compositing/lots-of-img-layers-with-opacity.html [ Slow ]

# IDB Observer tests require multiple browsing contexts/workers interacting with
# IndexedDB, which can be slow.
Expand Down
17 changes: 1 addition & 16 deletions third_party/WebKit/LayoutTests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ crbug.com/619427 [ Mac Linux ] virtual/spv2/fast/overflow/overflow-height-float-
# --- End SPV2 Tests ---

crbug.com/309675 compositing/gestures/gesture-tapHighlight-simple-longPress.html [ Failure ]
crbug.com/309675 virtual/disable-spinvalidation/compositing/gestures/gesture-tapHighlight-simple-longPress.html [ Failure ]

# TODO(schenney) For some reason these tests are failing to get correct baselines with rebaseline-cl.
# They may be flaky or it may be something else. Investigate and rebaseline manually or with the bot.
Expand All @@ -70,7 +69,6 @@ crbug.com/349985 [ Win ] fast/table/backgr_simple-table-column-group.html [ Fail
crbug.com/349985 [ Win ] fast/table/backgr_position-table-column-group-collapsed-border.html [ Failure ]

crbug.com/504613 crbug.com/524248 paint/images/image-backgrounds-not-antialiased.html [ Skip ]
crbug.com/504613 crbug.com/524248 virtual/disable-spinvalidation/paint/images/image-backgrounds-not-antialiased.html [ Skip ]

crbug.com/517449 [ Android ] images/optimize-contrast-image.html [ Failure ]

Expand All @@ -83,7 +81,6 @@ crbug.com/531286 virtual/gpu/fast/canvas/yuv-video-on-accelerated-canvas.html [
crbug.com/549742 [ Linux Mac Win ] virtual/gpu/fast/canvas/canvas-drawImage-video-imageSmoothingEnabled.html [ Failure ]

crbug.com/591500 [ Win10 ] compositing/squashing/squashing-print.html [ Failure ]
crbug.com/591500 [ Win10 ] virtual/disable-spinvalidation/compositing/squashing/squashing-print.html [ Failure ]

crbug.com/602110 hittesting/border-hittest-with-image-fallback.html [ Failure ]

Expand Down Expand Up @@ -134,7 +131,6 @@ crbug.com/683339 paint/invalidation/paged-with-overflowing-block-rl.html [ Failu
crbug.com/683339 virtual/disable-spinvalidation/paint/invalidation/paged-with-overflowing-block-rl.html [ Failure ]

crbug.com/646010 paint/selection/text-selection-newline-rtl-double-linebreak.html [ Failure ]
crbug.com/646010 virtual/disable-spinvalidation/paint/selection/text-selection-newline-rtl-double-linebreak.html [ Failure ]
crbug.com/646015 paint/invalidation/hover-invalidation-table.html [ Failure ]
crbug.com/646015 virtual/disable-spinvalidation/paint/invalidation/hover-invalidation-table.html [ Failure ]
crbug.com/646016 paint/invalidation/selected-replaced.html [ Failure ]
Expand All @@ -155,11 +151,9 @@ crbug.com/671048 virtual/color_space/fast/canvas/color-space/display_linear-rgb.

# Added 2016-12-14
crbug.com/674396 [ Win ] compositing/reflections/nested-reflection-transition.html [ Pass Failure ]
crbug.com/674396 [ Win ] virtual/disable-spinvalidation/compositing/reflections/nested-reflection-transition.html [ Pass Failure ]

# Added 2016-12-15
crbug.com/674468 [ Trusty ] compositing/reflections/nested-reflection-transition.html [ Pass Failure ]
crbug.com/674468 [ Trusty ] virtual/disable-spinvalidation/compositing/reflections/nested-reflection-transition.html [ Pass Failure ]

# Added 2016-12-16
crbug.com/674858 [ Linux ] virtual/threaded/printing/offscreencanvas-2d-printing.html [ Pass Failure Crash ]
Expand All @@ -168,8 +162,6 @@ crbug.com/674858 [ Linux ] virtual/threaded/printing/offscreencanvas-webgl-print
# Added 2017-02-20
crbug.com/693510 compositing/reflections/nested-reflection-anchor-point.html [ Failure Pass ]
crbug.com/693510 compositing/reflections/nested-reflection-animated.html [ Failure Pass ]
crbug.com/693510 virtual/disable-spinvalidation/compositing/reflections/nested-reflection-anchor-point.html [ Failure Pass ]
crbug.com/693510 virtual/disable-spinvalidation/compositing/reflections/nested-reflection-animated.html [ Failure Pass ]

crbug.com/667045 paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html [ Crash ]
crbug.com/667045 virtual/disable-spinvalidation/paint/invalidation/table/composited-cell-collapsed-border-add-anonymous.html [ Crash ]
Expand Down Expand Up @@ -1809,7 +1801,6 @@ crbug.com/610464 [ Linux Win7 Debug ] inspector/components/throttler.html [ Fail
crbug.com/487344 paint/invalidation/video-paint-invalidation.html [ Failure ]
crbug.com/487344 virtual/disable-spinvalidation/paint/invalidation/video-paint-invalidation.html [ Failure ]
crbug.com/487344 [ Win ] compositing/video/video-controls-layer-creation.html [ Pass Failure ]
crbug.com/487344 [ Win ] virtual/disable-spinvalidation/compositing/video/video-controls-layer-creation.html [ Pass Failure ]
crbug.com/487344 fast/hidpi/video-controls-in-hidpi.html [ Failure ]
crbug.com/487344 fast/layers/video-layer.html [ Failure ]
crbug.com/487344 media/audio-controls-rendering.html [ Failure ]
Expand Down Expand Up @@ -2628,20 +2619,14 @@ crbug.com/697971 [ Mac10.12 ] svg/transforms/svg-css-transforms.xhtml [ Failure
crbug.com/697971 [ Mac10.12 ] svg/zoom/page/zoom-background-images.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] transforms/2d/zoom-menulist.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] transforms/svg-vs-css.xhtml [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/compositing/overflow/border-radius-styles-with-composited-child.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/compositing/overflow/theme-affects-visual-overflow.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/compositing/overflow/update-widget-positions-on-nested-frames-and-scrollers.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/paint/invalidation/button-checkbox-click-method-repaint.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/paint/invalidation/caret-invalidation-in-overflow-scroll.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/paint/invalidation/forms/button-reset-focus-by-mouse-then-keydown.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/paint/invalidation/forms/submit-focus-by-mouse-then-keydown.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/paint/invalidation/resize-iframe-text.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/paint/invalidation/search-field-cancel.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/paint/invalidation/subtree-root-skipped.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/paint/invalidation/textarea-caret.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/paint/selection/text-selection-inline-block-rtl.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/paint/selection/text-selection-inline-block.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/disable-spinvalidation/paint/spellmarkers/document-markers-zoom-150.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/gpu-rasterization/images/12-55.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/gpu-rasterization/images/182.html [ Failure ]
crbug.com/697971 [ Mac10.12 ] virtual/gpu-rasterization/images/2-dht.html [ Failure ]
Expand Down
7 changes: 1 addition & 6 deletions third_party/WebKit/LayoutTests/VirtualTestSuites
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,7 @@
},
{
"prefix": "disable-spinvalidation",
"base": "compositing",
"args": ["--disable-slimming-paint-invalidation"]
},
{
"prefix": "disable-spinvalidation",
"base": "paint",
"base": "paint/invalidation",
"args": ["--disable-slimming-paint-invalidation"]
},
{
Expand Down
Binary file not shown.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.

This file was deleted.

This file was deleted.

Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
{
"object": "LayoutText #text",
"rect": [12, 45, 52, 13],
"rect": [12, 45, 51, 13],
"reason": "layoutObject insertion"
}
]
Expand Down
Binary file not shown.

This file was deleted.

Loading

0 comments on commit 571b633

Please sign in to comment.