forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This is causing TestCSP to fail on chromium.mac
Revert 207470 "[Mac] Fix the problem that a popup could be close..." > [Mac] Fix the problem that a popup could be closed while it is still in animation. > > This occurs when the test code creates a popup and close the collection immediately. The fix is to close the popup without animation for this case. > > All the popup animations are coordinated by the popup collection. Added DCHECKs in the popup controller to guard the places that might trigger the 2nd animation while the previous animation has not ended. > > BUG=249131 > TEST=reenable the disabled test > R=dewittj@chromium.org, rsesek@chromium.org > > Review URL: https://codereview.chromium.org/17468007 TBR=jianli@chromium.org Review URL: https://codereview.chromium.org/17361005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207503 0039d316-1c4b-4281-b951-d872f2087c98
- Loading branch information
rmsousa@chromium.org
committed
Jun 20, 2013
1 parent
5e193aa
commit 59577f1
Showing
3 changed files
with
4 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters