Skip to content

Commit

Permalink
[Extensions] Replace the developer_private.js extern with the autogen…
Browse files Browse the repository at this point in the history
…erated one

Automatic extern generation has gotten to the point where it yields a better
result than the somewhat hand-modified version (Yay!). Use the generated one
in the closure compiler externs.

BUG=469920

Review URL: https://codereview.chromium.org/1010083008

Cr-Commit-Position: refs/heads/master@{#322672}
  • Loading branch information
rdcronin authored and Commit bot committed Mar 27, 2015
1 parent 68ea490 commit 5ed4724
Show file tree
Hide file tree
Showing 2 changed files with 135 additions and 125 deletions.
30 changes: 18 additions & 12 deletions chrome/common/extensions/api/developer_private.idl
Original file line number Diff line number Diff line change
Expand Up @@ -403,10 +403,10 @@ namespace developerPrivate {
// |includeDisabled| : include disabled items.
// |includeTerminated| : include terminated items.
// |callback| : Called with items info.
// DEPRECATED: Prefer getExtensionsInfo.
static void getItemsInfo(boolean includeDisabled,
boolean includeTerminated,
ItemsInfoCallback callback);
[deprecated="Use getExtensionsInfo"] static void getItemsInfo(
boolean includeDisabled,
boolean includeTerminated,
ItemsInfoCallback callback);

// Opens a permissions dialog.
// |extensionId| : The id of the extension to show permissions for.
Expand Down Expand Up @@ -475,15 +475,21 @@ namespace developerPrivate {
DeleteExtensionErrorsProperties properties,
optional VoidCallback callback);

// Deprecated api methods, retained for compatability.
[nocompile] static void allowIncognito(DOMString extensionId,
boolean allow,
optional VoidCallback callback);
[nocompile] static void allowFileAccess(DOMString extensionId,
boolean allow,
optional VoidCallback callback);
[nocompile] static void inspect(InspectOptions options,
[nocompile, deprecated="Use management.setEnabled"]
static void enable(DOMString id,
boolean enabled,
optional VoidCallback callback);
[nocompile, deprecated="Use updateExtensionConfiguration"]
static void allowIncognito(DOMString extensionId,
boolean allow,
optional VoidCallback callback);
[nocompile, deprecated="Use updateExtensionConfiguration"]
static void allowFileAccess(DOMString extensionId,
boolean allow,
optional VoidCallback callback);
[nocompile, deprecated="Use openDevTools"]
static void inspect(InspectOptions options,
optional VoidCallback callback);
};

interface Events {
Expand Down
Loading

0 comments on commit 5ed4724

Please sign in to comment.