From 63f233bcd3a8a6d7f3cfb5183b62160c96ded98e Mon Sep 17 00:00:00 2001
From: daniimms <daniimms@amazon.com>
Date: Mon, 20 Oct 2014 15:08:46 -0700
Subject: [PATCH] Increase coverage of telemetry's user_agent_unittest

Added a mobile and desktop testing in case the browser being tested has a
user agent that defaults to the tablet user agent.

BUG=421229

Review URL: https://codereview.chromium.org/640453002

Cr-Commit-Position: refs/heads/master@{#300349}
---
 AUTHORS                                       |  1 +
 .../telemetry/core/user_agent_unittest.py     | 20 ++++++++++++++++++-
 2 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/AUTHORS b/AUTHORS
index a6a5491a6b83ee..a61c7a61362cde 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -96,6 +96,7 @@ Craig Schlenter <craig.schlenter@gmail.com>
 Daegyu Lee <na7jun8gi@gmail.com>
 Dai Chunyang <chunyang.dai@intel.com>
 Daniel Bomar <dbdaniel42@gmail.com>
+Daniel Imms <daniimms@amazon.com>
 Daniel Johnson <danielj41@gmail.com>
 Daniel Nishi <dhnishi@gmail.com>
 Daniel Shaulov <dshaulov@ptc.com>
diff --git a/tools/telemetry/telemetry/core/user_agent_unittest.py b/tools/telemetry/telemetry/core/user_agent_unittest.py
index 1b50fb24a5eaa1..242ef7657b5f23 100644
--- a/tools/telemetry/telemetry/core/user_agent_unittest.py
+++ b/tools/telemetry/telemetry/core/user_agent_unittest.py
@@ -6,7 +6,16 @@
 from telemetry.unittest import tab_test_case
 
 
-class UserAgentTest(tab_test_case.TabTestCase):
+class MobileUserAgentTest(tab_test_case.TabTestCase):
+  @classmethod
+  def CustomizeBrowserOptions(cls, options):
+    options.browser_user_agent_type = 'mobile'
+
+  def testUserAgent(self):
+    ua = self._tab.EvaluateJavaScript('window.navigator.userAgent')
+    self.assertEquals(ua, user_agent.UA_TYPE_MAPPING['mobile'])
+
+class TabletUserAgentTest(tab_test_case.TabTestCase):
   @classmethod
   def CustomizeBrowserOptions(cls, options):
     options.browser_user_agent_type = 'tablet'
@@ -14,3 +23,12 @@ def CustomizeBrowserOptions(cls, options):
   def testUserAgent(self):
     ua = self._tab.EvaluateJavaScript('window.navigator.userAgent')
     self.assertEquals(ua, user_agent.UA_TYPE_MAPPING['tablet'])
+
+class DesktopUserAgentTest(tab_test_case.TabTestCase):
+  @classmethod
+  def CustomizeBrowserOptions(cls, options):
+    options.browser_user_agent_type = 'desktop'
+
+  def testUserAgent(self):
+    ua = self._tab.EvaluateJavaScript('window.navigator.userAgent')
+    self.assertEquals(ua, user_agent.UA_TYPE_MAPPING['desktop'])