Skip to content

Commit

Permalink
Roll libjingle to 98:99.
Browse files Browse the repository at this point in the history
- Refactoring and bug fixes 
- Remove global variables of class type.

NOTE: I'm landing this for Ronghua since he's on leave.  The change has already been reviewed here: http://codereview.chromium.org/8790011/
but I had to create a new issue in order to resolve merge conflicts.



TBR=sergeyu

Review URL: http://codereview.chromium.org/8802019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113086 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
tommi@chromium.org committed Dec 6, 2011
1 parent 6b37173 commit 657b6f8
Show file tree
Hide file tree
Showing 7 changed files with 18 additions and 7 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ vars = {
"40d182ac25fe6623cfbe5772623c15c663a42c93",
"nacl_toolchain_revision": "7332",

"libjingle_revision": "95",
"libjingle_revision": "99",
"libphonenumber_revision": "407",
"libvpx_revision": "109236",
"ffmpeg_revision": "112050",
Expand Down
2 changes: 1 addition & 1 deletion content/renderer/p2p/ipc_network_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ void IpcNetworkManager::OnNetworkListChanged(
memcpy(&address, &it->address[0], sizeof(uint32));
address = ntohl(address);
networks.push_back(
new talk_base::Network(it->name, it->name, address, 0));
new talk_base::Network(it->name, it->name, address));
}

MergeNetworkList(networks, !first_update_sent_);
Expand Down
2 changes: 1 addition & 1 deletion jingle/glue/fake_network_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ FakeNetworkManager::FakeNetworkManager(const net::IPAddressNumber& address)
talk_base::SocketAddress socket_address;
CHECK(IPEndPointToSocketAddress(endpoint, &socket_address));
network_.reset(new talk_base::Network("fake", "Fake Network",
socket_address.ip(), 0));
socket_address.ip()));
}

FakeNetworkManager::~FakeNetworkManager() {
Expand Down
4 changes: 2 additions & 2 deletions jingle/notifier/base/notifier_options_util.cc
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ buzz::XmppClientSettings MakeXmppClientSettings(
xmpp_client_settings.set_user(jid.node());
xmpp_client_settings.set_resource("chrome-sync");
xmpp_client_settings.set_host(jid.domain());
xmpp_client_settings.set_use_tls(true);
xmpp_client_settings.set_use_tls(buzz::TLS_ENABLED);
xmpp_client_settings.set_auth_cookie(
notifier_options.invalidate_xmpp_login ?
token + "bogus" : token);
xmpp_client_settings.set_token_service(token_service);
if (notifier_options.allow_insecure_connection) {
xmpp_client_settings.set_allow_plain(true);
xmpp_client_settings.set_use_tls(false);
xmpp_client_settings.set_use_tls(buzz::TLS_DISABLED);
}
return xmpp_client_settings;
}
Expand Down
2 changes: 1 addition & 1 deletion remoting/jingle_glue/xmpp_signal_strategy.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ void XmppSignalStrategy::Init(StatusObserver* observer) {
settings.set_user(login_jid.node());
settings.set_host(login_jid.domain());
settings.set_resource("chromoting");
settings.set_use_tls(true);
settings.set_use_tls(buzz::TLS_ENABLED);
settings.set_token_service(auth_token_service_);
settings.set_auth_cookie(auth_token_);
settings.set_server(talk_base::SocketAddress("talk.google.com", 5222));
Expand Down
7 changes: 6 additions & 1 deletion third_party/libjingle/README.chromium
Original file line number Diff line number Diff line change
@@ -1,12 +1,17 @@
Name: libjingle
Name: Libjingle library. Used for p2p voice and video communication.
Short Name: libjingle
URL: http://code.google.com/p/libjingle/
Version: 2.7.0
Revision: 99
License: BSD
License File: source/COPYING
Security Critical: yes

Description:
Libjingle provides xmpp support to the sync code, which
lives at chrome/browser/sync/notifier.

Libjingle is distributed under a Berkeley-style license detailed in
source/COPYING.

Local Modifications:
6 changes: 6 additions & 0 deletions third_party/libjingle/libjingle.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,8 @@
'source/talk/base/httpcommon.h',
'source/talk/base/httprequest.cc',
'source/talk/base/httprequest.h',
'source/talk/base/ipaddress.cc',
'source/talk/base/ipaddress.h',
'source/talk/base/json.cc',
'source/talk/base/json.h',
'source/talk/base/linked_ptr.h',
Expand Down Expand Up @@ -469,6 +471,8 @@
'source/talk/session/phone/cryptoparams.h',
'source/talk/session/phone/currentspeakermonitor.cc',
'source/talk/session/phone/currentspeakermonitor.h',
'source/talk/session/phone/devicemanager.cc',
'source/talk/session/phone/devicemanager.h',
'source/talk/session/phone/dummydevicemanager.cc',
'source/talk/session/phone/dummydevicemanager.h',
'source/talk/session/phone/filemediaengine.cc',
Expand All @@ -495,6 +499,8 @@
'source/talk/session/phone/soundclip.h',
'source/talk/session/phone/srtpfilter.cc',
'source/talk/session/phone/srtpfilter.h',
'source/talk/session/phone/ssrcmuxfilter.cc',
'source/talk/session/phone/ssrcmuxfilter.h',
'source/talk/session/phone/videocapturer.cc',
'source/talk/session/phone/videocapturer.h',
'source/talk/session/phone/videocommon.cc',
Expand Down

0 comments on commit 657b6f8

Please sign in to comment.