Skip to content

Commit

Permalink
Increase timeout for SnapshotAuraTest.FullScreenWindow test on Fuchsia
Browse files Browse the repository at this point in the history
SnapshotAuraTest.FullScreenWindow was using action_max_timeout() on
Linux, but not on Fuchsia. Now it's timing out on Fuchsia periodically.
Increase the timeout on Fuchsia as well.

Bug: 1143031, 1142521
Change-Id: Iaddd417af60a127273b965e1e0646674f8af10e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503347
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822153}
  • Loading branch information
SergeyUlanov authored and Commit Bot committed Oct 29, 2020
1 parent 3b1e1da commit 684e3ba
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions ui/snapshot/snapshot_aura_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -200,12 +200,12 @@ INSTANTIATE_TEST_SUITE_P(All, SnapshotAuraTest, ::testing::Bool());
#define MAYBE_FullScreenWindow FullScreenWindow
#endif
TEST_P(SnapshotAuraTest, MAYBE_FullScreenWindow) {
#if defined(OS_LINUX) || defined(OS_CHROMEOS)
// TODO(https://crbug.com/1002716): Fix this test to run in < action_timeout()
#if defined(OS_LINUX) || defined(OS_CHROMEOS) || defined(OS_FUCHSIA)
// TODO(https://crbug.com/1143031): Fix this test to run in < action_timeout()
// on the Linux Debug & TSAN bots.
const base::test::ScopedRunLoopTimeout increased_run_timeout(
FROM_HERE, TestTimeouts::action_max_timeout());
#endif // defined(OS_LINUX) || defined(OS_CHROMEOS)
#endif // defined(OS_LINUX) || defined(OS_CHROMEOS) || defined(OS_FUCHSIA)

#if defined(OS_WIN)
// TODO(https://crbug.com/850556): Make work on Win10.
Expand Down

0 comments on commit 684e3ba

Please sign in to comment.