Skip to content

Commit

Permalink
Typo fixes, plus a couple of code changes.
Browse files Browse the repository at this point in the history
Content script code seemed old; updated to what worked for me.
Manifest code had an extraneous comma that caused an error.

TBR=aa,rafaelw

Review URL: http://codereview.chromium.org/196079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25887 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
kathyw@google.com committed Sep 10, 2009
1 parent 86489d5 commit 6b60f1d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
10 changes: 5 additions & 5 deletions chrome/common/extensions/docs/static/content_scripts.html
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,8 @@ <h2 id="messaging">Messaging</h2>

// Also listen for new channels from the extension for when the button is
// pressed.
chrome.extension.onConnect.addListener(function(port, name) {
console.assert(name == "buttonClickedChannel");
chrome.extension.onConnect.addListener(function(port) {
console.assert(port.name == "buttonClickedChannel");
port.onMessage.addListener(function(msg) {
if (msg.buttonClicked) {
e.value = msg.passwordValue;
Expand Down Expand Up @@ -174,9 +174,9 @@ <h2 id="host-page-communication">Communication with the embedding page</h2>
customEvent.initEvent('myCustomEvent', true, true);

function fireCustomEvent(data) {
hidenDiv = document.getElementById('myCustomEventDiv');
hidenDiv.innerHTML = data
hidenDiv.dispatchEvent(customEvent);
hiddenDiv = document.getElementById('myCustomEventDiv');
hiddenDiv.innerHTML = data
hiddenDiv.dispatchEvent(customEvent);
}</pre>

<pre>contentscript.js
Expand Down
2 changes: 1 addition & 1 deletion chrome/common/extensions/docs/static/manifest.html
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ <h2 id="overview"> Field summary </h2>
"<a href="#permissions">permissions</a>": [...],
"<a href="npapi.html">plugins</a>": [...],
"<a href="themes.html">theme</a>": [...],
"<a href="toolstrip.html">toolstrips</a>": [...],
"<a href="toolstrip.html">toolstrips</a>": [...]
}
</pre>

Expand Down
4 changes: 2 additions & 2 deletions chrome/common/extensions/docs/static/overview.html
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ <h3>Referring to files</h3>
just as you would in an ordinary HTML page.
Here's an example of referring to
a file named <code>myimage.png</code>
that's in a subdirectory named <code>images</code>.
that's in a subfolder named <code>images</code>.
</p>

<pre>
Expand All @@ -101,7 +101,7 @@ <h3>Referring to files</h3>
You can see the IDs for all your loaded extensions
by going to the URL <b>chrome://extensions/</b>.
The <em>&lt;pathToFile></em> is the location of the file
under the extension's top directory;
under the extension's top folder;
it's the same as the relative URL.
</p>

Expand Down

0 comments on commit 6b60f1d

Please sign in to comment.