Skip to content

Commit

Permalink
Show password generation pop-up after page refresh.
Browse files Browse the repository at this point in the history
Password generation agent assumes that navigation to a new page or page
refresh will clear the form cache and re-query the autofill server. This
assumption broke after http://crrev.com/ffc78e28 started ignoring page
refresh. The result was unavailability of the password generation pop-up
after page refresh.

This patch restores the previous behavior of clearing the form cache on
page refresh. This triggers re-querying of the autofill server and
correctly showing password generation pop-ups.

BUG=530569
TEST=Open facebook.com, refresh, password generation should be available.

Review URL: https://codereview.chromium.org/1392633002

Cr-Commit-Position: refs/heads/master@{#352958}
  • Loading branch information
rsolomakhin authored and Commit bot committed Oct 7, 2015
1 parent e2e862d commit 6f1f93c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion components/autofill/content/renderer/autofill_agent.cc
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,8 @@ void AutofillAgent::DidCommitProvisionalLoad(bool is_new_navigation,

if (is_same_page_navigation) {
OnSamePageNavigationCompleted();
} else if (is_new_navigation) {
} else {
// Navigation to a new page or a page refresh.
form_cache_.Reset();
submitted_forms_.clear();
last_interacted_form_.reset();
Expand Down

0 comments on commit 6f1f93c

Please sign in to comment.