Skip to content

Commit

Permalink
color: Enable color correct rendering for images/ layout tests
Browse files Browse the repository at this point in the history
Apply this to GPU rasterization.

Force all platforms to use sRGB as their color space. A separate virtual
test suite will be added to test more exotic color spaces.

TBR=qyearsley
BUG=713891

Review-Url: https://codereview.chromium.org/2925763002
Cr-Commit-Position: refs/heads/master@{#477433}
  • Loading branch information
ccameron-chromium authored and Commit Bot committed Jun 6, 2017
1 parent bbd450e commit 711ff9d
Show file tree
Hide file tree
Showing 117 changed files with 41 additions and 116 deletions.
19 changes: 13 additions & 6 deletions third_party/WebKit/LayoutTests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2676,12 +2676,19 @@ crbug.com/576815 external/wpt/css/vendor-imports/mozilla/mozilla-central-reftest

# Producing incorrect results due to crbug.com/729352
# TODO(ccameron): Re-enable and re-baseline when fixed.
crbug.com/729352 images/color-profile-background-image-cross-fade.html [ Pass Failure Crash Timeout ]
crbug.com/729352 images/color-profile-background-image-space.html [ Pass Failure Crash Timeout ]
crbug.com/729352 images/color-profile-group.html [ Pass Failure Crash Timeout ]
crbug.com/729352 images/color-profile-layer-filter.html [ Pass Failure Crash Timeout ]
crbug.com/729352 images/color-profile-svg.html [ Pass Failure Crash Timeout ]
crbug.com/729352 images/color-profile-svg-fill-text.html [ Pass Failure Crash Timeout ]
crbug.com/729352 images/color-profile-background-image-cross-fade.html [ Pass Failure ]
crbug.com/729352 images/color-profile-background-image-space.html [ Pass Failure ]
crbug.com/729352 images/color-profile-group.html [ Pass Failure ]
crbug.com/729352 images/color-profile-layer-filter.html [ Pass Failure ]
crbug.com/729352 images/color-profile-svg.html [ Pass Failure ]
crbug.com/729352 images/color-profile-svg-fill-text.html [ Pass Failure ]
crbug.com/729352 virtual/gpu-rasterization/images/color-profile-background-image-space.html [ Pass Failure ]
crbug.com/729352 virtual/gpu-rasterization/images/color-profile-group.html [ Pass Failure ]
crbug.com/729352 virtual/gpu-rasterization/images/color-profile-layer-filter.html [ Pass Failure ]
crbug.com/729352 virtual/gpu-rasterization/images/color-profile-svg.html [ Pass Failure ]
crbug.com/729352 virtual/gpu-rasterization/images/color-profile-svg-fill-text.html [ Pass Failure ]
crbug.com/729352 virtual/gpu-rasterization/images/color-profile-clip.html [ Pass Failure Timeout ]
crbug.com/729352 virtual/gpu-rasterization/images/color-profile-layer.html [ Pass Failure Timeout ]

# TODO(chrishall): this is a temporary mediation step as part of the P0 issue crbug.com/657646
# this is not meant to be here for more than a few days (from 2016-11-03 SYD)
Expand Down
4 changes: 3 additions & 1 deletion third_party/WebKit/LayoutTests/VirtualTestSuites
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@
{
"prefix": "gpu-rasterization",
"base": "images",
"args": ["--force-gpu-rasterization"]
"args": ["--force-gpu-rasterization",
"--enable-color-correct-rendering",
"--force-color-profile=srgb"]
},
{
"prefix": "stable",
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Diff not rendered.
Diff not rendered.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,36 +1,36 @@

Color Actual Expected dE
--------------------------------------------
Dark Skin 95,62,49 115,80,64 31
Light Skin 181,133,111 195,151,130 30
Blue Sky 76,103,138 94,123,156 32
Foliage 71,90,50 88,108,65 29
Blue Flower 111,108,161 130,129,177 33
Bluish Green 85,178,155 100,190,171 25
Dark Skin 115,80,64 115,80,64 0
Light Skin 195,151,130 195,151,130 0
Blue Sky 94,123,156 94,123,156 0
Foliage 88,108,65 88,108,65 0
Blue Flower 130,129,177 130,129,177 0
Bluish Green 100,190,171 100,190,171 0
--------------------------------------------
Orange 206,102,29 217,122,37 24
Purplish Blue 56,69,148 72,91,165 32
Moderate Red 179,62,80 194,84,98 32
Purple 72,42,88 91,59,107 32
Yellow Green 144,178,47 160,188,60 23
Orange Yellow 222,147,33 230,163,42 20
Orange 217,122,37 217,122,37 0
Purplish Blue 72,91,165 72,91,165 0
Moderate Red 194,84,98 194,84,98 0
Purple 91,59,107 91,59,107 0
Yellow Green 160,188,60 160,188,60 0
Orange Yellow 230,163,42 230,163,42 0
--------------------------------------------
Blue 35,40,135 46,60,153 29
Green 58,135,53 71,150,69 25
Red 159,26,43 177,44,56 29
Yellow 233,190,24 238,200,27 12
Magenta 171,58,130 187,82,148 34
Cyan (*) 15,116,149 0,135,166 30
Blue 46,60,153 46,60,153 0
Green 71,150,69 71,150,69 0
Red 177,44,56 177,44,56 0
Yellow 238,200,27 238,200,27 0
Magenta 187,82,148 187,82,148 0
Cyan (*) 0,135,166 0,135,166 0
--------------------------------------------
White 240,239,233 243,242,237 6
Neutral 8 189,189,189 201,201,201 21
Neutral 6.5 144,144,144 161,161,161 29
Neutral 5 103,103,102 122,122,121 33
Neutral 3.5 65,65,65 83,83,83 31
Black 38,37,38 50,49,50 21
White 243,242,237 243,242,237 0
Neutral 8 201,201,201 201,201,201 0
Neutral 6.5 161,161,161 161,161,161 0
Neutral 5 122,122,121 122,122,121 0
Neutral 3.5 83,83,83 83,83,83 0
Black 50,49,50 50,49,50 0
--------------------------------------------

Result: total RMS color error: 27.64
Result: total RMS color error: 0.00
* Munsell Cyan is outside 255 sRGB gamut


Expand Down
Diff not rendered.
Diff not rendered.
Diff not rendered.
Diff not rendered.

This file was deleted.

Diff not rendered.
Diff not rendered.

0 comments on commit 711ff9d

Please sign in to comment.