Skip to content

Commit

Permalink
bindings: Disable V8 context snapshot feature on cross compile enviro…
Browse files Browse the repository at this point in the history
…nment

This change can disable the feature on some environments which are
going well, but this is a simple fix to fix the build error on
"32-bit ASAN V8 ARM Builders" bots.


Bug: 760120
Change-Id: I09dc29b61118409baf7f7b538ce376574df175be
Reviewed-on: https://chromium-review.googlesource.com/662962
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501533}
  • Loading branch information
peria authored and Commit Bot committed Sep 13, 2017
1 parent 424c35a commit 714aff4
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tools/v8_context_snapshot/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,17 @@
import("//build/config/c++/c++.gni")
import("//build/config/chromecast_build.gni")
import("//build/config/compiler/compiler.gni")
import("//build/config/v8_target_cpu.gni")
import("//v8/snapshot_toolchain.gni")

if (is_android) {
import("//build/config/android/rules.gni")
}

declare_args() {
use_v8_context_snapshot = !is_chromeos && !is_android && !is_chromecast
# TODO(crbug.com/764576): Enable the feature on more environments.
use_v8_context_snapshot = !is_chromeos && !is_android && !is_chromecast &&
v8_target_cpu == target_cpu
}

if (is_android) {
Expand Down

0 comments on commit 714aff4

Please sign in to comment.