Skip to content

Commit

Permalink
Enable WebViewExtraHeadersSameDomainOnly by default.
Browse files Browse the repository at this point in the history
Enable this experiment flag by default in preparation for enabling it on
stable via Finch.

Extend the expiry of the related metric so that it keeps collecting data
until after the default-enabling has reached stable.

Bug: 1038002
Change-Id: Ieae23184ab430565df775c1aad4112dc63ae1561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477155
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#817692}
  • Loading branch information
tornewuff authored and Commit Bot committed Oct 15, 2020
1 parent 0a5feec commit 72c9a90
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 17 deletions.
2 changes: 1 addition & 1 deletion android_webview/common/aw_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const base::Feature kWebViewDisplayCutout{"WebViewDisplayCutout",
// occurs. kWebViewExtraHeadersSameOriginOnly is stricter; when that's enabled,
// this feature has no effect.
const base::Feature kWebViewExtraHeadersSameDomainOnly{
"WebViewExtraHeadersSameDomainOnly", base::FEATURE_DISABLED_BY_DEFAULT};
"WebViewExtraHeadersSameDomainOnly", base::FEATURE_ENABLED_BY_DEFAULT};

// Only allow extra headers added via loadUrl() to be sent to the original
// origin; strip them from the request if a cross-origin redirect occurs.
Expand Down
15 changes: 0 additions & 15 deletions testing/variations/fieldtrial_testing_config.json
Original file line number Diff line number Diff line change
Expand Up @@ -8056,21 +8056,6 @@
]
}
],
"WebViewHeaderInjection": [
{
"platforms": [
"android_webview"
],
"experiments": [
{
"name": "SameDomainOnly",
"enable_features": [
"WebViewExtraHeadersSameDomainOnly"
]
}
]
}
],
"WebViewZeroCopyVideo": [
{
"platforms": [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2369,7 +2369,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram>

<histogram name="Android.WebView.ExtraHeadersRedirect"
enum="WebViewExtraHeadersRedirect" expires_after="2020-12-01">
enum="WebViewExtraHeadersRedirect" expires_after="2021-02-14">
<owner>torne@chromium.org</owner>
<owner>src/android_webview/OWNERS</owner>
<summary>
Expand Down

0 comments on commit 72c9a90

Please sign in to comment.