forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Replace External URL testErrorPageRedirect with hermetic test.
Old test was loading http://mock/bad and because this URL did not exist the load was failing because of DNS resolution error. New test uses EmbeddedTestServer, which closes the socket to simulate ERR_INTERNET_DISCONNECTED error. Bug: 694662 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iaca523e8153a2c4cca0e1f174652ed48f22cabd3 Reviewed-on: https://chromium-review.googlesource.com/1035610 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#555316}
- Loading branch information
Eugene But
authored and
Commit Bot
committed
May 2, 2018
1 parent
3c97d48
commit 7408a84
Showing
4 changed files
with
25 additions
and
77 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters