Skip to content

Commit

Permalink
cc: Move ListContainer to cc/base/.
Browse files Browse the repository at this point in the history
This means that list_container.cc can no longer refer to quad types etc., so
instead the bulk of the logic is moved to the non-template class
ListContainerBase, which can be defined without any knowledge outside cc/base/.

Due to linking issues, the instantiations are no longer explicit. However, the
actual template to be instantiated is now much smaller, with most of the actual
code being in ListContainerBase (which defined in list_container.cc).

Effort has been made to make minimal changes aside from code movement. In
particular, other refactorings (including of the unit test) are intentionally
not in this CL.

BUG=492952
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1161883003

Cr-Commit-Position: refs/heads/master@{#331843}
  • Loading branch information
jeremyroman authored and Commit bot committed May 28, 2015
1 parent ca7f2b9 commit 7ea06b0
Show file tree
Hide file tree
Showing 10 changed files with 947 additions and 1,000 deletions.
2 changes: 0 additions & 2 deletions cc/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,6 @@ component("cc") {
"quads/io_surface_draw_quad.h",
"quads/largest_draw_quad.cc",
"quads/largest_draw_quad.h",
"quads/list_container.cc",
"quads/list_container.h",
"quads/picture_draw_quad.cc",
"quads/picture_draw_quad.h",
"quads/render_pass.cc",
Expand Down
2 changes: 2 additions & 0 deletions cc/base/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ source_set("base") {
"histograms.h",
"invalidation_region.cc",
"invalidation_region.h",
"list_container.cc",
"list_container.h",
"math_util.cc",
"math_util.h",
"region.cc",
Expand Down
Loading

0 comments on commit 7ea06b0

Please sign in to comment.