Remove LinuxUI::GetTint

It was unused by GTK and QT. R=thestig Bug: None Change-Id: I36d2a0d34c1cfbd7208e2a44ffc05ceaee0811a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3704627 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/main@{#1014219}
Denger-Network · Jun 15, 2022 · 83c7592 · 83c7592
1 parent cdc8923
commit 83c7592
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 36 deletions.
diff --git a/chrome/browser/themes/theme_service_aura_linux.cc b/chrome/browser/themes/theme_service_aura_linux.cc
@@ -25,7 +25,6 @@ class SystemThemeLinux : public CustomThemeSupplier {
   // Overridden from CustomThemeSupplier:
   void StartUsingTheme() override;
   void StopUsingTheme() override;
-  bool GetTint(int id, color_utils::HSL* hsl) const override;
   bool GetColor(int id, SkColor* color) const override;
   bool GetDisplayProperty(int id, int* result) const override;
   gfx::Image GetImageNamed(int id) const override;
@@ -57,10 +56,6 @@ void SystemThemeLinux::StopUsingTheme() {
     linux_ui_->GetNativeTheme(nullptr)->NotifyOnNativeThemeUpdated();
 }
 
-bool SystemThemeLinux::GetTint(int id, color_utils::HSL* hsl) const {
-  return linux_ui_ && linux_ui_->GetTint(id, hsl);
-}
-
 bool SystemThemeLinux::GetColor(int id, SkColor* color) const {
   return linux_ui_ && linux_ui_->GetColor(id, color,
                                           pref_service_->GetBoolean(
@@ -79,7 +74,7 @@ bool SystemThemeLinux::HasCustomImage(int id) const {
   return false;
 }
 
-SystemThemeLinux::~SystemThemeLinux() {}
+SystemThemeLinux::~SystemThemeLinux() = default;
 
 }  // namespace
 

diff --git a/ui/gtk/gtk_ui.cc b/ui/gtk/gtk_ui.cc
@@ -325,24 +325,6 @@ bool GtkUi::Initialize() {
   return true;
 }
 
-bool GtkUi::GetTint(int id, color_utils::HSL* tint) const {
-  switch (id) {
-    // Tints for which the cross-platform default is fine. Before adding new
-    // values here, specifically verify they work well on Linux.
-    case ThemeProperties::TINT_BACKGROUND_TAB:
-    // TODO(estade): Return something useful for TINT_BUTTONS so that chrome://
-    // page icons are colored appropriately.
-    case ThemeProperties::TINT_BUTTONS:
-      break;
-    default:
-      // Assume any tints not specifically verified on Linux aren't usable.
-      // TODO(pkasting): Try to remove values from |colors_| that could just be
-      // added to the group above instead.
-      NOTREACHED();
-  }
-  return false;
-}
-
 bool GtkUi::GetColor(int id, SkColor* color, bool use_custom_frame) const {
   for (const ColorMap& color_map :
        {colors_,

diff --git a/ui/gtk/gtk_ui.h b/ui/gtk/gtk_ui.h
@@ -71,7 +71,6 @@ class GtkUi : public views::LinuxUI {
 
   // views::LinuxUI:
   bool Initialize() override;
-  bool GetTint(int id, color_utils::HSL* tint) const override;
   bool GetColor(int id, SkColor* color, bool use_custom_frame) const override;
   bool GetDisplayProperty(int id, int* result) const override;
   SkColor GetFocusRingColor() const override;

diff --git a/ui/qt/qt_ui.cc b/ui/qt/qt_ui.cc
@@ -171,11 +171,6 @@ bool QtUi::Initialize() {
   return true;
 }
 
-bool QtUi::GetTint(int id, color_utils::HSL* tint) const {
-  NOTIMPLEMENTED_LOG_ONCE();
-  return false;
-}
-
 bool QtUi::GetColor(int id, SkColor* color, bool use_custom_frame) const {
   NOTIMPLEMENTED_LOG_ONCE();
   return false;

diff --git a/ui/qt/qt_ui.h b/ui/qt/qt_ui.h
@@ -46,7 +46,6 @@ class QtUi : public views::LinuxUI, QtInterface::Delegate {
 
   // views::LinuxUI:
   bool Initialize() override;
-  bool GetTint(int id, color_utils::HSL* tint) const override;
   bool GetColor(int id, SkColor* color, bool use_custom_frame) const override;
   bool GetDisplayProperty(int id, int* result) const override;
   SkColor GetFocusRingColor() const override;

diff --git a/ui/views/linux_ui/linux_ui.h b/ui/views/linux_ui/linux_ui.h
@@ -38,10 +38,6 @@ namespace base {
 class TimeDelta;
 }
 
-namespace color_utils {
-struct HSL;
-}
-
 namespace gfx {
 class Image;
 }
@@ -128,7 +124,6 @@ class VIEWS_EXPORT LinuxUI : public ui::LinuxInputMethodContextFactory,
   // Returns true on success.  If false is returned, this instance shouldn't
   // be used and the behavior of all functions is undefined.
   [[nodiscard]] virtual bool Initialize() = 0;
-  virtual bool GetTint(int id, color_utils::HSL* tint) const = 0;
   virtual bool GetColor(int id,
                         SkColor* color,
                         bool use_custom_frame) const = 0;