Changing the styles and colors of the bookmark widget

Bug: 939149 Change-Id: I22f960d7ef2545d1560abc535308edec2ba40960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524098 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#640959}
Denger-Network · Mar 14, 2019 · 87e19e4 · 87e19e4
1 parent aae80a8
commit 87e19e4
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 5 deletions.
diff --git a/chrome/android/java/res/layout/bookmark_widget.xml b/chrome/android/java/res/layout/bookmark_widget.xml
@@ -7,7 +7,7 @@
     android:id="@+id/bookmarks_list"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
-    android:background="#ddffffff"
+    android:background="@color/bookmark_widget_background"
     android:divider="@null"
     android:drawSelectorOnTop="true"
     android:listSelector="@drawable/bookmark_widget_list_selector" />
diff --git a/chrome/android/java/res/layout/bookmark_widget_item.xml b/chrome/android/java/res/layout/bookmark_widget_item.xml
@@ -28,7 +28,6 @@
         android:paddingEnd="16dp"
         android:singleLine="true"
         android:textAlignment="viewStart"
-        android:textColor="@color/default_text_color"
-        android:textSize="16sp" />
+        android:textAppearance="@style/TextAppearance.BookmarkWidgetItemText" />
 
 </LinearLayout>
diff --git a/chrome/android/java/res/values-v17/styles.xml b/chrome/android/java/res/values-v17/styles.xml
@@ -730,6 +730,10 @@
         parent="@style/TextAppearance.AppCompat.Medium">
         <item name="android:textColor">@color/standard_mode_tint</item>
     </style>
+    <style name="TextAppearance.BookmarkWidgetItemText"
+        parent="@style/TextAppearance.BlackTitle1">
+        <item name="android:textColor">@color/default_text_color_dark</item>
+    </style>
 
     <!-- Download Home -->
     <style name="DateView">

diff --git a/chrome/android/java/res/values/colors.xml b/chrome/android/java/res/values/colors.xml
@@ -181,6 +181,7 @@
 
     <!-- Bookmark widget colors -->
     <color name="bookmark_widget_pressed_highlight">@color/black_alpha_11</color>
+    <color name="bookmark_widget_background">#DDFFFFFF</color>
 
     <!-- Payments UI colors -->
     <color name="payments_section_edit_background">@color/modern_secondary_color</color>

diff --git a/...e/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java b/...e/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java
@@ -288,7 +288,7 @@ public BookmarkAdapter(Context context, int widgetId) {
             mWidgetId = widgetId;
             mPreferences = getWidgetState(mContext, mWidgetId);
             mIconColor = ApiCompatibilityUtils.getColor(
-                    mContext.getResources(), R.color.default_icon_color);
+                    mContext.getResources(), R.color.default_icon_color_dark);
         }
 
         @UiThread

diff --git a/ui/android/java/res/values/color_palette.xml b/ui/android/java/res/values/color_palette.xml
@@ -44,6 +44,8 @@
     <color name="default_icon_color_white_pressed" tools:ignore="UnusedResources">
         @color/white_alpha_50
     </color>
+    <!-- Common text colors -->
+    <color name="default_text_color_dark">@color/modern_grey_900</color>
 
     <color name="default_red_light" tools:ignore="UnusedResources">@color/google_red_300</color>
     <color name="default_red_dark" tools:ignore="UnusedResources">@color/google_red_700</color>

diff --git a/ui/android/java/res/values/colors.xml b/ui/android/java/res/values/colors.xml
@@ -7,7 +7,7 @@
 <resources xmlns:tools="http://schemas.android.com/tools">
     <!-- TODO(huayinz): remove tools:ignore once these colors are used in ui/android -->
     <!-- Common text colors -->
-    <color name="default_text_color">@color/modern_grey_900</color>
+    <color name="default_text_color">@color/default_text_color_dark</color>
     <color name="default_text_color_secondary">@color/modern_grey_700</color>
     <!-- Text color for non-clickable blue text. -->
     <color name="default_text_color_blue" tools:ignore="UnusedResources">@color/modern_blue_600</color>