diff --git a/ash/display/mouse_cursor_event_filter.cc b/ash/display/mouse_cursor_event_filter.cc index ba770452aad02c..f5960d0ced0183 100644 --- a/ash/display/mouse_cursor_event_filter.cc +++ b/ash/display/mouse_cursor_event_filter.cc @@ -469,15 +469,12 @@ void MouseCursorEventFilter::GetSrcAndDstRootWindows(aura::Window** src_root, bool MouseCursorEventFilter::WarpMouseCursorIfNecessaryForTest( aura::Window* target_root, const gfx::Point& point_in_screen) { - if (enable_mouse_warp_in_native_coords) { - gfx::Point native = point_in_screen; - wm::ConvertPointFromScreen(target_root, &native); - target_root->GetHost()->ConvertPointToNativeScreen(&native); - return WarpMouseCursorInNativeCoords(native, point_in_screen); - } else { + if (!enable_mouse_warp_in_native_coords) return WarpMouseCursorInScreenCoords(target_root, point_in_screen); - } - return true; + gfx::Point native = point_in_screen; + wm::ConvertPointFromScreen(target_root, &native); + target_root->GetHost()->ConvertPointToNativeScreen(&native); + return WarpMouseCursorInNativeCoords(native, point_in_screen); } } // namespace ash diff --git a/chrome/browser/extensions/extension_apitest.cc b/chrome/browser/extensions/extension_apitest.cc index f38852444a14e9..a8c397bae6573c 100644 --- a/chrome/browser/extensions/extension_apitest.cc +++ b/chrome/browser/extensions/extension_apitest.cc @@ -281,8 +281,9 @@ bool ExtensionApiTest::RunExtensionSubtest(const std::string& extension_name, #if defined(OS_WIN) && !defined(NDEBUG) LOG(WARNING) << "Workaround for 177163, prematurely returning"; return true; -#endif +#else return RunExtensionTestImpl(extension_name, page_url, NULL, flags); +#endif } diff --git a/chrome/test/gpu/gpu_feature_browsertest.cc b/chrome/test/gpu/gpu_feature_browsertest.cc index 8bed26b3fcf401..c2ebe8bfeb51ee 100644 --- a/chrome/test/gpu/gpu_feature_browsertest.cc +++ b/chrome/test/gpu/gpu_feature_browsertest.cc @@ -213,10 +213,10 @@ IN_PROC_BROWSER_TEST_F(GpuFeatureTest, WebGLAllowed) { gpu::GPU_FEATURE_TYPE_WEBGL)); // The below times out: http://crbug.com/166060 - return; - +#if 0 const base::FilePath url(FILE_PATH_LITERAL("feature_webgl.html")); RunEventTest(url, kWebGLCreationEvent, true); +#endif } IN_PROC_BROWSER_TEST_F(GpuFeatureTest, WebGLBlocked) { diff --git a/components/search_provider_logos/logo_tracker_unittest.cc b/components/search_provider_logos/logo_tracker_unittest.cc index 0e889af8bd216e..7872134b9f5b26 100644 --- a/components/search_provider_logos/logo_tracker_unittest.cc +++ b/components/search_provider_logos/logo_tracker_unittest.cc @@ -224,8 +224,8 @@ class MockLogoCache : public LogoCache { } virtual scoped_ptr GetCachedLogo() OVERRIDE { - return make_scoped_ptr(logo_ ? new EncodedLogo(*logo_) : NULL); OnGetCachedLogo(); + return make_scoped_ptr(logo_ ? new EncodedLogo(*logo_) : NULL); } private: diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc index 08b5708c5922e4..0607c92c0ec515 100644 --- a/content/browser/renderer_host/render_widget_host_view_aura.cc +++ b/content/browser/renderer_host/render_widget_host_view_aura.cc @@ -2371,8 +2371,6 @@ scoped_ptr RenderWidgetHostViewAura::CreateResizeLock( desired_size, defer_compositor_lock, base::TimeDelta::FromMilliseconds(kResizeLockTimeoutMs))); - ResizeLock* lock = NULL; - return scoped_ptr(lock); } DelegatedFrameHost* RenderWidgetHostViewAura::GetDelegatedFrameHost() const { diff --git a/content/renderer/p2p/ipc_network_manager.cc b/content/renderer/p2p/ipc_network_manager.cc index a11e03cbab93a4..3dce7c8087ee0b 100644 --- a/content/renderer/p2p/ipc_network_manager.cc +++ b/content/renderer/p2p/ipc_network_manager.cc @@ -30,7 +30,6 @@ talk_base::AdapterType ConvertConnectionTypeToAdapterType( default: return talk_base::ADAPTER_TYPE_UNKNOWN; } - return talk_base::ADAPTER_TYPE_UNKNOWN; } } // namespace diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc index eb165ae17fd556..45651319d29051 100644 --- a/pdf/pdfium/pdfium_engine.cc +++ b/pdf/pdfium/pdfium_engine.cc @@ -275,8 +275,6 @@ void OOM_Handler(_OOM_INFO*) { // the buffer is then used, it provides a handy mapping of memory starting at // address 0 for an attacker to utilize. abort(); - // Paranoia, just in case. - *(volatile char*)0 = '\0'; } OOM_INFO g_oom_info = {