Skip to content

Commit

Permalink
Include skia/include/codec directory into skia_config for iOS too
Browse files Browse the repository at this point in the history
We currently exclude this directory from skia_config iOS simply because
it has not been unused. However, due to modifications to PaintImage to
support YUV decoding, there is header inclusion that leads back to
third_party/skia/include/codec/SkEncodedOrigin.h. This caused a compile
error leading to those YUV changes [1] to be reverted.

[1] crrev.com/c/1368687

Bug: NOBUG
Change-Id: Ie42587226f8f9cfd817f98e6157294deb4427ea0
Reviewed-on: https://chromium-review.googlesource.com/c/1440243
Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Leon Scroggins <scroggo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#627031}
  • Loading branch information
Madeleine Barowsky authored and Commit Bot committed Jan 29, 2019
1 parent b870ca6 commit 89a3c59
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion skia/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ config("skia_config") {
"config",
"ext",
"//third_party/skia/include/c",
"//third_party/skia/include/codec",
"//third_party/skia/include/config",
"//third_party/skia/include/core",
"//third_party/skia/include/docs",
Expand All @@ -57,7 +58,6 @@ config("skia_config") {
]

if (!is_ios) {
include_dirs += [ "//third_party/skia/include/codec" ]
defines += [ "SK_HAS_JPEG_LIBRARY" ]
}
if (enable_vulkan) {
Expand Down

0 comments on commit 89a3c59

Please sign in to comment.