Skip to content

Commit

Permalink
Remove and deprecate ExperienceSamplingPrivate API
Browse files Browse the repository at this point in the history
This removes the ExperienceSamplingPrivate extension API, which was used
only by the CUES extension (which is no longer in use). This also
removes all the instrumentation code that triggered the extension events
throughout the code base, and deprecates entries in enums.

Bug: 810420
Change-Id: Ia155ad3feada4bac147f0960e05065c44d6978a3
Reviewed-on: https://chromium-review.googlesource.com/915121
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537369}
  • Loading branch information
christhompson authored and Commit Bot committed Feb 16, 2018
1 parent e363dc2 commit 8b286c9
Show file tree
Hide file tree
Showing 42 changed files with 31 additions and 737 deletions.
3 changes: 0 additions & 3 deletions chrome/app/generated_resources.grd
Original file line number Diff line number Diff line change
Expand Up @@ -3768,9 +3768,6 @@ are declared in build/common.gypi.
<message name="IDS_EXTENSION_PROMPT_WARNING_ACCESSIBILITY_FEATURES_READ_MODIFY" desc="Permission string for reading and modifying acccessibility settings via extension API shown when an extension utilizing the API is installed.">
Read and change your accessibility settings
</message>
<message name="IDS_EXTENSION_PROMPT_WARNING_EXPERIENCE_SAMPLING_PRIVATE" desc="Permission string for Experience Sampling Private API.">
Monitor when you take actions in Chrome
</message>
<message name="IDS_EXTENSION_PROMPT_WARNING_PLATFORMKEYS" desc="Permission string for access to client certificates.">
Use your client certificates
</message>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,6 @@ class DownloadDangerPromptTest
#define MAYBE_TestAll TestAll
#endif
IN_PROC_BROWSER_TEST_P(DownloadDangerPromptTest, MAYBE_TestAll) {
// ExperienceSampling: Set default actions for DownloadItem methods we need.
GURL download_url(kTestDownloadUrl);
ON_CALL(download(), GetURL()).WillByDefault(ReturnRef(download_url));
ON_CALL(download(), GetReferrerUrl())
Expand Down
4 changes: 0 additions & 4 deletions chrome/browser/extensions/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,6 @@ static_library("extensions") {
"api/easy_unlock_private/easy_unlock_private_connection_manager.h",
"api/easy_unlock_private/easy_unlock_private_crypto_delegate.h",
"api/easy_unlock_private/easy_unlock_private_crypto_delegate_chromeos.cc",
"api/experience_sampling_private/experience_sampling.cc",
"api/experience_sampling_private/experience_sampling.h",
"api/experience_sampling_private/experience_sampling_private_api.cc",
"api/experience_sampling_private/experience_sampling_private_api.h",
"api/extension_action/extension_action_api.cc",
"api/extension_action/extension_action_api.h",
"api/extension_action/extension_page_actions_api_constants.cc",
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

29 changes: 0 additions & 29 deletions chrome/browser/extensions/extension_install_prompt.cc
Original file line number Diff line number Diff line change
Expand Up @@ -114,35 +114,6 @@ ExtensionInstallPrompt::PromptType
ExtensionInstallPrompt::g_last_prompt_type_for_tests =
ExtensionInstallPrompt::UNSET_PROMPT_TYPE;

// This should match the PromptType enum.
std::string ExtensionInstallPrompt::PromptTypeToString(PromptType type) {
switch (type) {
case INSTALL_PROMPT:
return "INSTALL_PROMPT";
case INLINE_INSTALL_PROMPT:
return "INLINE_INSTALL_PROMPT";
case RE_ENABLE_PROMPT:
return "RE_ENABLE_PROMPT";
case PERMISSIONS_PROMPT:
return "PERMISSIONS_PROMPT";
case EXTERNAL_INSTALL_PROMPT:
return "EXTERNAL_INSTALL_PROMPT";
case POST_INSTALL_PERMISSIONS_PROMPT:
return "POST_INSTALL_PERMISSIONS_PROMPT";
case REMOTE_INSTALL_PROMPT:
return "REMOTE_INSTALL_PROMPT";
case REPAIR_PROMPT:
return "REPAIR_PROMPT";
case DELEGATED_PERMISSIONS_PROMPT:
return "DELEGATED_PERMISSIONS_PROMPT";
case UNSET_PROMPT_TYPE:
case NUM_PROMPT_TYPES:
NOTREACHED();
break;
}
return "OTHER";
}

ExtensionInstallPrompt::Prompt::Prompt(PromptType type)
: type_(type),
is_showing_details_for_retained_files_(false),
Expand Down
2 changes: 0 additions & 2 deletions chrome/browser/extensions/extension_install_prompt.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ class ExtensionInstallPrompt {
ALL_PERMISSIONS,
};

static std::string PromptTypeToString(PromptType type);

// Extra information needed to display an installation or uninstallation
// prompt. Gets populated with raw data and exposes getters for formatted
// strings so that the GTK/views/Cocoa install dialogs don't have to repeat
Expand Down
Loading

0 comments on commit 8b286c9

Please sign in to comment.