forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reduce the requirement for saving previousLocation
ObjectPaintInvalidator::previousLocationInBacking() accesses a global map if location was different from visualRect.location() during the last paint invalidation. The percentage of LayoutObjects requiring to save previousLocation was about 5% before SlimmingPaintInvalidation is enabled, but increased to about 37% after. The main reason was that we always called enclosingIntRect() when computing visual rect, causing visualRect.location() was different from location if location is not at whole pixels. Now call enclosingIntRect() only when there is any transform. A minor reason was about empty rects having different location. Location of an empty visual rect actually has no actual functional effect on paint invalidation. Now don't map empty rects, but force its location to be the same as location in backing, so that we always don't need to save previous location of empty visual rects. BUG=685179 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2706063003 Cr-Commit-Position: refs/heads/master@{#451908}
- Loading branch information
1 parent
b3d8f58
commit 8cc1739
Showing
20 changed files
with
120 additions
and
1,219 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 0 additions & 38 deletions
38
...d_party/WebKit/LayoutTests/platform/android/paint/invalidation/bugzilla-5699-expected.txt
This file was deleted.
Oops, something went wrong.
74 changes: 0 additions & 74 deletions
74
...party/WebKit/LayoutTests/platform/android/paint/invalidation/flexbox/repaint-expected.txt
This file was deleted.
Oops, something went wrong.
31 changes: 0 additions & 31 deletions
31
...t/LayoutTests/platform/android/paint/invalidation/flexbox/repaint-rtl-column-expected.txt
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 changes: 0 additions & 93 deletions
93
...atform/linux/virtual/disable-spinvalidation/paint/invalidation/bugzilla-5699-expected.txt
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.