diff --git a/PRESUBMIT.py b/PRESUBMIT.py index b5571273036c65..886078da5fbdd8 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -337,7 +337,6 @@ '^chrome/browser/history/android/android_history_provider_service_unittest.cc', # pylint: disable=line-too-long '^chrome/browser/media_galleries/', '^chrome/browser/net/websocket_browsertest.cc', - '^chrome/browser/notifications/', '^chrome/browser/ntp_tiles/ntp_tiles_browsertest.cc', '^chrome/browser/page_load_metrics/observers/data_saver_site_breakdown_metrics_observer_browsertest.cc', # pylint: disable=line-too-long '^chrome/browser/payments/payment_manifest_parser_browsertest.cc', diff --git a/chrome/browser/notifications/notification_platform_bridge_linux.cc b/chrome/browser/notifications/notification_platform_bridge_linux.cc index aa2894624f48f3..29db40bba59d04 100644 --- a/chrome/browser/notifications/notification_platform_bridge_linux.cc +++ b/chrome/browser/notifications/notification_platform_bridge_linux.cc @@ -523,13 +523,14 @@ class NotificationPlatformBridgeLinuxImpl this, ConnectionInitializationStatusCode::SUCCESS)); notification_proxy_->ConnectToSignal( kFreedesktopNotificationsName, kSignalActionInvoked, - base::Bind(&NotificationPlatformBridgeLinuxImpl::OnActionInvoked, this), + base::BindRepeating( + &NotificationPlatformBridgeLinuxImpl::OnActionInvoked, this), base::BindOnce(&NotificationPlatformBridgeLinuxImpl::OnSignalConnected, this)); notification_proxy_->ConnectToSignal( kFreedesktopNotificationsName, kSignalNotificationClosed, - base::Bind(&NotificationPlatformBridgeLinuxImpl::OnNotificationClosed, - this), + base::BindRepeating( + &NotificationPlatformBridgeLinuxImpl::OnNotificationClosed, this), base::BindOnce(&NotificationPlatformBridgeLinuxImpl::OnSignalConnected, this)); } @@ -1020,7 +1021,7 @@ class NotificationPlatformBridgeLinuxImpl if (!product_logo_file_watcher_->Watch( product_logo_file_->file_path(), base::FilePathWatcher::Type::kNonRecursive, - base::Bind( + base::BindRepeating( &NotificationPlatformBridgeLinuxImpl::OnProductLogoFileChanged, this))) { product_logo_file_.reset(); diff --git a/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm b/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm index 8a174f8af02ca9..294183415ca653 100644 --- a/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm +++ b/chrome/browser/notifications/notification_platform_bridge_mac_unittest.mm @@ -295,7 +295,7 @@ new NotificationPlatformBridgeMac(notification_center(), int notification_count = -1; bridge->GetDisplayed( - profile(), base::Bind(&StoreNotificationCount, ¬ification_count)); + profile(), base::BindOnce(&StoreNotificationCount, ¬ification_count)); base::RunLoop().RunUntilIdle(); EXPECT_EQ(1, notification_count); } diff --git a/chrome/browser/notifications/notification_platform_bridge_mac_utils.mm b/chrome/browser/notifications/notification_platform_bridge_mac_utils.mm index c6c1ca3d3d95d0..88e8cdf2726081 100644 --- a/chrome/browser/notifications/notification_platform_bridge_mac_utils.mm +++ b/chrome/browser/notifications/notification_platform_bridge_mac_utils.mm @@ -51,9 +51,9 @@ void DoProcessMacNotificationResponse( profileManager->LoadProfile( profileId, incognito, - base::Bind(&NotificationDisplayServiceImpl::ProfileLoadedCallback, - operation, type, origin, notificationId, actionIndex, reply, - byUser)); + base::BindOnce(&NotificationDisplayServiceImpl::ProfileLoadedCallback, + operation, type, origin, notificationId, actionIndex, + reply, byUser)); } // Implements the version check to determine if alerts are supported. Do not