Skip to content

Commit

Permalink
Build just chrome to shorten the Coverity build and analysis
Browse files Browse the repository at this point in the history
time.

Remove a stale TODO comment.

R=bevc,jimhebert
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3175001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55637 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
wtc@chromium.org committed Aug 11, 2010
1 parent ce7f62e commit 8e85e9a
Showing 1 changed file with 6 additions and 7 deletions.
13 changes: 6 additions & 7 deletions tools/coverity/coverity.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,6 @@ def _RunCommand(cmd, dry_run, shell=False, echo_cmd=True):
"""Runs the command if dry_run is false, otherwise just prints the command."""
if echo_cmd:
print cmd
# TODO(wtc): Check the return value of subprocess.call, which is the return
# value of the command.
if not dry_run:
return subprocess.call(cmd, shell=shell)
else:
Expand Down Expand Up @@ -171,19 +169,20 @@ def main(options, args):
use_shell_during_make = True
os.chdir('src')
_RunCommand('pwd', options.dry_run, shell=True)
cmd = '%s/cov-build --dir %s make BUILDTYPE=%s' % (
cmd = '%s/cov-build --dir %s make BUILDTYPE=%s chrome' % (
options.coverity_bin_dir, options.coverity_intermediate_dir,
options.target)
elif sys.platform == 'win32':
cmd = '%s\\cov-build.exe --dir %s devenv.com %s\\%s /build %s' % (
cmd = ('%s\\cov-build.exe --dir %s devenv.com %s\\%s /build %s '
'/project chrome.vcproj') % (
options.coverity_bin_dir, options.coverity_intermediate_dir,
options.source_dir, options.solution_file, options.target)
elif sys.platform == 'darwin':
use_shell_during_make = True
os.chdir('src/build')
os.chdir('src/chrome')
_RunCommand('pwd', options.dry_run, shell=True)
cmd = ('%s/cov-build --dir %s xcodebuild -project all.xcodeproj '
'-configuration %s -target All') % (
cmd = ('%s/cov-build --dir %s xcodebuild -project chrome.xcodeproj '
'-configuration %s -target chrome') % (
options.coverity_bin_dir, options.coverity_intermediate_dir,
options.target)

Expand Down

0 comments on commit 8e85e9a

Please sign in to comment.