forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[DevTools] Fix Background Service metadata entry order.
According to https://developers.google.com/protocol-buffers/docs/proto#maps iteration ordering of map values is undefined. This CL sorts the metadata entries before in the DevTools frontend so they can be presented in a consistent order. Also remove redundant test formatting, fix the OWNERS Background Service regexp to include the handler, and make the row counting start from 1. Change-Id: I36024f23fbb307b1160cd67120dcf67ca8697aa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615251 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Reviewed-by: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#664458}
- Loading branch information
Showing
3 changed files
with
9 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
caseq@chromium.org | ||
alph@chromium.org | ||
|
||
per-file *background_services*=rayankans@chromium.org | ||
per-file *background_service*=rayankans@chromium.org | ||
|
||
# COMPONENT: Platform>DevTools |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters