From 92075cd635ecbb2df595220731532e6b11174c6e Mon Sep 17 00:00:00 2001 From: "Rakib M. Hasan" Date: Fri, 29 Mar 2019 23:27:39 +0000 Subject: [PATCH] Adds new optional fields to the JSON results merger script These new fields can be useful for debugging regressions due to invalid test expectations. It also updates the JSON results documentation to include the new fields as well as the optional test_name_prefix field which was added in a previous CL. Bug: chromium:698902 Change-Id: Icc0edd59a2a3b585fb793a70355ee585cac28fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546257 Reviewed-by: Kenneth Russell Commit-Queue: Rakib Hasan Cr-Commit-Position: refs/heads/master@{#646000} --- docs/testing/json_test_results_format.md | 3 +++ testing/merge_scripts/results_merger.py | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/testing/json_test_results_format.md b/docs/testing/json_test_results_format.md index ff36fab319be8f..1780ee6202df1c 100644 --- a/docs/testing/json_test_results_format.md +++ b/docs/testing/json_test_results_format.md @@ -86,6 +86,9 @@ object may appear in any order. | `artifact_permanent_location` | string | **Optional.** The URI of the root location where the artifacts are stored. If present, any artifact locations are taken to be relative to this location. Currently only the `gs://` scheme is supported. | | `build_number` | string | **Optional.** If this test run was produced on a bot, this should be the build number of the run, e.g., "1234". | | `builder_name` | string | **Optional.** If this test run was produced on a bot, this should be the builder name of the bot, e.g., "Linux Tests". | +| `test_name_prefix` | string | **Optional.** If a prefix was specified to be removed from test names, then that prefix can be placed here. | +| `expectations_files` | array of strings | **Optional.** If a list of expectations file paths are passed to the test runner, then that list can be placed here. | +| `tags` | array of strings | **Optional.** If a list of test expectations file tags are passed to the test runner, then that list can be placed here. | | `chromium_revision` | string | **Optional.** The revision of the current Chromium checkout, if relevant, e.g. "356123". | | `has_pretty_patch` | bool | **Optional, layout test specific, deprecated.** Whether the web tests' output contains PrettyDiff-formatted diffs for test failures. | | `has_wdiff` | bool | **Optional, layout test specific, deprecated.** Whether the web tests' output contains wdiff-formatted diffs for test failures. | diff --git a/testing/merge_scripts/results_merger.py b/testing/merge_scripts/results_merger.py index 2aa75b17985ad3..44af0d8cf8ea9e 100755 --- a/testing/merge_scripts/results_merger.py +++ b/testing/merge_scripts/results_merger.py @@ -25,7 +25,9 @@ 'path_delimiter', 'pixel_tests_enabled', 'random_order_seed', - 'test_name_prefix' + 'test_name_prefix', + 'tags', + 'expectations_files' ) OPTIONAL_IGNORED = (