forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sandbox::TouchMemory now doesn't destroy input buffer
Windows 10 RS4 (maybe older as well) x64 implementation of CopyFile expects that the HANDLE passed to NtCreateFile is not modified upon error. Old implementation of TouchMemory 'destroys' the buffer before passing it to the broker. This can be fixed by first reading the original value and then restoring back at the original place. This has to be done carefully so optimizer won't remove the code. R=wfh@chromium.org Bug: 839775 Change-Id: Iff80f3a5f145b85da2f0ba500e74387fce4e0e4b Reviewed-on: https://chromium-review.googlesource.com/1061460 Reviewed-by: Will Harris <wfh@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#559279}
- Loading branch information
Showing
4 changed files
with
43 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters