Skip to content

Commit

Permalink
Broaden valgrind supression for known issue in zlib. This seems ok be…
Browse files Browse the repository at this point in the history
…cause this code changes infrequently.

Re-enable zip unit tests on mac.

Review URL: http://codereview.chromium.org/118087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17369 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
aa@chromium.org committed Jun 1, 2009
1 parent fa922b1 commit 94bdde1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
6 changes: 2 additions & 4 deletions chrome/common/zip_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,7 @@ class ZipTest : public PlatformTest {
// hard-coded contents of a known zip file
std::set<FilePath> zip_contents_;
};
// TODO(aa): re-enable this test for Mac (was disabled temporarily to clear
// valgrind error on mac.
#if !defined(OS_MACOSX)

TEST_F(ZipTest, Unzip) {
TestUnzipFile(FILE_PATH_LITERAL("test.zip"));
}
Expand All @@ -103,5 +101,5 @@ TEST_F(ZipTest, Zip) {

EXPECT_TRUE(file_util::Delete(zip_file, false));
}
#endif // !defined(OS_MACOSX)

} // namespace
3 changes: 1 addition & 2 deletions tools/valgrind/suppressions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
{
Uninitialized value in deflate
Memcheck:Cond
fun:longest_match
fun:deflate_slow
...
fun:MOZ_Z_deflate
}
{
Expand Down

0 comments on commit 94bdde1

Please sign in to comment.