Skip to content

Commit

Permalink
IDL: Required [Exposed] to get rid of [PrimaryGlobal]
Browse files Browse the repository at this point in the history
Modified files in imagecapture, mediarecorder and
presentation modules.

Spec: whatwg/webidl#365

Bug: 792432
Change-Id: Ica4e157ab6b962bf185823ef6e6163c34bfb03cb
Reviewed-on: https://chromium-review.googlesource.com/868091
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529594}
  • Loading branch information
Pramod B S authored and Commit Bot committed Jan 17, 2018
1 parent d01be1d commit 994f930
Show file tree
Hide file tree
Showing 14 changed files with 26 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ enum NavigationType {
"prerender"
};
[
RuntimeEnabled=PerformanceNavigationTiming2
RuntimeEnabled=PerformanceNavigationTiming2,
Exposed=Window
] interface PerformanceNavigationTiming : PerformanceResourceTiming {
readonly attribute DOMHighResTimeStamp unloadEventStart;
readonly attribute DOMHighResTimeStamp unloadEventEnd;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
ConstructorCallWith=ExecutionContext,
Constructor(MediaStreamTrack track),
MeasureAs=ImageCaptureConstructor,
RaisesException=Constructor
RaisesException=Constructor,
Exposed=Window
] interface ImageCapture {
[ImplementedAs=videoStreamTrack] readonly attribute MediaStreamTrack track;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

// https://w3c.github.io/mediacapture-image/#mediasettingsrange

[Exposed=Window]
interface MediaSettingsRange {
readonly attribute double max;
readonly attribute double min;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ enum FillLightMode {
"flash",
};

[Exposed=Window]
interface PhotoCapabilities {
readonly attribute RedEyeReduction redEyeReduction;
readonly attribute MediaSettingsRange imageHeight;
Expand Down
4 changes: 2 additions & 2 deletions third_party/WebKit/Source/modules/mediarecorder/BlobEvent.idl
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
// https://w3c.github.io/mediacapture-record/MediaRecorder.html#blob-event

[
Exposed=Window,
Constructor(DOMString type, BlobEventInit eventInitDict)
]
interface BlobEvent : Event {
] interface BlobEvent : Event {
[SameObject] readonly attribute Blob data;
readonly attribute DOMHighResTimeStamp timecode;
};
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ enum RecordingState { "inactive", "recording", "paused" };
ActiveScriptWrappable,
ConstructorCallWith=ExecutionContext,
Constructor(MediaStream stream, optional MediaRecorderOptions options),
RaisesException=Constructor
RaisesException=Constructor,
Exposed=Window
] interface MediaRecorder : EventTarget {
readonly attribute MediaStream stream;
readonly attribute DOMString mimeType;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
// https://w3c.github.io/presentation-api/#interface-presentation

[
RuntimeEnabled=Presentation
RuntimeEnabled=Presentation,
Exposed=Window
] interface Presentation {
[MeasureAs=PresentationDefaultRequest] attribute PresentationRequest? defaultRequest;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@

[
ActiveScriptWrappable,
RuntimeEnabled=Presentation
RuntimeEnabled=Presentation,
Exposed=Window
] interface PresentationAvailability : EventTarget {
readonly attribute boolean value;
attribute EventHandler onchange;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ enum PresentationConnectionState {
};

[
RuntimeEnabled=Presentation
RuntimeEnabled=Presentation,
Exposed=Window
] interface PresentationConnection : EventTarget {
readonly attribute USVString id;
readonly attribute USVString url;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@

[
Constructor(DOMString type, PresentationConnectionAvailableEventInit eventInitDict),
RuntimeEnabled=Presentation
RuntimeEnabled=Presentation,
Exposed=Window
] interface PresentationConnectionAvailableEvent : Event {
[SameObject] readonly attribute PresentationConnection connection;
};
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ enum PresentationConnectionCloseReason { "error", "closed", "wentaway" };

[
Constructor(DOMString type, PresentationConnectionCloseEventInit eventInitDict),
RuntimeEnabled=Presentation
RuntimeEnabled=Presentation,
Exposed=Window
] interface PresentationConnectionCloseEvent : Event {
readonly attribute PresentationConnectionCloseReason reason;
readonly attribute DOMString message;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
// https://w3c.github.io/presentation-api/#interface-presentationconnectionlist

[
RuntimeEnabled=Presentation
RuntimeEnabled=Presentation,
Exposed=Window
] interface PresentationConnectionList : EventTarget {
readonly attribute FrozenArray<PresentationConnection> connections;
attribute EventHandler onconnectionavailable;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
// https://w3c.github.io/presentation-api/#idl-def-presentationreceiver

[
RuntimeEnabled=Presentation
RuntimeEnabled=Presentation,
Exposed=Window
] interface PresentationReceiver {
[SameObject, CallWith=ScriptState] readonly attribute Promise<PresentationConnectionList> connectionList;
};
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
Constructor(sequence<USVString> urls),
MeasureAs=PresentationRequestConstructor,
RaisesException=Constructor,
RuntimeEnabled=Presentation
RuntimeEnabled=Presentation,
Exposed=Window
] interface PresentationRequest : EventTarget {
[CallWith=ScriptState, MeasureAs=PresentationRequestStart] Promise<PresentationConnection> start();
[CallWith=ScriptState, MeasureAs=PresentationRequestReconnect] Promise<PresentationConnection> reconnect(DOMString id);
Expand Down

0 comments on commit 994f930

Please sign in to comment.