Skip to content

Commit

Permalink
Rename Port._real_tests -> Port.real_tests (as per FIXME comment)
Browse files Browse the repository at this point in the history
Review-Url: https://codereview.chromium.org/1964653002
Cr-Commit-Position: refs/heads/master@{#393008}
  • Loading branch information
qyearsley authored and Commit bot committed May 11, 2016
1 parent b237053 commit 997fcac
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,7 @@ def reference_files(self, test_name):

def tests(self, paths):
"""Return the list of tests found matching paths."""
tests = self._real_tests(paths)
tests = self.real_tests(paths)

suites = self.virtual_test_suites()
if paths:
Expand All @@ -756,7 +756,7 @@ def tests(self, paths):
tests.extend(self._all_virtual_tests(suites))
return tests

def _real_tests(self, paths):
def real_tests(self, paths):
# When collecting test cases, skip these directories
skipped_directories = set(['.svn', '_svn', 'platform', 'resources', 'support', 'script-tests', 'reference', 'reftest'])
files = find_files.find(self._filesystem, self.layout_tests_dir(), paths,
Expand Down Expand Up @@ -1606,7 +1606,7 @@ def _virtual_tests_matching_paths(self, paths, suites):

def _populate_virtual_suite(self, suite):
if not suite.tests:
base_tests = self._real_tests([suite.base])
base_tests = self.real_tests([suite.base])
suite.tests = {}
for test in base_tests:
suite.tests[test.replace(suite.base, suite.name, 1)] = test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,7 @@ def execute(self, options, args, tool):
if options.include_virtual_tests:
tests = sorted(default_port.tests(args))
else:
# FIXME: make real_tests() a public method.
tests = sorted(default_port._real_tests(args))
tests = sorted(default_port.real_tests(args))

for port_name in port_names:
if port_name != port_names[0]:
Expand Down

0 comments on commit 997fcac

Please sign in to comment.