From 9d7588a3546b55b20eaa45ecf69182ee73c1d4b0 Mon Sep 17 00:00:00 2001 From: Takeshi Yoshino Date: Mon, 31 Jul 2017 07:17:34 +0000 Subject: [PATCH] Reland "Adjust WATCHLISTS rules for tyoshino@" This is a reland of 84cd55563319bab8c11cd535a984bfcc2e6850db Original change's description: > Adjust WATCHLISTS rules for tyoshino@ > > - Add content_websockets and net_websockets for more WebSockets code > coverage > - Group XHR, sendBeacon, EventSource and Fetch API into blink_fetch_api > - Add / at the end of directories in blink_loader > - Remove tyoshino@ from blink_fetch as blink_loader covers it now > - Add blink_url_api, blink_streams > > Bug: > Change-Id: I0fa0b2e22be6d9a4d086217cf664ac6b59db72d0 > Reviewed-on: https://chromium-review.googlesource.com/580010 > Reviewed-by: Takashi Toyoshima > Commit-Queue: Takeshi Yoshino > Cr-Commit-Position: refs/heads/master@{#490353} Change-Id: Ia12824b6637cecc3b73aea8b254d542ff7c0393e Reviewed-on: https://chromium-review.googlesource.com/591507 Reviewed-by: Takashi Toyoshima Commit-Queue: Takeshi Yoshino Cr-Commit-Position: refs/heads/master@{#490723} --- WATCHLISTS | 38 +++++++++++++++++++++++++++++--------- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/WATCHLISTS b/WATCHLISTS index f08222c0fcf7b3..c7485d22e2c099 100644 --- a/WATCHLISTS +++ b/WATCHLISTS @@ -367,6 +367,9 @@ 'content_shell': { 'filepath': 'content/shell/', }, + 'content_websockets': { + 'filepath': 'content/browser/websockets/', + }, 'content_worker': { 'filepath': 'content/.*worker', }, @@ -769,6 +772,10 @@ 'net_spdy': { 'filepath': 'net/spdy/', }, + 'net_websockets': { + 'filepath': 'net/websockets/' \ + '|net/data/websocket/' + }, 'netinfo': { 'filepath': 'netinfo', }, @@ -1328,6 +1335,12 @@ 'blink_fetch': { 'filepath': 'third_party/WebKit/Source/platform/loader/fetch' }, + 'blink_fetch_api': { + 'filepath': 'third_party/WebKit/Source/core/xmlhttprequest/' \ + '|third_party/WebKit/Source/modules/beacon/' \ + '|third_party/WebKit/Source/modules/eventsource/' \ + '|third_party/WebKit/Source/modules/fetch/' + }, 'blink_fileapi': { 'filepath': 'third_party/WebKit/Source/modules/filesystem/' \ '|third_party/WebKit/Source/core/fileapi/' \ @@ -1382,8 +1395,8 @@ 'filepath': 'third_party/WebKit/Source/core/layout/ng', }, 'blink_loader': { - 'filepath': 'third_party/WebKit/Source/core/loader' \ - '|third_party/WebKit/Source/platform/loader' + 'filepath': 'third_party/WebKit/Source/core/loader/' \ + '|third_party/WebKit/Source/platform/loader/' }, 'blink_media': { 'filepath': 'third_party/WebKit/Source/core/css/mediaControls' \ @@ -1512,6 +1525,9 @@ 'blink_spv2_layout_tests': { 'filepath': 'third_party/WebKit/LayoutTests/virtual/spv2' }, + 'blink_streams': { + 'filepath': 'third_party/WebKit/Source/core/streams/' + }, 'blink_style': { 'filepath': 'third_party/WebKit/.*(style/|Style)', }, @@ -1527,6 +1543,9 @@ '|third_party/WebKit/Source/core/css/mediaControl' \ '|third_party/WebKit/LayoutTests/media/track/' }, + 'blink_url_api': { + 'filepath': 'third_party/WebKit/Source/core/url/' + }, 'blink_vibration': { 'filepath': 'third_party/WebKit/LayoutTests/vibration/' \ '|third_party/WebKit/Source/modules/vibration/' @@ -1559,7 +1578,8 @@ '|third_party/WebKit/Source/platform/image-encoders/skia/WEBP' }, 'blink_websockets': { - 'filepath': 'third_party/WebKit/Source/modules/websockets/' + 'filepath': 'third_party/WebKit/Source/modules/websockets/' \ + '|third_party/WebKit/Source/platform/modules/websockets/' }, 'blink_workers': { 'filepath': 'third_party/WebKit/Source/core/workers' \ @@ -1573,9 +1593,6 @@ 'blink_xml': { 'filepath': 'third_party/WebKit/Source/core/xml/' }, - 'blink_xmlhttprequest': { - 'filepath': 'third_party/WebKit/Source/core/xmlhttprequest/' - }, }, ############################################################################## @@ -1734,8 +1751,8 @@ 'eae+blinkwatch@chromium.org'], 'blink_fetch': ['gavinp+loader@chromium.org', 'japhet@chromium.org', - 'loading-reviews+fetch@chromium.org', - 'tyoshino+watch@chromium.org'], + 'loading-reviews+fetch@chromium.org'], + 'blink_fetch_api': ['tyoshino+watch@chromium.org'], 'blink_fileapi': ['kinuko+fileapi@chromium.org', 'nhiroki@chromium.org', 'tzik@chromium.org'], @@ -1833,6 +1850,7 @@ 'timvolodine@chromium.org', 'xiaochengh@chromium.org'], 'blink_spv2_layout_tests': ['pdr+virtualspv2watchlist@chromium.org'], + 'blink_streams': ['tyoshino+watch@chromium.org'], 'blink_style': ['blink-reviews-style@chromium.org'], 'blink_svg': ['dschulze@chromium.org', 'fmalita+watch@chromium.org', @@ -1846,6 +1864,7 @@ 'fs@opera.com', 'glenn@chromium.org', 'silviapf@chromium.org'], + 'blink_url_api': ['tyoshino+watch@chromium.org'], 'blink_vibration': ['mlamouri+watch-blink@chromium.org'], 'blink_viewport_interaction': ['kenneth.christiansen@gmail.com'], 'blink_w3ctests': ['blink-reviews-w3ctests@chromium.org'], @@ -1865,7 +1884,6 @@ 'blink_wtf': ['blink-reviews-wtf@chromium.org', 'mikhail.pozdnyakov@intel.com'], 'blink_xml': ['dominicc+watchlist@chromium.org'], - 'blink_xmlhttprequest': ['tyoshino+watch@chromium.org'], 'bookmarks': ['tfarina@chromium.org'], 'bottombar': ['donnd+watch@chromium.org', 'mdjones+watch@chromium.org'], @@ -1946,6 +1964,7 @@ 'content_shell': ['jochen+watch@chromium.org', 'mlamouri+watch-content@chromium.org', 'peter@chromium.org'], + 'content_websockets': ['tyoshino+watch@chromium.org'], 'content_worker': ['blink-worker-reviews@chromium.org', 'kinuko+watch@chromium.org'], 'contextual_search': ['donnd+watch@chromium.org', @@ -2103,6 +2122,7 @@ 'net_log': ['bnc+watch@chromium.org', 'eroman@chromium.org'], 'net_spdy': ['bnc+watch@chromium.org'], + 'net_websockets': ['tyoshino+watch@chromium.org'], 'netinfo': ['jkarlin+watch@chromium.org'], 'notifications': ['awdf+watch@chromium.org', 'mlamouri+watch-notifications@chromium.org',