From a124a2e4eff4229cac8f3c4ae362ed313954c322 Mon Sep 17 00:00:00 2001 From: Hans Wennborg Date: Tue, 28 Apr 2020 18:56:36 +0000 Subject: [PATCH] Remove/replace unnecessary logging.h includes in .cc files (rlz) CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I054e9ccfcbe6417607237e46a42622194956f1eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164513 Auto-Submit: Hans Wennborg Commit-Queue: Roger Tawa Reviewed-by: Roger Tawa Cr-Commit-Position: refs/heads/master@{#763464} --- rlz/lib/crc32_unittest.cc | 1 - rlz/lib/crc8_unittest.cc | 1 - rlz/lib/financial_ping_test.cc | 1 - rlz/lib/lib_values_unittest.cc | 1 - rlz/lib/rlz_lib_test.cc | 1 - rlz/lib/string_utils_unittest.cc | 1 - rlz/mac/lib/machine_id_mac.cc | 1 - rlz/win/lib/machine_deal_test.cc | 1 - 8 files changed, 8 deletions(-) diff --git a/rlz/lib/crc32_unittest.cc b/rlz/lib/crc32_unittest.cc index 9700058754cc27..4932a7b72117f0 100644 --- a/rlz/lib/crc32_unittest.cc +++ b/rlz/lib/crc32_unittest.cc @@ -6,7 +6,6 @@ #include "rlz/lib/crc32.h" -#include "base/logging.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/rlz/lib/crc8_unittest.cc b/rlz/lib/crc8_unittest.cc index 2a2f5f08b5435a..7575f169707262 100644 --- a/rlz/lib/crc8_unittest.cc +++ b/rlz/lib/crc8_unittest.cc @@ -6,7 +6,6 @@ #include -#include "base/logging.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/rlz/lib/financial_ping_test.cc b/rlz/lib/financial_ping_test.cc index 0ca61f6876c10c..c7d2ef06fc3622 100644 --- a/rlz/lib/financial_ping_test.cc +++ b/rlz/lib/financial_ping_test.cc @@ -18,7 +18,6 @@ #include -#include "base/logging.h" #include "base/stl_util.h" #include "base/strings/string_util.h" #include "base/strings/stringprintf.h" diff --git a/rlz/lib/lib_values_unittest.cc b/rlz/lib/lib_values_unittest.cc index 3fcda4fd28c756..a5920881d3deda 100644 --- a/rlz/lib/lib_values_unittest.cc +++ b/rlz/lib/lib_values_unittest.cc @@ -4,7 +4,6 @@ #include "rlz/lib/lib_values.h" -#include "base/logging.h" #include "rlz/lib/assert.h" #include "testing/gmock/include/gmock/gmock.h" #include "testing/gtest/include/gtest/gtest.h" diff --git a/rlz/lib/rlz_lib_test.cc b/rlz/lib/rlz_lib_test.cc index 1a21bb8c61c076..2f3df137dfc0f6 100644 --- a/rlz/lib/rlz_lib_test.cc +++ b/rlz/lib/rlz_lib_test.cc @@ -18,7 +18,6 @@ #include #include "base/bind.h" -#include "base/logging.h" #include "base/message_loop/message_pump_type.h" #include "base/posix/eintr_wrapper.h" #include "base/strings/stringprintf.h" diff --git a/rlz/lib/string_utils_unittest.cc b/rlz/lib/string_utils_unittest.cc index 4fad24f2ef3006..c72a16f18c6f60 100644 --- a/rlz/lib/string_utils_unittest.cc +++ b/rlz/lib/string_utils_unittest.cc @@ -8,7 +8,6 @@ #include -#include "base/logging.h" #include "base/stl_util.h" #include "base/strings/utf_string_conversions.h" #include "rlz/lib/assert.h" diff --git a/rlz/mac/lib/machine_id_mac.cc b/rlz/mac/lib/machine_id_mac.cc index 236aaa48524c9c..7a13dc0e4d5210 100644 --- a/rlz/mac/lib/machine_id_mac.cc +++ b/rlz/mac/lib/machine_id_mac.cc @@ -10,7 +10,6 @@ #include #include -#include "base/logging.h" #include "base/mac/foundation_util.h" #include "base/mac/mac_util.h" #include "base/mac/scoped_cftyperef.h" diff --git a/rlz/win/lib/machine_deal_test.cc b/rlz/win/lib/machine_deal_test.cc index 064396be0440c3..6f542b6b282489 100644 --- a/rlz/win/lib/machine_deal_test.cc +++ b/rlz/win/lib/machine_deal_test.cc @@ -13,7 +13,6 @@ #include "rlz/win/lib/machine_deal.h" -#include "base/logging.h" #include "rlz/lib/machine_deal_win.h" #include "rlz/test/rlz_test_helpers.h" #include "testing/gmock/include/gmock/gmock.h"