From a41a7b0ea6acf2817ba7852fcccc931feb8d4cbf Mon Sep 17 00:00:00 2001 From: Evan Stade Date: Fri, 8 Jan 2021 03:04:36 +0000 Subject: [PATCH] [Code health] Fix gn check for //extensions/browser/api/clipboard Bug: 1158941 Change-Id: Iac4c4b0c662d556100a908ab4f878237fb810b21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611697 Commit-Queue: Evan Stade Reviewed-by: Erik Staab Reviewed-by: Devlin Cr-Commit-Position: refs/heads/master@{#841336} --- .gn | 1 - extensions/browser/api/BUILD.gn | 6 +++++- extensions/browser/api/clipboard/BUILD.gn | 6 +++++- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.gn b/.gn index 1d802d414b87b5..1abcb116700ff0 100644 --- a/.gn +++ b/.gn @@ -94,7 +94,6 @@ no_check_targets = [ "//extensions/browser/api/bluetooth_socket:*", # 12 errors "//extensions/browser/api/cast_channel:*", # 3 errors "//extensions/browser/api/cec_private:*", # 4 errors - "//extensions/browser/api/clipboard:*", # 3 errors "//extensions/browser/api/declarative:*", # 20 errors "//extensions/browser/api/declarative_content:*", # 2 errors "//extensions/browser/api/declarative_net_request:*", # 18 errors diff --git a/extensions/browser/api/BUILD.gn b/extensions/browser/api/BUILD.gn index 30686d697b4f93..85f6363db68f3e 100644 --- a/extensions/browser/api/BUILD.gn +++ b/extensions/browser/api/BUILD.gn @@ -134,9 +134,9 @@ source_set("api") { "media_perception_private/media_perception_private_api.h", ] + # TODO(crbug/1158984): as above, remove these deps. public_deps += [ "//extensions/browser/api/cec_private", - "//extensions/browser/api/clipboard", "//extensions/browser/api/diagnostics", "//extensions/browser/api/virtual_keyboard", "//extensions/browser/api/vpn_provider", @@ -207,6 +207,10 @@ group("api_implementations") { "//extensions/browser/api/virtual_keyboard_private", "//extensions/browser/api/web_request", ] + + if (is_chromeos_ash) { + public_deps += [ "//extensions/browser/api/clipboard" ] + } } function_registration("api_registration") { diff --git a/extensions/browser/api/clipboard/BUILD.gn b/extensions/browser/api/clipboard/BUILD.gn index f4d1009c309749..145361c00e2c90 100644 --- a/extensions/browser/api/clipboard/BUILD.gn +++ b/extensions/browser/api/clipboard/BUILD.gn @@ -13,7 +13,11 @@ source_set("clipboard") { "clipboard_api.h", ] - deps = [ "//extensions/common/api" ] + deps = [ + "//extensions/browser/api", + "//extensions/common/api", + "//ui/base/clipboard", + ] public_deps = [ "//extensions/browser:browser_sources" ] }