Aw Autofill: Enable tests that were flaky

Ran the AwAutofillTest 100 times and a test case 1000 times locally, didn't see any failure. Also check the autofill related code, didn't see any suspicious. It seems that the culprit of the flaky has been fixed. Bug: 1279813, 1153875 Change-Id: Id19c5270aad2fb3374005d205bebe7228e5c6824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3352921 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Michael Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/main@{#953580}
Denger-Network · Dec 22, 2021 · a497cb8 · a497cb8
1 parent 46fada7
commit a497cb8
Showing 1 changed file with 0 additions and 9 deletions.
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwAutofillTest.java
@@ -50,7 +50,6 @@
 import org.chromium.base.task.PostTask;
 import org.chromium.base.test.util.CallbackHelper;
 import org.chromium.base.test.util.DisableIf;
-import org.chromium.base.test.util.DisabledTest;
 import org.chromium.base.test.util.Feature;
 import org.chromium.base.test.util.FlakyTest;
 import org.chromium.base.test.util.MetricsUtils;
@@ -918,7 +917,6 @@ public void tearDown() {
     @Test
     @SmallTest
     @Feature({"AndroidWebView"})
-    @DisabledTest(message = "https://crbug.com/1279813")
     public void testTouchingFormWithAdjustResize() throws Throwable {
         PostTask.runOrPostTask(UiThreadTaskTraits.DEFAULT, () -> {
             mRule.getActivity().getWindow().setSoftInputMode(
@@ -1116,7 +1114,6 @@ public void testBasicAutofill() throws Throwable {
     @Test
     @SmallTest
     @Feature({"AndroidWebView"})
-    @DisabledTest(message = "https://crbug.com/1153875")
     public void testAutofillTriggersAfterReload() throws Throwable {
         final String data = "<html><head></head><body><form action='a.html' name='formname'>"
                 + "<input type='text' id='text1' name='username'"
@@ -1147,7 +1144,6 @@ public void testAutofillTriggersAfterReload() throws Throwable {
     @Test
     @SmallTest
     @Feature({"AndroidWebView"})
-    @DisabledTest(message = "https://crbug.com/1279813")
     public void testNotifyVirtualValueChanged() throws Throwable {
         final String data = "<html><head></head><body><form action='a.html' name='formname'>"
                 + "<input type='text' id='text1' name='username'"
@@ -1182,7 +1178,6 @@ public void testNotifyVirtualValueChanged() throws Throwable {
     @Test
     @SmallTest
     @Feature({"AndroidWebView"})
-    @DisabledTest(message = "https://crbug.com/1279813")
     public void testJavascriptNotTriggerNotifyVirtualValueChanged() throws Throwable {
         final String data = "<html><head></head><body><form action='a.html' name='formname'>"
                 + "<input type='text' id='text1' name='username'"
@@ -1307,7 +1302,6 @@ public void testMovingToOtherForm() throws Throwable {
     @Test
     @SmallTest
     @Feature({"AndroidWebView"})
-    @DisabledTest(message = "https://crbug.com/1279813")
     public void testSwitchFromIFrame() throws Throwable {
         // we intentionally load main frame and iframe from the same URL and make both have the
         // similar form, so the new session is triggered by frame change
@@ -1522,7 +1516,6 @@ public void testNoSubmissionWithoutFillingForm() throws Throwable {
     @Feature({"AndroidWebView"})
     @DisableIf.Build(sdk_is_less_than = Build.VERSION_CODES.P,
             message = "This test is disabled on Android O because of https://crbug.com/997362")
-    @DisabledTest(message = "https://crbug.com/1279813")
     public void
     testSelectControlChangeNotification() throws Throwable {
         int cnt = 0;
@@ -2058,7 +2051,6 @@ public void testUMAAutofillCreatedByActivityContext() {
     @Test
     @SmallTest
     @Feature({"AndroidWebView"})
-    @DisabledTest(message = "https://crbug.com/1279813")
     public void testPageScrollTriggerViewExitAndEnter() throws Throwable {
         final String data = "<html><head></head><body><form action='a.html' name='formname'>"
                 + "<input type='text' id='text1' name='username'"
@@ -2678,7 +2670,6 @@ public void testFieldAddedBeforeSuggestionSelected() throws Throwable {
     @Test
     @SmallTest
     @Feature({"AndroidWebView"})
-    @DisabledTest(message = "https://crbug.com/1279813")
     public void testFirstFieldRemovedBeforeSuggestionSelected() throws Throwable {
         // This test verifies that form filling works even if an element of the form that was
         // supposed to be filled has been deleted between the time of decision to fill the form and