Move base/debug/trace_event* to base/trace_event/ [part 1]

Trace Event used to be a single file, base/debug/trace_event.h. Then we added more functionality, so it was base/debug/trace_event*.* For many years, we have had per-file OWNERS for Trace Event based off of trace_event*. This let us do trace_event improvements/iteration out of band with the much slower base/OWNERS process. But, this leads to a lot of poor filename choices for tracing related features, specifically to fall under trace event reviewers instead of base/ reviewers. That's clearly wrong. BUG=451032 Review URL: https://codereview.chromium.org/837303004 Cr-Commit-Position: refs/heads/master@{#313266}
Denger-Network · Jan 27, 2015 · a59d427 · a59d427
1 parent 454b4e5
commit a59d427
Show file tree

Hide file tree

Showing 31 changed files with 2,863 additions and 2,776 deletions.
diff --git a/base/BUILD.gn b/base/BUILD.gn
@@ -169,19 +169,10 @@ component("base") {
     "debug/task_annotator.cc",
     "debug/task_annotator.h",
     "debug/trace_event.h",
-    "debug/trace_event_android.cc",
-    "debug/trace_event_argument.cc",
     "debug/trace_event_argument.h",
-    "debug/trace_event_impl.cc",
     "debug/trace_event_impl.h",
-    "debug/trace_event_impl_constants.cc",
-    "debug/trace_event_memory.cc",
-    "debug/trace_event_memory.h",
-    "debug/trace_event_synthetic_delay.cc",
     "debug/trace_event_synthetic_delay.h",
-    "debug/trace_event_system_stats_monitor.cc",
-    "debug/trace_event_system_stats_monitor.h",
-    "debug/trace_event_win.cc",
+    "debug/trace_event_win.h",
     "deferred_sequenced_task_runner.cc",
     "deferred_sequenced_task_runner.h",
     "environment.cc",
@@ -687,6 +678,21 @@ component("base") {
     "timer/mock_timer.h",
     "timer/timer.cc",
     "timer/timer.h",
+    "trace_event/trace_event.h",
+    "trace_event/trace_event_android.cc",
+    "trace_event/trace_event_argument.cc",
+    "trace_event/trace_event_argument.h",
+    "trace_event/trace_event_impl.cc",
+    "trace_event/trace_event_impl.h",
+    "trace_event/trace_event_impl_constants.cc",
+    "trace_event/trace_event_memory.cc",
+    "trace_event/trace_event_memory.h",
+    "trace_event/trace_event_synthetic_delay.cc",
+    "trace_event/trace_event_synthetic_delay.h",
+    "trace_event/trace_event_system_stats_monitor.cc",
+    "trace_event/trace_event_system_stats_monitor.h",
+    "trace_event/trace_event_win.cc",
+    "trace_event/trace_event_win.h",
     "tracked_objects.cc",
     "tracked_objects.h",
     "tracking_info.cc",
@@ -1167,12 +1173,6 @@ test("base_unittests") {
     "debug/proc_maps_linux_unittest.cc",
     "debug/stack_trace_unittest.cc",
     "debug/task_annotator_unittest.cc",
-    "debug/trace_event_argument_unittest.cc",
-    "debug/trace_event_memory_unittest.cc",
-    "debug/trace_event_synthetic_delay_unittest.cc",
-    "debug/trace_event_system_stats_monitor_unittest.cc",
-    "debug/trace_event_unittest.cc",
-    "debug/trace_event_win_unittest.cc",
     "deferred_sequenced_task_runner_unittest.cc",
     "environment_unittest.cc",
     "file_version_info_unittest.cc",
@@ -1334,6 +1334,12 @@ test("base_unittests") {
     "timer/mock_timer_unittest.cc",
     "timer/timer_unittest.cc",
     "tools_sanity_unittest.cc",
+    "trace_event/trace_event_argument_unittest.cc",
+    "trace_event/trace_event_memory_unittest.cc",
+    "trace_event/trace_event_synthetic_delay_unittest.cc",
+    "trace_event/trace_event_system_stats_monitor_unittest.cc",
+    "trace_event/trace_event_unittest.cc",
+    "trace_event/trace_event_win_unittest.cc",
     "tracked_objects_unittest.cc",
     "tuple_unittest.cc",
     "values_unittest.cc",

diff --git a/base/base.gyp b/base/base.gyp
@@ -482,12 +482,6 @@
         'debug/proc_maps_linux_unittest.cc',
         'debug/stack_trace_unittest.cc',
         'debug/task_annotator_unittest.cc',
-        'debug/trace_event_argument_unittest.cc',
-        'debug/trace_event_memory_unittest.cc',
-        'debug/trace_event_synthetic_delay_unittest.cc',
-        'debug/trace_event_system_stats_monitor_unittest.cc',
-        'debug/trace_event_unittest.cc',
-        'debug/trace_event_win_unittest.cc',
         'deferred_sequenced_task_runner_unittest.cc',
         'environment_unittest.cc',
         'file_version_info_unittest.cc',
@@ -652,6 +646,12 @@
         'timer/mock_timer_unittest.cc',
         'timer/timer_unittest.cc',
         'tools_sanity_unittest.cc',
+        'trace_event/trace_event_argument_unittest.cc',
+        'trace_event/trace_event_memory_unittest.cc',
+        'trace_event/trace_event_synthetic_delay_unittest.cc',
+        'trace_event/trace_event_system_stats_monitor_unittest.cc',
+        'trace_event/trace_event_unittest.cc',
+        'trace_event/trace_event_win_unittest.cc',
         'tracked_objects_unittest.cc',
         'tuple_unittest.cc',
         'values_unittest.cc',

diff --git a/base/base.gypi b/base/base.gypi
@@ -171,18 +171,10 @@
           'debug/task_annotator.cc',
           'debug/task_annotator.h',
           'debug/trace_event.h',
-          'debug/trace_event_android.cc',
-          'debug/trace_event_argument.cc',
           'debug/trace_event_argument.h',
-          'debug/trace_event_impl.cc',
           'debug/trace_event_impl.h',
-          'debug/trace_event_impl_constants.cc',
-          'debug/trace_event_synthetic_delay.cc',
           'debug/trace_event_synthetic_delay.h',
-          'debug/trace_event_system_stats_monitor.cc',
-          'debug/trace_event_memory.cc',
-          'debug/trace_event_memory.h',
-          'debug/trace_event_win.cc',
+          'debug/trace_event_win.h',
           'deferred_sequenced_task_runner.cc',
           'deferred_sequenced_task_runner.h',
           'environment.cc',
@@ -680,6 +672,21 @@
           'timer/mock_timer.h',
           'timer/timer.cc',
           'timer/timer.h',
+          'trace_event/trace_event.h',
+          'trace_event/trace_event_android.cc',
+          'trace_event/trace_event_argument.cc',
+          'trace_event/trace_event_argument.h',
+          'trace_event/trace_event_impl.cc',
+          'trace_event/trace_event_impl.h',
+          'trace_event/trace_event_impl_constants.cc',
+          'trace_event/trace_event_memory.cc',
+          'trace_event/trace_event_memory.h',
+          'trace_event/trace_event_synthetic_delay.cc',
+          'trace_event/trace_event_synthetic_delay.h',
+          'trace_event/trace_event_system_stats_monitor.cc',
+          'trace_event/trace_event_system_stats_monitor.h',
+          'trace_event/trace_event_win.cc',
+          'trace_event/trace_event_win.h',
           'tracked_objects.cc',
           'tracked_objects.h',
           'tracking_info.cc',