From a613b275d8e820801248486346d1dda3a54a415c Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Sun, 16 May 2021 06:40:14 +0000 Subject: [PATCH] Delete most remaining unused STL includes. Headers that do not contain "std::" do not need STL includes. This CL is first mechanically generated as follows: INCL="algorithm|array|list|map|memory|queue|set|string|unordered_map|unordered_set|utility|vector" git ls-files | grep '\.h$' | xargs grep -L std:: | \ xargs grep -El "#include <($INCL)>$" > to_process.txt Remove a bunch of third party files from to_process.txt. INCL_ESCAPED="$(echo $INCL|sed 's/|/\\|/g')" cat to_process.txt | xargs sed -i "/^#include <\($INCL_ESCAPED\)>$/d" cat to_process.txt | xargs sed -i '/^$/N;/^\n$/D' Then fix the build in rlz/. Bug: 1200833 Change-Id: I7c48cdb53ec85412b6331df626f2f5c4c0174faa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2896225 Commit-Queue: Lei Zhang Reviewed-by: Nico Weber Owners-Override: Nico Weber Cr-Commit-Position: refs/heads/master@{#883318} --- apps/ui/views/app_window_frame_view.h | 2 -- base/numerics/safe_math_arm_impl.h | 1 - .../compositor/scene_layer/toolbar_swipe_scene_layer.h | 2 -- chrome/browser/chromeos/full_restore/arc_window_utils.h | 2 -- .../password_manager/chrome_biometric_authenticator.h | 2 -- chrome/browser/sharing_hub/sharing_hub_service_factory.h | 2 -- chrome/browser/ui/search/omnibox_utils.h | 3 --- .../ui/views/sharing_hub/sharing_hub_bubble_action_button.h | 2 -- chrome/browser/ui/views/side_panel.h | 2 -- chrome/browser/ui/views/toolbar/browser_app_menu_button.h | 3 --- chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h | 2 -- chrome/common/search/mock_embedded_search_client.h | 2 -- chromeos/dbus/cicerone/cicerone_client.h | 2 -- chromeos/dbus/concierge/concierge_client.h | 2 -- components/infobars/content/content_infobar_manager.h | 3 --- components/password_manager/content/browser/bad_message.h | 2 -- .../internal/database/user_action_database.h | 2 -- .../public/segmentation_platform_service.h | 2 -- components/send_tab_to_self/metrics_util.h | 2 -- components/viz/common/frame_sinks/copy_output_result.h | 3 --- components/viz/common/transition_utils.h | 2 -- content/browser/indexed_db/indexed_db_data_format_version.h | 1 - courgette/patch_generator_x86_32.h | 2 -- crypto/nss_util.h | 1 - crypto/scoped_capi_types.h | 2 -- fuchsia/base/message_port.h | 1 - fuchsia/engine/browser/content_directory_loader_factory.h | 3 --- fuchsia/engine/browser/event_filter.h | 1 - fuchsia/engine/browser/web_engine_browser_main.h | 2 -- fuchsia/engine/test/frame_test_helper.h | 1 - gin/v8_isolate_memory_dump_provider.h | 2 -- gin/v8_shared_memory_dump_provider.h | 2 -- headless/lib/browser/headless_devtools.h | 2 -- headless/public/headless_devtools_channel.h | 2 -- ios/chrome/browser/infobars/infobar_manager_impl.h | 2 -- ipc/ipc_channel_handle.h | 2 -- ppapi/cpp/network_proxy.h | 2 -- ppapi/cpp/text_input_controller.h | 2 -- ppapi/cpp/vpn_provider.h | 2 -- ppapi/proxy/gamepad_resource.h | 2 -- ppapi/proxy/host_var_serialization_rules.h | 2 -- ppapi/proxy/network_list_resource.h | 3 --- ppapi/proxy/network_monitor_resource.h | 2 -- ppapi/proxy/ppb_audio_proxy.h | 2 -- ppapi/proxy/ppb_var_deprecated_proxy.h | 2 -- ppapi/proxy/resource_creation_proxy.h | 2 -- ppapi/proxy/var_serialization_rules.h | 2 -- ppapi/shared_impl/id_assignment.h | 2 -- ppapi/shared_impl/ppb_url_util_shared.h | 2 -- ppapi/thunk/enter.h | 2 -- ppapi/thunk/ppb_audio_input_api.h | 2 -- ppapi/thunk/ppb_audio_output_api.h | 2 -- ppapi/thunk/ppb_camera_device_api.h | 2 -- ppapi/thunk/ppb_file_ref_api.h | 2 -- ppapi/thunk/ppb_network_list_api.h | 2 -- printing/print_settings_initializer_win.h | 2 -- rlz/lib/net_response_check.h | 6 ++++-- rlz/win/lib/machine_deal.h | 3 +-- skia/ext/skia_utils_mac.h | 1 - third_party/blink/renderer/core/paint/paint_info.h | 2 -- tools/traceline/traceline/rdtsc.h | 2 -- ui/base/ime/chromeos/typing_session_manager.h | 4 ---- ui/ozone/platform/scenic/safe_presenter.h | 2 -- ui/views/animation/test/test_ink_drop_host.h | 2 -- ui/views/controls/button/toggle_button.h | 2 -- 65 files changed, 5 insertions(+), 131 deletions(-) diff --git a/apps/ui/views/app_window_frame_view.h b/apps/ui/views/app_window_frame_view.h index d97e944b2d0dbd..2e0f954b5793ee 100644 --- a/apps/ui/views/app_window_frame_view.h +++ b/apps/ui/views/app_window_frame_view.h @@ -5,8 +5,6 @@ #ifndef APPS_UI_VIEWS_APP_WINDOW_FRAME_VIEW_H_ #define APPS_UI_VIEWS_APP_WINDOW_FRAME_VIEW_H_ -#include - #include "third_party/skia/include/core/SkColor.h" #include "ui/base/metadata/metadata_header_macros.h" #include "ui/gfx/geometry/rect.h" diff --git a/base/numerics/safe_math_arm_impl.h b/base/numerics/safe_math_arm_impl.h index f787dd07dfbcc1..dcf33a3d199955 100644 --- a/base/numerics/safe_math_arm_impl.h +++ b/base/numerics/safe_math_arm_impl.h @@ -6,7 +6,6 @@ #define BASE_NUMERICS_SAFE_MATH_ARM_IMPL_H_ #include -#include #include #include "base/numerics/safe_conversions.h" diff --git a/chrome/browser/android/compositor/scene_layer/toolbar_swipe_scene_layer.h b/chrome/browser/android/compositor/scene_layer/toolbar_swipe_scene_layer.h index 5644511b67f949..43220a0ca1f3ab 100644 --- a/chrome/browser/android/compositor/scene_layer/toolbar_swipe_scene_layer.h +++ b/chrome/browser/android/compositor/scene_layer/toolbar_swipe_scene_layer.h @@ -7,8 +7,6 @@ #include -#include - #include "base/memory/ref_counted.h" #include "chrome/browser/ui/android/layouts/scene_layer.h" #include "third_party/skia/include/core/SkColor.h" diff --git a/chrome/browser/chromeos/full_restore/arc_window_utils.h b/chrome/browser/chromeos/full_restore/arc_window_utils.h index fd3a19e9b04b64..ee2e3d314dafc7 100644 --- a/chrome/browser/chromeos/full_restore/arc_window_utils.h +++ b/chrome/browser/chromeos/full_restore/arc_window_utils.h @@ -5,8 +5,6 @@ #ifndef CHROME_BROWSER_CHROMEOS_FULL_RESTORE_ARC_WINDOW_UTILS_H_ #define CHROME_BROWSER_CHROMEOS_FULL_RESTORE_ARC_WINDOW_UTILS_H_ -#include - #include "components/services/app_service/public/mojom/types.mojom.h" #include "third_party/abseil-cpp/absl/types/optional.h" diff --git a/chrome/browser/password_manager/chrome_biometric_authenticator.h b/chrome/browser/password_manager/chrome_biometric_authenticator.h index 7905ee3022996c..369f77ecec44b8 100644 --- a/chrome/browser/password_manager/chrome_biometric_authenticator.h +++ b/chrome/browser/password_manager/chrome_biometric_authenticator.h @@ -5,8 +5,6 @@ #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_BIOMETRIC_AUTHENTICATOR_H_ #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_BIOMETRIC_AUTHENTICATOR_H_ -#include - #include "components/password_manager/core/browser/biometric_authenticator.h" namespace content { diff --git a/chrome/browser/sharing_hub/sharing_hub_service_factory.h b/chrome/browser/sharing_hub/sharing_hub_service_factory.h index 9cfd86a7ced16c..0fdb1baa2f87e6 100644 --- a/chrome/browser/sharing_hub/sharing_hub_service_factory.h +++ b/chrome/browser/sharing_hub/sharing_hub_service_factory.h @@ -5,8 +5,6 @@ #ifndef CHROME_BROWSER_SHARING_HUB_SHARING_HUB_SERVICE_FACTORY_H_ #define CHROME_BROWSER_SHARING_HUB_SHARING_HUB_SERVICE_FACTORY_H_ -#include - #include "base/macros.h" #include "base/memory/singleton.h" #include "components/keyed_service/content/browser_context_keyed_service_factory.h" diff --git a/chrome/browser/ui/search/omnibox_utils.h b/chrome/browser/ui/search/omnibox_utils.h index 96d19f814d91a1..7dca8401427c71 100644 --- a/chrome/browser/ui/search/omnibox_utils.h +++ b/chrome/browser/ui/search/omnibox_utils.h @@ -5,9 +5,6 @@ #ifndef CHROME_BROWSER_UI_SEARCH_OMNIBOX_UTILS_H_ #define CHROME_BROWSER_UI_SEARCH_OMNIBOX_UTILS_H_ -#include - - namespace content { class WebContents; } // namespace content diff --git a/chrome/browser/ui/views/sharing_hub/sharing_hub_bubble_action_button.h b/chrome/browser/ui/views/sharing_hub/sharing_hub_bubble_action_button.h index 6c91950777be0d..fb63289a451c7a 100644 --- a/chrome/browser/ui/views/sharing_hub/sharing_hub_bubble_action_button.h +++ b/chrome/browser/ui/views/sharing_hub/sharing_hub_bubble_action_button.h @@ -5,8 +5,6 @@ #ifndef CHROME_BROWSER_UI_VIEWS_SHARING_HUB_SHARING_HUB_BUBBLE_ACTION_BUTTON_H_ #define CHROME_BROWSER_UI_VIEWS_SHARING_HUB_SHARING_HUB_BUBBLE_ACTION_BUTTON_H_ -#include - #include "base/bind.h" #include "chrome/browser/ui/views/hover_button.h" diff --git a/chrome/browser/ui/views/side_panel.h b/chrome/browser/ui/views/side_panel.h index cd175bf6d48dae..9f540e9ed02785 100644 --- a/chrome/browser/ui/views/side_panel.h +++ b/chrome/browser/ui/views/side_panel.h @@ -5,8 +5,6 @@ #ifndef CHROME_BROWSER_UI_VIEWS_SIDE_PANEL_H_ #define CHROME_BROWSER_UI_VIEWS_SIDE_PANEL_H_ -#include - #include "ui/base/metadata/metadata_header_macros.h" #include "ui/views/bubble/bubble_dialog_delegate_view.h" #include "ui/views/view.h" diff --git a/chrome/browser/ui/views/toolbar/browser_app_menu_button.h b/chrome/browser/ui/views/toolbar/browser_app_menu_button.h index 14cdfd0006eb47..1697111973d4d7 100644 --- a/chrome/browser/ui/views/toolbar/browser_app_menu_button.h +++ b/chrome/browser/ui/views/toolbar/browser_app_menu_button.h @@ -5,9 +5,6 @@ #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_APP_MENU_BUTTON_H_ #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_BROWSER_APP_MENU_BUTTON_H_ -#include -#include - #include "base/memory/weak_ptr.h" #include "base/scoped_observation.h" #include "chrome/browser/ui/toolbar/app_menu_icon_controller.h" diff --git a/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h b/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h index 102f3acc9f87e7..b7614f6ebfcb4c 100644 --- a/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h +++ b/chrome/browser/ui/views/toolbar/toolbar_ink_drop_util.h @@ -5,8 +5,6 @@ #ifndef CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_INK_DROP_UTIL_H_ #define CHROME_BROWSER_UI_VIEWS_TOOLBAR_TOOLBAR_INK_DROP_UTIL_H_ -#include - #include "third_party/skia/include/core/SkColor.h" #include "ui/gfx/geometry/insets.h" #include "ui/gfx/geometry/point.h" diff --git a/chrome/common/search/mock_embedded_search_client.h b/chrome/common/search/mock_embedded_search_client.h index 492633a900d668..fe6141561f7ca6 100644 --- a/chrome/common/search/mock_embedded_search_client.h +++ b/chrome/common/search/mock_embedded_search_client.h @@ -5,8 +5,6 @@ #ifndef CHROME_COMMON_SEARCH_MOCK_EMBEDDED_SEARCH_CLIENT_H_ #define CHROME_COMMON_SEARCH_MOCK_EMBEDDED_SEARCH_CLIENT_H_ -#include - #include "chrome/common/search/instant_types.h" #include "chrome/common/search/search.mojom.h" #include "testing/gmock/include/gmock/gmock.h" diff --git a/chromeos/dbus/cicerone/cicerone_client.h b/chromeos/dbus/cicerone/cicerone_client.h index 1f68da86e38481..bf7cedb0a70c40 100644 --- a/chromeos/dbus/cicerone/cicerone_client.h +++ b/chromeos/dbus/cicerone/cicerone_client.h @@ -5,8 +5,6 @@ #ifndef CHROMEOS_DBUS_CICERONE_CICERONE_CLIENT_H_ #define CHROMEOS_DBUS_CICERONE_CICERONE_CLIENT_H_ -#include - #include "base/component_export.h" #include "base/observer_list.h" #include "chromeos/dbus/cicerone/cicerone_service.pb.h" diff --git a/chromeos/dbus/concierge/concierge_client.h b/chromeos/dbus/concierge/concierge_client.h index fafb839d343db4..5eff960058c1a5 100644 --- a/chromeos/dbus/concierge/concierge_client.h +++ b/chromeos/dbus/concierge/concierge_client.h @@ -5,8 +5,6 @@ #ifndef CHROMEOS_DBUS_CONCIERGE_CONCIERGE_CLIENT_H_ #define CHROMEOS_DBUS_CONCIERGE_CONCIERGE_CLIENT_H_ -#include - #include "base/component_export.h" #include "base/files/scoped_file.h" #include "base/observer_list.h" diff --git a/components/infobars/content/content_infobar_manager.h b/components/infobars/content/content_infobar_manager.h index 1be0788ed772ed..fedd7f412d93ff 100644 --- a/components/infobars/content/content_infobar_manager.h +++ b/components/infobars/content/content_infobar_manager.h @@ -5,9 +5,6 @@ #ifndef COMPONENTS_INFOBARS_CONTENT_CONTENT_INFOBAR_MANAGER_H_ #define COMPONENTS_INFOBARS_CONTENT_CONTENT_INFOBAR_MANAGER_H_ -#include -#include - #include "base/macros.h" #include "build/build_config.h" #include "components/infobars/core/infobar_manager.h" diff --git a/components/password_manager/content/browser/bad_message.h b/components/password_manager/content/browser/bad_message.h index 6619d7cd8c7deb..52caae8f3cf73e 100644 --- a/components/password_manager/content/browser/bad_message.h +++ b/components/password_manager/content/browser/bad_message.h @@ -5,8 +5,6 @@ #ifndef COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_BAD_MESSAGE_H_ #define COMPONENTS_PASSWORD_MANAGER_CONTENT_BROWSER_BAD_MESSAGE_H_ -#include - #include "base/containers/span.h" #include "components/autofill/core/common/form_data.h" diff --git a/components/segmentation_platform/internal/database/user_action_database.h b/components/segmentation_platform/internal/database/user_action_database.h index 4f8f946c0bb7bd..cbeda9c30cb9ae 100644 --- a/components/segmentation_platform/internal/database/user_action_database.h +++ b/components/segmentation_platform/internal/database/user_action_database.h @@ -5,8 +5,6 @@ #ifndef COMPONENTS_SEGMENTATION_PLATFORM_INTERNAL_DATABASE_USER_ACTION_DATABASE_H_ #define COMPONENTS_SEGMENTATION_PLATFORM_INTERNAL_DATABASE_USER_ACTION_DATABASE_H_ -#include - #include "base/time/time.h" namespace segmentation_platform { diff --git a/components/segmentation_platform/public/segmentation_platform_service.h b/components/segmentation_platform/public/segmentation_platform_service.h index 9532cb85c20225..ad6da2903dbfa3 100644 --- a/components/segmentation_platform/public/segmentation_platform_service.h +++ b/components/segmentation_platform/public/segmentation_platform_service.h @@ -5,8 +5,6 @@ #ifndef COMPONENTS_SEGMENTATION_PLATFORM_PUBLIC_SEGMENTATION_PLATFORM_SERVICE_H_ #define COMPONENTS_SEGMENTATION_PLATFORM_PUBLIC_SEGMENTATION_PLATFORM_SERVICE_H_ -#include - #include "components/keyed_service/core/keyed_service.h" namespace segmentation_platform { diff --git a/components/send_tab_to_self/metrics_util.h b/components/send_tab_to_self/metrics_util.h index c791969d0e94aa..2de88d396e0b4e 100644 --- a/components/send_tab_to_self/metrics_util.h +++ b/components/send_tab_to_self/metrics_util.h @@ -5,8 +5,6 @@ #ifndef COMPONENTS_SEND_TAB_TO_SELF_METRICS_UTIL_H_ #define COMPONENTS_SEND_TAB_TO_SELF_METRICS_UTIL_H_ -#include - namespace send_tab_to_self { enum class ShareEntryPoint { diff --git a/components/viz/common/frame_sinks/copy_output_result.h b/components/viz/common/frame_sinks/copy_output_result.h index a4940f4b7ca1b9..f21f3ebbdebce3 100644 --- a/components/viz/common/frame_sinks/copy_output_result.h +++ b/components/viz/common/frame_sinks/copy_output_result.h @@ -5,9 +5,6 @@ #ifndef COMPONENTS_VIZ_COMMON_FRAME_SINKS_COPY_OUTPUT_RESULT_H_ #define COMPONENTS_VIZ_COMMON_FRAME_SINKS_COPY_OUTPUT_RESULT_H_ -#include -#include - #include "base/threading/thread_checker.h" #include "components/viz/common/resources/release_callback.h" #include "components/viz/common/viz_common_export.h" diff --git a/components/viz/common/transition_utils.h b/components/viz/common/transition_utils.h index c6fdc9c9f9b759..d8ebcd0df8763e 100644 --- a/components/viz/common/transition_utils.h +++ b/components/viz/common/transition_utils.h @@ -5,8 +5,6 @@ #ifndef COMPONENTS_VIZ_COMMON_TRANSITION_UTILS_H_ #define COMPONENTS_VIZ_COMMON_TRANSITION_UTILS_H_ -#include - #include "components/viz/common/quads/compositor_render_pass.h" #include "components/viz/common/viz_common_export.h" diff --git a/content/browser/indexed_db/indexed_db_data_format_version.h b/content/browser/indexed_db/indexed_db_data_format_version.h index ed8f6cf9ef3866..6740218fc19a7a 100644 --- a/content/browser/indexed_db/indexed_db_data_format_version.h +++ b/content/browser/indexed_db/indexed_db_data_format_version.h @@ -6,7 +6,6 @@ #define CONTENT_BROWSER_INDEXED_DB_INDEXED_DB_DATA_FORMAT_VERSION_H_ #include -#include #include "base/check_op.h" #include "content/common/content_export.h" diff --git a/courgette/patch_generator_x86_32.h b/courgette/patch_generator_x86_32.h index 90ef5d49f27034..eac279fb21f44f 100644 --- a/courgette/patch_generator_x86_32.h +++ b/courgette/patch_generator_x86_32.h @@ -5,8 +5,6 @@ #ifndef COURGETTE_PATCH_GENERATOR_X86_32_H_ #define COURGETTE_PATCH_GENERATOR_X86_32_H_ -#include - #include "base/logging.h" #include "base/macros.h" #include "courgette/courgette_flow.h" diff --git a/crypto/nss_util.h b/crypto/nss_util.h index fd27095e4ed00d..0aace2d3170d0d 100644 --- a/crypto/nss_util.h +++ b/crypto/nss_util.h @@ -7,7 +7,6 @@ #include -#include #include "base/callback.h" #include "base/compiler_specific.h" #include "base/macros.h" diff --git a/crypto/scoped_capi_types.h b/crypto/scoped_capi_types.h index 408624b7a65d24..755a2ed6165749 100644 --- a/crypto/scoped_capi_types.h +++ b/crypto/scoped_capi_types.h @@ -7,8 +7,6 @@ #include -#include - #include "base/check.h" #include "base/macros.h" #include "base/win/wincrypt_shim.h" diff --git a/fuchsia/base/message_port.h b/fuchsia/base/message_port.h index 28b3c9f83d01c6..80ae9ee2455a2c 100644 --- a/fuchsia/base/message_port.h +++ b/fuchsia/base/message_port.h @@ -8,7 +8,6 @@ #include #include #include -#include #include "third_party/blink/public/common/messaging/web_message_port.h" diff --git a/fuchsia/engine/browser/content_directory_loader_factory.h b/fuchsia/engine/browser/content_directory_loader_factory.h index a110df9eaaf2fa..ba8b54ffa1b15c 100644 --- a/fuchsia/engine/browser/content_directory_loader_factory.h +++ b/fuchsia/engine/browser/content_directory_loader_factory.h @@ -8,9 +8,6 @@ #include #include #include -#include -#include -#include #include "fuchsia/engine/web_engine_export.h" #include "mojo/public/cpp/bindings/pending_receiver.h" diff --git a/fuchsia/engine/browser/event_filter.h b/fuchsia/engine/browser/event_filter.h index 8d3c7efcd75c42..e5a7b13a2b87d1 100644 --- a/fuchsia/engine/browser/event_filter.h +++ b/fuchsia/engine/browser/event_filter.h @@ -6,7 +6,6 @@ #define FUCHSIA_ENGINE_BROWSER_EVENT_FILTER_H_ #include -#include #include "base/macros.h" #include "fuchsia/engine/web_engine_export.h" diff --git a/fuchsia/engine/browser/web_engine_browser_main.h b/fuchsia/engine/browser/web_engine_browser_main.h index f70d9c3877c7ef..3d98aa51221e1a 100644 --- a/fuchsia/engine/browser/web_engine_browser_main.h +++ b/fuchsia/engine/browser/web_engine_browser_main.h @@ -5,8 +5,6 @@ #ifndef FUCHSIA_ENGINE_BROWSER_WEB_ENGINE_BROWSER_MAIN_H_ #define FUCHSIA_ENGINE_BROWSER_WEB_ENGINE_BROWSER_MAIN_H_ -#include - namespace content { struct MainFunctionParams; } // namespace content diff --git a/fuchsia/engine/test/frame_test_helper.h b/fuchsia/engine/test/frame_test_helper.h index 6d8b2dcf0d3f9a..5fba6227743f23 100644 --- a/fuchsia/engine/test/frame_test_helper.h +++ b/fuchsia/engine/test/frame_test_helper.h @@ -7,7 +7,6 @@ #include #include -#include #include "fuchsia/base/test/test_navigation_listener.h" diff --git a/gin/v8_isolate_memory_dump_provider.h b/gin/v8_isolate_memory_dump_provider.h index 44bdba9c86b3e3..2cd6346b2d1feb 100644 --- a/gin/v8_isolate_memory_dump_provider.h +++ b/gin/v8_isolate_memory_dump_provider.h @@ -5,8 +5,6 @@ #ifndef GIN_V8_ISOLATE_MEMORY_DUMP_PROVIDER_H_ #define GIN_V8_ISOLATE_MEMORY_DUMP_PROVIDER_H_ -#include - #include "base/single_thread_task_runner.h" #include "base/trace_event/memory_dump_provider.h" #include "gin/gin_export.h" diff --git a/gin/v8_shared_memory_dump_provider.h b/gin/v8_shared_memory_dump_provider.h index fb66f0b0f523f5..724d06eaf3285a 100644 --- a/gin/v8_shared_memory_dump_provider.h +++ b/gin/v8_shared_memory_dump_provider.h @@ -5,8 +5,6 @@ #ifndef GIN_V8_SHARED_MEMORY_DUMP_PROVIDER_H_ #define GIN_V8_SHARED_MEMORY_DUMP_PROVIDER_H_ -#include - #include "base/trace_event/memory_dump_provider.h" #include "gin/gin_export.h" diff --git a/headless/lib/browser/headless_devtools.h b/headless/lib/browser/headless_devtools.h index ba29e439632ff4..e5240c62ae9688 100644 --- a/headless/lib/browser/headless_devtools.h +++ b/headless/lib/browser/headless_devtools.h @@ -5,8 +5,6 @@ #ifndef HEADLESS_LIB_BROWSER_HEADLESS_DEVTOOLS_H_ #define HEADLESS_LIB_BROWSER_HEADLESS_DEVTOOLS_H_ -#include - #include "headless/lib/browser/headless_browser_impl.h" namespace headless { diff --git a/headless/public/headless_devtools_channel.h b/headless/public/headless_devtools_channel.h index 310b7650c5e7fb..49aa4c3cb4fa94 100644 --- a/headless/public/headless_devtools_channel.h +++ b/headless/public/headless_devtools_channel.h @@ -5,8 +5,6 @@ #ifndef HEADLESS_PUBLIC_HEADLESS_DEVTOOLS_CHANNEL_H_ #define HEADLESS_PUBLIC_HEADLESS_DEVTOOLS_CHANNEL_H_ -#include - #include "base/containers/span.h" #include "base/macros.h" #include "headless/public/headless_export.h" diff --git a/ios/chrome/browser/infobars/infobar_manager_impl.h b/ios/chrome/browser/infobars/infobar_manager_impl.h index cc0d1f3ad72280..d7acc55ab8ca9e 100644 --- a/ios/chrome/browser/infobars/infobar_manager_impl.h +++ b/ios/chrome/browser/infobars/infobar_manager_impl.h @@ -5,8 +5,6 @@ #ifndef IOS_CHROME_BROWSER_INFOBARS_INFOBAR_MANAGER_IMPL_H_ #define IOS_CHROME_BROWSER_INFOBARS_INFOBAR_MANAGER_IMPL_H_ -#include - #include "base/macros.h" #include "components/infobars/core/infobar_manager.h" #include "ios/web/public/web_state_observer.h" diff --git a/ipc/ipc_channel_handle.h b/ipc/ipc_channel_handle.h index ef31b8434c4ef6..58904ac2c4fecb 100644 --- a/ipc/ipc_channel_handle.h +++ b/ipc/ipc_channel_handle.h @@ -5,8 +5,6 @@ #ifndef IPC_IPC_CHANNEL_HANDLE_H_ #define IPC_IPC_CHANNEL_HANDLE_H_ -#include - #include "build/build_config.h" #include "mojo/public/cpp/system/message_pipe.h" diff --git a/ppapi/cpp/network_proxy.h b/ppapi/cpp/network_proxy.h index 26fd9e95d2362d..6c851b55bca3b4 100644 --- a/ppapi/cpp/network_proxy.h +++ b/ppapi/cpp/network_proxy.h @@ -7,8 +7,6 @@ #include -#include - #include "ppapi/cpp/completion_callback.h" #include "ppapi/cpp/instance_handle.h" diff --git a/ppapi/cpp/text_input_controller.h b/ppapi/cpp/text_input_controller.h index 8c34c73e852804..b396f5ebc51ea3 100644 --- a/ppapi/cpp/text_input_controller.h +++ b/ppapi/cpp/text_input_controller.h @@ -7,8 +7,6 @@ #include -#include - #include "ppapi/c/ppb_text_input_controller.h" #include "ppapi/cpp/instance_handle.h" #include "ppapi/cpp/var.h" diff --git a/ppapi/cpp/vpn_provider.h b/ppapi/cpp/vpn_provider.h index 9d94981e586134..12fbd50e5815eb 100644 --- a/ppapi/cpp/vpn_provider.h +++ b/ppapi/cpp/vpn_provider.h @@ -5,8 +5,6 @@ #ifndef PPAPI_CPP_VPN_PROVIDER_H_ #define PPAPI_CPP_VPN_PROVIDER_H_ -#include - #include "ppapi/c/ppb_vpn_provider.h" #include "ppapi/cpp/completion_callback.h" diff --git a/ppapi/proxy/gamepad_resource.h b/ppapi/proxy/gamepad_resource.h index 957f058bd209b1..1df1a96a2c0d05 100644 --- a/ppapi/proxy/gamepad_resource.h +++ b/ppapi/proxy/gamepad_resource.h @@ -5,8 +5,6 @@ #ifndef PPAPI_PROXY_GAMEPAD_RESOURCE_H_ #define PPAPI_PROXY_GAMEPAD_RESOURCE_H_ -#include - #include "base/compiler_specific.h" #include "base/macros.h" #include "base/memory/shared_memory_mapping.h" diff --git a/ppapi/proxy/host_var_serialization_rules.h b/ppapi/proxy/host_var_serialization_rules.h index 404312f05222c0..c5c93d2e5a90e6 100644 --- a/ppapi/proxy/host_var_serialization_rules.h +++ b/ppapi/proxy/host_var_serialization_rules.h @@ -5,8 +5,6 @@ #ifndef PPAPI_PROXY_HOST_VAR_SERIALIZATION_RULES_H_ #define PPAPI_PROXY_HOST_VAR_SERIALIZATION_RULES_H_ -#include - #include "base/macros.h" #include "ppapi/c/ppb_var.h" #include "ppapi/proxy/var_serialization_rules.h" diff --git a/ppapi/proxy/network_list_resource.h b/ppapi/proxy/network_list_resource.h index 66ea8aa3aeeacc..9a497dfe941209 100644 --- a/ppapi/proxy/network_list_resource.h +++ b/ppapi/proxy/network_list_resource.h @@ -7,9 +7,6 @@ #include -#include -#include - #include "base/macros.h" #include "base/memory/ref_counted.h" #include "ppapi/c/private/ppb_net_address_private.h" diff --git a/ppapi/proxy/network_monitor_resource.h b/ppapi/proxy/network_monitor_resource.h index 77b3e614dc3f17..9d23a4d08f2ae2 100644 --- a/ppapi/proxy/network_monitor_resource.h +++ b/ppapi/proxy/network_monitor_resource.h @@ -7,8 +7,6 @@ #include -#include - #include "base/macros.h" #include "ppapi/proxy/network_list_resource.h" #include "ppapi/proxy/plugin_resource.h" diff --git a/ppapi/proxy/ppb_audio_proxy.h b/ppapi/proxy/ppb_audio_proxy.h index 2082c7e6ed1098..6d50479e3bec01 100644 --- a/ppapi/proxy/ppb_audio_proxy.h +++ b/ppapi/proxy/ppb_audio_proxy.h @@ -7,8 +7,6 @@ #include -#include - #include "base/macros.h" #include "base/memory/unsafe_shared_memory_region.h" #include "base/sync_socket.h" diff --git a/ppapi/proxy/ppb_var_deprecated_proxy.h b/ppapi/proxy/ppb_var_deprecated_proxy.h index 62cb002bc40b72..c440381df11aba 100644 --- a/ppapi/proxy/ppb_var_deprecated_proxy.h +++ b/ppapi/proxy/ppb_var_deprecated_proxy.h @@ -7,8 +7,6 @@ #include -#include - #include "base/macros.h" #include "base/memory/weak_ptr.h" #include "ppapi/c/pp_instance.h" diff --git a/ppapi/proxy/resource_creation_proxy.h b/ppapi/proxy/resource_creation_proxy.h index 5f7377327ae5ed..4058bcd178806b 100644 --- a/ppapi/proxy/resource_creation_proxy.h +++ b/ppapi/proxy/resource_creation_proxy.h @@ -7,8 +7,6 @@ #include -#include - #include "base/macros.h" #include "build/build_config.h" #include "ipc/ipc_channel.h" diff --git a/ppapi/proxy/var_serialization_rules.h b/ppapi/proxy/var_serialization_rules.h index 399cff326ecf2d..1526afb2cfedc0 100644 --- a/ppapi/proxy/var_serialization_rules.h +++ b/ppapi/proxy/var_serialization_rules.h @@ -8,8 +8,6 @@ #include "base/memory/ref_counted.h" #include "ppapi/c/pp_var.h" -#include - namespace ppapi { namespace proxy { diff --git a/ppapi/shared_impl/id_assignment.h b/ppapi/shared_impl/id_assignment.h index 1444f2f609f3f1..73450da69cc898 100644 --- a/ppapi/shared_impl/id_assignment.h +++ b/ppapi/shared_impl/id_assignment.h @@ -7,8 +7,6 @@ #include -#include - #include "ppapi/shared_impl/ppapi_shared_export.h" namespace ppapi { diff --git a/ppapi/shared_impl/ppb_url_util_shared.h b/ppapi/shared_impl/ppb_url_util_shared.h index 6d8161751b4062..bef6ad1f860884 100644 --- a/ppapi/shared_impl/ppb_url_util_shared.h +++ b/ppapi/shared_impl/ppb_url_util_shared.h @@ -5,8 +5,6 @@ #ifndef PPAPI_SHARED_IMPL_PPB_URL_UTIL_SHARED_H_ #define PPAPI_SHARED_IMPL_PPB_URL_UTIL_SHARED_H_ -#include - #include "ppapi/c/dev/ppb_url_util_dev.h" #include "ppapi/c/pp_var.h" #include "ppapi/shared_impl/ppapi_shared_export.h" diff --git a/ppapi/thunk/enter.h b/ppapi/thunk/enter.h index 041a2dd5883798..25e7935a2204de 100644 --- a/ppapi/thunk/enter.h +++ b/ppapi/thunk/enter.h @@ -7,8 +7,6 @@ #include -#include - #include "base/macros.h" #include "base/memory/ref_counted.h" #include "ppapi/c/pp_errors.h" diff --git a/ppapi/thunk/ppb_audio_input_api.h b/ppapi/thunk/ppb_audio_input_api.h index 196a386d223bfe..ee0aa3a0dd6b2c 100644 --- a/ppapi/thunk/ppb_audio_input_api.h +++ b/ppapi/thunk/ppb_audio_input_api.h @@ -7,8 +7,6 @@ #include -#include - #include "base/memory/ref_counted.h" #include "ppapi/c/dev/ppb_audio_input_dev.h" diff --git a/ppapi/thunk/ppb_audio_output_api.h b/ppapi/thunk/ppb_audio_output_api.h index 4fceee757d1111..ea8d7e52bed7db 100644 --- a/ppapi/thunk/ppb_audio_output_api.h +++ b/ppapi/thunk/ppb_audio_output_api.h @@ -7,8 +7,6 @@ #include -#include - #include "base/memory/ref_counted.h" #include "ppapi/c/dev/ppb_audio_output_dev.h" diff --git a/ppapi/thunk/ppb_camera_device_api.h b/ppapi/thunk/ppb_camera_device_api.h index 05924ec9c4ad34..5935315a08b059 100644 --- a/ppapi/thunk/ppb_camera_device_api.h +++ b/ppapi/thunk/ppb_camera_device_api.h @@ -7,8 +7,6 @@ #include -#include - #include "ppapi/c/private/ppb_camera_device_private.h" #include "ppapi/thunk/ppapi_thunk_export.h" diff --git a/ppapi/thunk/ppb_file_ref_api.h b/ppapi/thunk/ppb_file_ref_api.h index 73adf86de2dc05..76cf236230cc32 100644 --- a/ppapi/thunk/ppb_file_ref_api.h +++ b/ppapi/thunk/ppb_file_ref_api.h @@ -7,8 +7,6 @@ #include -#include - #include "base/memory/ref_counted.h" #include "ppapi/c/ppb_file_ref.h" #include "ppapi/shared_impl/file_ref_create_info.h" diff --git a/ppapi/thunk/ppb_network_list_api.h b/ppapi/thunk/ppb_network_list_api.h index 10b4046591651f..d08f2289ea0f0c 100644 --- a/ppapi/thunk/ppb_network_list_api.h +++ b/ppapi/thunk/ppb_network_list_api.h @@ -7,8 +7,6 @@ #include -#include - #include "ppapi/c/ppb_network_list.h" #include "ppapi/thunk/ppapi_thunk_export.h" diff --git a/printing/print_settings_initializer_win.h b/printing/print_settings_initializer_win.h index de76e992b7250c..e7e9645847a747 100644 --- a/printing/print_settings_initializer_win.h +++ b/printing/print_settings_initializer_win.h @@ -5,8 +5,6 @@ #ifndef PRINTING_PRINT_SETTINGS_INITIALIZER_WIN_H_ #define PRINTING_PRINT_SETTINGS_INITIALIZER_WIN_H_ -#include - #include "printing/page_range.h" typedef struct HDC__* HDC; diff --git a/rlz/lib/net_response_check.h b/rlz/lib/net_response_check.h index 7098da779828df..6e7d7f10989264 100644 --- a/rlz/lib/net_response_check.h +++ b/rlz/lib/net_response_check.h @@ -6,14 +6,16 @@ #ifndef RLZ_LIB_NET_RESPONSE_CHECK_H_ #define RLZ_LIB_NET_RESPONSE_CHECK_H_ -#include +#include + #include "rlz/lib/rlz_api.h" // Checksum validation convenience call for RLZ network responses. namespace rlz_lib { + // The maximum length of a ping response we will parse in bytes. If the response // is bigger, please break it up into separate calls. -const size_t kMaxPingResponseLength = 0x4000; // 16K +constexpr size_t kMaxPingResponseLength = 0x4000; // 16K // Checks if a ping response is valid - ie. it has a checksum line which // is the CRC-32 checksum of the message up to the checksum. If diff --git a/rlz/win/lib/machine_deal.h b/rlz/win/lib/machine_deal.h index d3bebe4c4f02df..5f5aa211efb9aa 100644 --- a/rlz/win/lib/machine_deal.h +++ b/rlz/win/lib/machine_deal.h @@ -7,7 +7,6 @@ #ifndef RLZ_WIN_LIB_MACHINE_DEAL_H_ #define RLZ_WIN_LIB_MACHINE_DEAL_H_ -#include #include "rlz/lib/rlz_enums.h" namespace rlz_lib { @@ -24,7 +23,7 @@ class MachineDealCode { static bool Get(AccessPoint point, char* dcc, int dcc_size, - const wchar_t* sid = NULL); + const wchar_t* sid = nullptr); // Parses a ping response, checks if it is valid and sets the machine DCC // from the response. The response should also contain the current value of diff --git a/skia/ext/skia_utils_mac.h b/skia/ext/skia_utils_mac.h index 25fe2d72ce1c0d..53ab36130f67b5 100644 --- a/skia/ext/skia_utils_mac.h +++ b/skia/ext/skia_utils_mac.h @@ -6,7 +6,6 @@ #define SKIA_EXT_SKIA_UTILS_MAC_H_ #include -#include #include "third_party/skia/include/core/SkBitmap.h" #include "third_party/skia/include/core/SkColor.h" diff --git a/third_party/blink/renderer/core/paint/paint_info.h b/third_party/blink/renderer/core/paint/paint_info.h index a0950407858bae..37f149818afb65 100644 --- a/third_party/blink/renderer/core/paint/paint_info.h +++ b/third_party/blink/renderer/core/paint/paint_info.h @@ -46,8 +46,6 @@ #include "third_party/blink/renderer/platform/wtf/allocator/allocator.h" #include "third_party/blink/renderer/platform/wtf/hash_map.h" -#include - namespace blink { class LayoutBoxModelObject; diff --git a/tools/traceline/traceline/rdtsc.h b/tools/traceline/traceline/rdtsc.h index 7c3cb1a9676129..50295a7ee5d5f8 100644 --- a/tools/traceline/traceline/rdtsc.h +++ b/tools/traceline/traceline/rdtsc.h @@ -8,8 +8,6 @@ #include #include -#include - #include "logging.h" class RDTSCNormalizer { diff --git a/ui/base/ime/chromeos/typing_session_manager.h b/ui/base/ime/chromeos/typing_session_manager.h index 2b57176f88aab5..17813547c8f586 100644 --- a/ui/base/ime/chromeos/typing_session_manager.h +++ b/ui/base/ime/chromeos/typing_session_manager.h @@ -7,10 +7,6 @@ #include -#include -#include -#include - #include "base/macros.h" #include "base/time/default_clock.h" #include "base/time/time.h" diff --git a/ui/ozone/platform/scenic/safe_presenter.h b/ui/ozone/platform/scenic/safe_presenter.h index 91099573a6f870..024c1b80b7b06a 100644 --- a/ui/ozone/platform/scenic/safe_presenter.h +++ b/ui/ozone/platform/scenic/safe_presenter.h @@ -7,8 +7,6 @@ #include -#include - namespace ui { using QueuePresentCallback = fit::function; diff --git a/ui/views/animation/test/test_ink_drop_host.h b/ui/views/animation/test/test_ink_drop_host.h index 957fdad4d3542d..95d96986de6a6a 100644 --- a/ui/views/animation/test/test_ink_drop_host.h +++ b/ui/views/animation/test/test_ink_drop_host.h @@ -5,8 +5,6 @@ #ifndef UI_VIEWS_ANIMATION_TEST_TEST_INK_DROP_HOST_H_ #define UI_VIEWS_ANIMATION_TEST_TEST_INK_DROP_HOST_H_ -#include - #include "base/macros.h" #include "ui/views/animation/ink_drop_host_view.h" diff --git a/ui/views/controls/button/toggle_button.h b/ui/views/controls/button/toggle_button.h index fe077f4864212b..a3085f292ba3cf 100644 --- a/ui/views/controls/button/toggle_button.h +++ b/ui/views/controls/button/toggle_button.h @@ -5,8 +5,6 @@ #ifndef UI_VIEWS_CONTROLS_BUTTON_TOGGLE_BUTTON_H_ #define UI_VIEWS_CONTROLS_BUTTON_TOGGLE_BUTTON_H_ -#include - #include "third_party/abseil-cpp/absl/types/optional.h" #include "ui/gfx/animation/slide_animation.h" #include "ui/views/controls/button/button.h"