forked from chromium/chromium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reapply 266653 "[Mac] Allow fullscreen transitions while constrai..."
PrintPreviewTest.TaskManagerNewPrintPreview was something else's fault. > Revert 266653 "[Mac] Allow fullscreen transitions while constrai..." > > Mac Tests (dbg) failing for PrintPreviewTest.TaskManagerNewPrintPreview > http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/23012 > > > > [Mac] Allow fullscreen transitions while constrained windows are open. > > > > r166410 disabled the browser from entering fullscreen mode when any one > > tab has a constrained window open (e.g., Print dialog). However, this > > is inconsistent with the behavior on all other desktop platforms. This > > change removes the restriction. > > > > Landing on behalf of miu@chromium.org manually, as to make a branch cut. > > > > BUG=366567,146451 > > TEST=Repro steps in bug 366567 (easier to understand from the multiple demo videos). Also, manual testing of browser transition into and out of fullscreen before/after a print dialog is open. > > R=avi@chromium.org, sky@chromium.org > > > > Review URL: https://codereview.chromium.org/253493005 > > TBR=avi@chromium.org > > Review URL: https://codereview.chromium.org/252693007 TBR=ajwong@chromium.org Review URL: https://codereview.chromium.org/252233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266899 0039d316-1c4b-4281-b951-d872f2087c98
- Loading branch information
ajwong@chromium.org
committed
Apr 29, 2014
1 parent
dd50993
commit aeafc38
Showing
6 changed files
with
15 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters