Skip to content

Commit

Permalink
NewMessageListView: Remove the flag.
Browse files Browse the repository at this point in the history
This is the 2nd part of 3 CLs removing old MessageListView code.
The split is suggested in the review. https://crrev.com/c/1292667

(1) Removing the old implementation
(2) Removing the flag
(3) Renaming the implementation

TEST=trybot pass
BUG=870801

Change-Id: Id9b08072e9d9a35ca785552056b5056e0dc608e4
Reviewed-on: https://chromium-review.googlesource.com/c/1297769
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602593}
  • Loading branch information
Tetsui Ohkubo authored and Commit Bot committed Oct 25, 2018
1 parent 5141c56 commit af0d05d
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 29 deletions.
7 changes: 0 additions & 7 deletions ash/public/cpp/ash_features.cc
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ const base::Feature kLockScreenHideSensitiveNotificationsSupport{
"LockScreenHideSensitiveNotificationsSupport",
base::FEATURE_DISABLED_BY_DEFAULT};

const base::Feature kNewMessageListView{"NewMessageListView",
base::FEATURE_ENABLED_BY_DEFAULT};

const base::Feature kMediaSessionAccelerators{
"MediaSessionAccelerators", base::FEATURE_DISABLED_BY_DEFAULT};

Expand Down Expand Up @@ -85,10 +82,6 @@ bool IsLockScreenHideSensitiveNotificationsSupported() {
kLockScreenHideSensitiveNotificationsSupport);
}

bool IsNewMessageListViewEnabled() {
return base::FeatureList::IsEnabled(kNewMessageListView);
}

bool IsNightLightEnabled() {
return base::FeatureList::IsEnabled(kNightLight);
}
Expand Down
5 changes: 0 additions & 5 deletions ash/public/cpp/ash_features.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,6 @@ ASH_PUBLIC_EXPORT extern const base::Feature
// TODO(beccahughes): Remove after launch. (https://crbug.com/894255)
ASH_PUBLIC_EXPORT extern const base::Feature kMediaSessionAccelerators;

// Enables new message list view. https://crbug.com/769219
ASH_PUBLIC_EXPORT extern const base::Feature kNewMessageListView;

// Enables the Night Light feature.
ASH_PUBLIC_EXPORT extern const base::Feature kNightLight;

Expand Down Expand Up @@ -92,8 +89,6 @@ ASH_PUBLIC_EXPORT bool IsLockScreenInlineReplyEnabled();

ASH_PUBLIC_EXPORT bool IsLockScreenHideSensitiveNotificationsSupported();

ASH_PUBLIC_EXPORT bool IsNewMessageListViewEnabled();

ASH_PUBLIC_EXPORT bool IsNightLightEnabled();

ASH_PUBLIC_EXPORT bool IsNotificationScrollBarEnabled();
Expand Down
4 changes: 0 additions & 4 deletions chrome/browser/about_flags.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1692,10 +1692,6 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kEnableNotificationScrollBarName,
flag_descriptions::kEnableNotificationScrollBarDescription, kOsCrOS,
FEATURE_VALUE_TYPE(ash::features::kNotificationScrollBar)},
{"ash-enable-new-message-list-view",
flag_descriptions::kEnableNewMessageListViewName,
flag_descriptions::kEnableNewMessageListViewDescription, kOsCrOS,
FEATURE_VALUE_TYPE(ash::features::kNewMessageListView)},
{"allow-touchpad-three-finger-click",
flag_descriptions::kAllowTouchpadThreeFingerClickName,
flag_descriptions::kAllowTouchpadThreeFingerClickDescription, kOsCrOS,
Expand Down
7 changes: 0 additions & 7 deletions chrome/browser/flag_descriptions.cc
Original file line number Diff line number Diff line change
Expand Up @@ -670,10 +670,6 @@ const char kEnableNotificationScrollBarName[] =
const char kEnableNotificationScrollBarDescription[] =
"Enable the scroll bar of the notification list in Unified System Tray.";

const char kEnableNewMessageListViewName[] = "Enable new message list view";
const char kEnableNewMessageListViewDescription[] =
"Enable new implementation of message list view.";

const char kEnableNupPrintingName[] = "Enable N-up printing";
const char kEnableNupPrintingDescription[] =
"Enable N-up printing in the print preview panel.";
Expand Down Expand Up @@ -1638,9 +1634,6 @@ const char kShelfHoverPreviewsDescription[] =
"Shows previews of the open windows for a given running app when hovering "
"over the shelf.";

const char kShelfNewUiName[] = "Newest shelf redesign.";
const char kShelfNewUiDescription[] = "Enables the newest shelf appearance.";

const char kShowAndroidFilesInFilesAppName[] =
"Show Android files in Files app";
const char kShowAndroidFilesInFilesAppDescription[] =
Expand Down
6 changes: 0 additions & 6 deletions chrome/browser/flag_descriptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,6 @@ extern const char kEnableNightLightDescription[];
extern const char kEnableNotificationScrollBarName[];
extern const char kEnableNotificationScrollBarDescription[];

extern const char kEnableNewMessageListViewName[];
extern const char kEnableNewMessageListViewDescription[];

extern const char kEnableNupPrintingName[];
extern const char kEnableNupPrintingDescription[];

Expand Down Expand Up @@ -993,9 +990,6 @@ extern const char kSettingsWindowDescription[];
extern const char kShelfHoverPreviewsName[];
extern const char kShelfHoverPreviewsDescription[];

extern const char kShelfNewUiName[];
extern const char kShelfNewUiDescription[];

extern const char kShowAndroidFilesInFilesAppName[];
extern const char kShowAndroidFilesInFilesAppDescription[];

Expand Down

0 comments on commit af0d05d

Please sign in to comment.